Skip to content
Source
Sign inSign up
TanStack/db

[repro] findOne returns array instead of single object in angular-db (issue #1261) #1272

Closedclaude[bot](GitHub profile, opens in a new tab)wants to merge 3 commits intomain fromai/issue-1261-reproopened

Summary

  • Adds a test that asserts injectLiveQuery with findOne() returns a single object instead of an array
  • Test currently fails on main because data() returns [{ id: '3', ... }] (array) instead of { id: '3', ... } (object)

Linked issue: https://github.com/TanStack/db/issues/1261

What the test asserts

  • Array.isArray(data()) is false (currently true)
  • data() matches { id: '3', name: 'John Smith' } as a plain object

How to run

pnpm --filter @tanstack/angular-db test -- --run

Observed failure

AssertionError: expected true to be false // Object.is equality
  - Expected: false
  + Received: true
  ❯ tests/inject-live-query.test.ts:781:37

🤖 Generated with Claude Code

    1. ⚠️ No Changeset found

      Latest commit: a137fcaa65bbd9cf8c0a9c9142eb33ddc855902e

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. More templates

      @tanstack/angular-db

      npm i https://pkg.pr.new/@tanstack/angular-db@1272

      @tanstack/db

      npm i https://pkg.pr.new/@tanstack/db@1272

      @tanstack/db-ivm

      npm i https://pkg.pr.new/@tanstack/db-ivm@1272

      @tanstack/electric-db-collection

      npm i https://pkg.pr.new/@tanstack/electric-db-collection@1272

      @tanstack/offline-transactions

      npm i https://pkg.pr.new/@tanstack/offline-transactions@1272

      @tanstack/powersync-db-collection

      npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1272

      @tanstack/query-db-collection

      npm i https://pkg.pr.new/@tanstack/query-db-collection@1272

      @tanstack/react-db

      npm i https://pkg.pr.new/@tanstack/react-db@1272

      @tanstack/rxdb-db-collection

      npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1272

      @tanstack/solid-db

      npm i https://pkg.pr.new/@tanstack/solid-db@1272

      @tanstack/svelte-db

      npm i https://pkg.pr.new/@tanstack/svelte-db@1272

      @tanstack/trailbase-db-collection

      npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1272

      @tanstack/vue-db

      npm i https://pkg.pr.new/@tanstack/vue-db@1272

      commit: a137fca

    3. Size Change: 0 B

      Total Size: 92.1 kB

      ℹ️ View Unchanged
      FilenameSize
      ./packages/db/dist/esm/collection/change-events.js1.39 kB
      ./packages/db/dist/esm/collection/changes.js1.22 kB
      ./packages/db/dist/esm/collection/events.js388 B
      ./packages/db/dist/esm/collection/index.js3.32 kB
      ./packages/db/dist/esm/collection/indexes.js1.1 kB
      ./packages/db/dist/esm/collection/lifecycle.js1.75 kB
      ./packages/db/dist/esm/collection/mutations.js2.34 kB
      ./packages/db/dist/esm/collection/state.js3.49 kB
      ./packages/db/dist/esm/collection/subscription.js3.71 kB
      ./packages/db/dist/esm/collection/sync.js2.41 kB
      ./packages/db/dist/esm/deferred.js207 B
      ./packages/db/dist/esm/errors.js4.7 kB
      ./packages/db/dist/esm/event-emitter.js748 B
      ./packages/db/dist/esm/index.js2.69 kB
      ./packages/db/dist/esm/indexes/auto-index.js742 B
      ./packages/db/dist/esm/indexes/base-index.js766 B
      ./packages/db/dist/esm/indexes/btree-index.js2.17 kB
      ./packages/db/dist/esm/indexes/lazy-index.js1.1 kB
      ./packages/db/dist/esm/indexes/reverse-index.js538 B
      ./packages/db/dist/esm/local-only.js808 B
      ./packages/db/dist/esm/local-storage.js2.1 kB
      ./packages/db/dist/esm/optimistic-action.js359 B
      ./packages/db/dist/esm/paced-mutations.js496 B
      ./packages/db/dist/esm/proxy.js3.75 kB
      ./packages/db/dist/esm/query/builder/functions.js733 B
      ./packages/db/dist/esm/query/builder/index.js4.09 kB
      ./packages/db/dist/esm/query/builder/ref-proxy.js1.05 kB
      ./packages/db/dist/esm/query/compiler/evaluators.js1.43 kB
      ./packages/db/dist/esm/query/compiler/expressions.js430 B
      ./packages/db/dist/esm/query/compiler/group-by.js1.81 kB
      ./packages/db/dist/esm/query/compiler/index.js2.02 kB
      ./packages/db/dist/esm/query/compiler/joins.js2.11 kB
      ./packages/db/dist/esm/query/compiler/order-by.js1.45 kB
      ./packages/db/dist/esm/query/compiler/select.js1.06 kB
      ./packages/db/dist/esm/query/expression-helpers.js1.43 kB
      ./packages/db/dist/esm/query/ir.js673 B
      ./packages/db/dist/esm/query/live-query-collection.js360 B
      ./packages/db/dist/esm/query/live/collection-config-builder.js5.44 kB
      ./packages/db/dist/esm/query/live/collection-registry.js264 B
      ./packages/db/dist/esm/query/live/collection-subscriber.js2.42 kB
      ./packages/db/dist/esm/query/live/internal.js145 B
      ./packages/db/dist/esm/query/optimizer.js2.62 kB
      ./packages/db/dist/esm/query/predicate-utils.js2.97 kB
      ./packages/db/dist/esm/query/subset-dedupe.js921 B
      ./packages/db/dist/esm/scheduler.js1.3 kB
      ./packages/db/dist/esm/SortedMap.js1.3 kB
      ./packages/db/dist/esm/strategies/debounceStrategy.js247 B
      ./packages/db/dist/esm/strategies/queueStrategy.js428 B
      ./packages/db/dist/esm/strategies/throttleStrategy.js246 B
      ./packages/db/dist/esm/transactions.js2.9 kB
      ./packages/db/dist/esm/utils.js924 B
      ./packages/db/dist/esm/utils/browser-polyfills.js304 B
      ./packages/db/dist/esm/utils/btree.js5.61 kB
      ./packages/db/dist/esm/utils/comparison.js952 B
      ./packages/db/dist/esm/utils/cursor.js457 B
      ./packages/db/dist/esm/utils/index-optimization.js1.51 kB
      ./packages/db/dist/esm/utils/type-guards.js157 B
      compressed-size-action::db-package-size
    4. Size Change: 0 B

      Total Size: 3.7 kB

      ℹ️ View Unchanged
      FilenameSize
      ./packages/react-db/dist/esm/index.js225 B
      ./packages/react-db/dist/esm/useLiveInfiniteQuery.js1.17 kB
      ./packages/react-db/dist/esm/useLiveQuery.js1.34 kB
      ./packages/react-db/dist/esm/useLiveSuspenseQuery.js559 B
      ./packages/react-db/dist/esm/usePacedMutations.js401 B
      compressed-size-action::react-db-package-size
    5. Closing as superseded by merged PR #1273. The merged fix includes the Angular findOne runtime correction plus the same runtime and type regression coverage, so this standalone failing reproduction is no longer needed.

Sign in to join this conversation.