fix: lazy load includes child collections in on-demand sync mode #1471
Merged
kevin-dp(GitHub profile, opens in a new tab)merged 6 commits into
main fromrefs/pull/1471/head·merged by kevin-dp(GitHub profile, opens in a new tab) Summary#
- Includes child collections now use lazy loading (matching the existing join optimization), so only rows matching parent correlation keys are loaded on-demand via
requestSnapshot({ where: inArray(field, keys) }) - Previously, includes child collections loaded ALL data upfront because the correlation WHERE clause was consumed by the inner join and no filter was passed to the sync layer's
loadSubset/queryFn - Adds 6 new tests verifying the lazy loading behavior for includes
Fixes #1441
Test plan#
- New tests in
includes-lazy-loading.test.tsverify:- Correlation filter (
inArray) is passed to child collection'sloadSubset - Query results remain correct with lazy-loaded includes
- Child source is marked lazy (no eager full load without filter)
- Reactive loading when new parent rows arrive
- Works with both
toArrayandCollectionmaterialization
- Correlation filter (
- All 112 existing includes tests pass
- Full test suite passes (2071 tests)
- Build passes
🤖 Generated with Claude Code
- 1
Size Change: +507 B (+0.45%)
Total Size: 114 kB
📦 View Changed
Filename Size Change packages/db/dist/esm/query/compiler/index.js4.13 kB +507 B (+13.98%) ⚠️ compressed-size-action::db-package-sizeℹ️ View Unchanged
Filename Size packages/db/dist/esm/collection/change-events.js1.39 kB packages/db/dist/esm/collection/changes.js1.38 kB packages/db/dist/esm/collection/cleanup-queue.js810 B packages/db/dist/esm/collection/events.js434 B packages/db/dist/esm/collection/index.js3.61 kB packages/db/dist/esm/collection/indexes.js1.99 kB packages/db/dist/esm/collection/lifecycle.js1.69 kB packages/db/dist/esm/collection/mutations.js2.47 kB packages/db/dist/esm/collection/state.js5.26 kB packages/db/dist/esm/collection/subscription.js3.74 kB packages/db/dist/esm/collection/sync.js2.88 kB packages/db/dist/esm/collection/transaction-metadata.js144 B packages/db/dist/esm/deferred.js207 B packages/db/dist/esm/errors.js4.92 kB packages/db/dist/esm/event-emitter.js748 B packages/db/dist/esm/index.js3 kB packages/db/dist/esm/indexes/auto-index.js830 B packages/db/dist/esm/indexes/base-index.js729 B packages/db/dist/esm/indexes/basic-index.js2.05 kB packages/db/dist/esm/indexes/btree-index.js2.17 kB packages/db/dist/esm/indexes/index-registry.js820 B packages/db/dist/esm/indexes/reverse-index.js538 B packages/db/dist/esm/local-only.js890 B packages/db/dist/esm/local-storage.js2.1 kB packages/db/dist/esm/optimistic-action.js359 B packages/db/dist/esm/paced-mutations.js496 B packages/db/dist/esm/proxy.js3.75 kB packages/db/dist/esm/query/builder/functions.js919 B packages/db/dist/esm/query/builder/index.js5.25 kB packages/db/dist/esm/query/builder/ref-proxy.js1.2 kB packages/db/dist/esm/query/compiler/evaluators.js1.62 kB packages/db/dist/esm/query/compiler/expressions.js430 B packages/db/dist/esm/query/compiler/group-by.js2.69 kB packages/db/dist/esm/query/compiler/joins.js2.34 kB packages/db/dist/esm/query/compiler/order-by.js1.72 kB packages/db/dist/esm/query/compiler/select.js1.11 kB packages/db/dist/esm/query/effect.js4.78 kB packages/db/dist/esm/query/expression-helpers.js1.43 kB packages/db/dist/esm/query/ir.js829 B packages/db/dist/esm/query/live-query-collection.js360 B packages/db/dist/esm/query/live/collection-config-builder.js7.88 kB packages/db/dist/esm/query/live/collection-registry.js264 B packages/db/dist/esm/query/live/collection-subscriber.js1.95 kB packages/db/dist/esm/query/live/internal.js145 B packages/db/dist/esm/query/live/utils.js1.64 kB packages/db/dist/esm/query/optimizer.js2.62 kB packages/db/dist/esm/query/predicate-utils.js2.97 kB packages/db/dist/esm/query/query-once.js359 B packages/db/dist/esm/query/subset-dedupe.js960 B packages/db/dist/esm/scheduler.js1.3 kB packages/db/dist/esm/SortedMap.js1.3 kB packages/db/dist/esm/strategies/debounceStrategy.js247 B packages/db/dist/esm/strategies/queueStrategy.js428 B packages/db/dist/esm/strategies/throttleStrategy.js246 B packages/db/dist/esm/transactions.js2.9 kB packages/db/dist/esm/utils.js927 B packages/db/dist/esm/utils/array-utils.js273 B packages/db/dist/esm/utils/browser-polyfills.js304 B packages/db/dist/esm/utils/btree.js5.61 kB packages/db/dist/esm/utils/comparison.js1.05 kB packages/db/dist/esm/utils/cursor.js457 B packages/db/dist/esm/utils/index-optimization.js1.54 kB packages/db/dist/esm/utils/type-guards.js157 B packages/db/dist/esm/virtual-props.js360 B Size Change: 0 B
Total Size: 4.24 kB
compressed-size-action::react-db-package-sizeℹ️ View Unchanged
Filename Size packages/react-db/dist/esm/index.js249 B packages/react-db/dist/esm/useLiveInfiniteQuery.js1.32 kB packages/react-db/dist/esm/useLiveQuery.js1.34 kB packages/react-db/dist/esm/useLiveQueryEffect.js355 B packages/react-db/dist/esm/useLiveSuspenseQuery.js567 B packages/react-db/dist/esm/usePacedMutations.js401 B samwillis(GitHub profile, opens in a new tab) approved these changes
LGTM
kevin-dp(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit:
ca9febb