Skip to content
Source
Sign inSign up
TanStack/db

fix(svelte-db): disabled useLiveQuery no longer crashes #1637

Mergedkevin-dp(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/1637/headmerged by kevin-dp(GitHub profile, opens in a new tab)

Follow-up #1 of 3 to the conformance suite (#1636), fixing a knownGap that suite surfaced.

Base: stacked on test/live-query-conformance-suite (#1636) — it depends on the conformance drivers to clear the gap. Re-target to main once #1636 lands.

The bug

A disabled useLiveQuery — the query callback returning null/undefined, which every other adapter treats as "disabled" — crashed in svelte-db:

TypeError: Cannot read properties of undefined (reading '_getQuery')
  ❯ getQueryIR .../query/builder/index.ts
  ❯ createLiveQueryCollection .../query/live-query-collection.ts

Root cause

svelte-db added toValue() unwrapping to support the reactive () => collection input form. But toValue calls any function, so it also calls the query callback. When that callback returns null/undefined (disabled), the unwrapped value became null, which fell through to createLiveQueryCollection({ ...null, startSync: true }) → crash in getQueryIR. The existing disabled short-circuit sat behind a typeof === 'function' check that null never reaches.

It went unnoticed because svelte-db had no disabled-query tests — exactly the gap the conformance suite flagged.

Fix

Treat a null/undefined unwrapped value as a disabled query (return the disabled state), matching React/Vue/Solid/Angular. One guard in the non-function branch.

Verification

Clears the disabled-explicit and disabled-transition knownGaps in the svelte-db conformance driver — both now pass as normal tests. Full svelte-db suite green (54), svelte-check clean. Patch changeset included.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed useLiveQuery so queries that resolve to null or undefined are treated as disabled instead of causing runtime errors.
    • Improved consistency with other adapters by returning a disabled state in these cases.
  • Tests

    • Updated conformance coverage to reflect that disabled-query scenarios now pass.
    1. Review Change Stack

      Caution

      Review failed

      The pull request is closed.

      ℹ️ Recent review info
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Pro

      Run ID: afb065d9-2c90-400d-9c45-e2e8649c180c

      📥 Commits

      Reviewing files that changed from the base of the PR and between 3ec3e7ae1b2fa5ab9fee3ebaebb6d97c9487d29b and 36ef0b04914de60965e77af08c7a5b06af415b57.

      📒 Files selected for processing (3)
      • .changeset/svelte-disabled-query-fix.md
      • packages/svelte-db/src/useLiveQuery.svelte.ts
      • packages/svelte-db/tests/conformance.svelte.test.ts

      📝 Walkthrough

      Walkthrough

      Adds a guard in Svelte's useLiveQuery to return null when the resolved query parameter is null/undefined, treating it as a disabled query instead of passing it to createLiveQueryCollection. Updates conformance test knownGaps to remove now-passing disabled-query cases, and adds a changeset.

      Changes

      Disabled Query Handling Fix

      Layer / File(s)Summary
      Guard against null/undefined query params
      packages/svelte-db/src/useLiveQuery.svelte.ts
      Returns null early in the reactive collection computation when the unwrapped parameter is undefined/null, avoiding passing invalid values to createLiveQueryCollection.
      Conformance test update and changeset
      packages/svelte-db/tests/conformance.svelte.test.ts, .changeset/svelte-disabled-query-fix.md
      Removes disabled-explicit/disabled-transition from knownGaps in the Svelte driver test config and adds a changeset documenting the patch fix.

      Estimated code review effort: 1 (Trivial) | ~5 minutes

      Possibly related PRs

      • TanStack/db#1641: Both PRs modify the Svelte useLiveQuery.svelte.ts hook's argument handling logic.

      Suggested reviewers: samwillis

      ✨ Finishing Touches
      📝 Generate docstrings
      • Create stacked PR
      • Commit on current branch
      🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Commit unit tests in branch `fix/svelte-disabled-query`

      Warning

      Tools execution failed with the following error:

      Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands.
    2. More templates

      @tanstack/angular-db

      npm i https://pkg.pr.new/@tanstack/angular-db@1637

      @tanstack/browser-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/browser-db-sqlite-persistence@1637

      @tanstack/capacitor-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/capacitor-db-sqlite-persistence@1637

      @tanstack/cloudflare-durable-objects-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/cloudflare-durable-objects-db-sqlite-persistence@1637

      @tanstack/db

      npm i https://pkg.pr.new/@tanstack/db@1637

      @tanstack/db-ivm

      npm i https://pkg.pr.new/@tanstack/db-ivm@1637

      @tanstack/db-sqlite-persistence-core

      npm i https://pkg.pr.new/@tanstack/db-sqlite-persistence-core@1637

      @tanstack/electric-db-collection

      npm i https://pkg.pr.new/@tanstack/electric-db-collection@1637

      @tanstack/electron-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/electron-db-sqlite-persistence@1637

      @tanstack/expo-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/expo-db-sqlite-persistence@1637

      @tanstack/node-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/node-db-sqlite-persistence@1637

      @tanstack/offline-transactions

      npm i https://pkg.pr.new/@tanstack/offline-transactions@1637

      @tanstack/powersync-db-collection

      npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1637

      @tanstack/query-db-collection

      npm i https://pkg.pr.new/@tanstack/query-db-collection@1637

      @tanstack/react-db

      npm i https://pkg.pr.new/@tanstack/react-db@1637

      @tanstack/react-native-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/react-native-db-sqlite-persistence@1637

      @tanstack/rxdb-db-collection

      npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1637

      @tanstack/solid-db

      npm i https://pkg.pr.new/@tanstack/solid-db@1637

      @tanstack/svelte-db

      npm i https://pkg.pr.new/@tanstack/svelte-db@1637

      @tanstack/tauri-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/tauri-db-sqlite-persistence@1637

      @tanstack/trailbase-db-collection

      npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1637

      @tanstack/vue-db

      npm i https://pkg.pr.new/@tanstack/vue-db@1637

      commit: 36ef0b0

    3. Size Change: 0 B

      Total Size: 125 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/db/dist/esm/collection/change-events.js1.43 kB
      packages/db/dist/esm/collection/changes.js1.38 kB
      packages/db/dist/esm/collection/cleanup-queue.js810 B
      packages/db/dist/esm/collection/events.js434 B
      packages/db/dist/esm/collection/index.js3.62 kB
      packages/db/dist/esm/collection/indexes.js1.99 kB
      packages/db/dist/esm/collection/lifecycle.js1.69 kB
      packages/db/dist/esm/collection/mutations.js2.47 kB
      packages/db/dist/esm/collection/state.js5.4 kB
      packages/db/dist/esm/collection/subscription.js3.74 kB
      packages/db/dist/esm/collection/sync.js2.88 kB
      packages/db/dist/esm/collection/transaction-metadata.js144 B
      packages/db/dist/esm/deferred.js207 B
      packages/db/dist/esm/errors.js5.1 kB
      packages/db/dist/esm/event-emitter.js748 B
      packages/db/dist/esm/index.js3.1 kB
      packages/db/dist/esm/indexes/auto-index.js829 B
      packages/db/dist/esm/indexes/base-index.js767 B
      packages/db/dist/esm/indexes/basic-index.js2.06 kB
      packages/db/dist/esm/indexes/btree-index.js2.19 kB
      packages/db/dist/esm/indexes/index-registry.js820 B
      packages/db/dist/esm/indexes/reverse-index.js557 B
      packages/db/dist/esm/local-only.js916 B
      packages/db/dist/esm/local-storage.js2.12 kB
      packages/db/dist/esm/optimistic-action.js359 B
      packages/db/dist/esm/paced-mutations.js496 B
      packages/db/dist/esm/proxy.js3.75 kB
      packages/db/dist/esm/query/builder/functions.js1.47 kB
      packages/db/dist/esm/query/builder/index.js5.84 kB
      packages/db/dist/esm/query/builder/ref-proxy.js1.24 kB
      packages/db/dist/esm/query/compiler/evaluators.js1.89 kB
      packages/db/dist/esm/query/compiler/expressions.js430 B
      packages/db/dist/esm/query/compiler/group-by.js3.56 kB
      packages/db/dist/esm/query/compiler/index.js6.67 kB
      packages/db/dist/esm/query/compiler/joins.js2.5 kB
      packages/db/dist/esm/query/compiler/lazy-targets.js923 B
      packages/db/dist/esm/query/compiler/order-by.js1.74 kB
      packages/db/dist/esm/query/compiler/select.js1.53 kB
      packages/db/dist/esm/query/effect.js4.77 kB
      packages/db/dist/esm/query/expression-helpers.js1.43 kB
      packages/db/dist/esm/query/ir.js1.25 kB
      packages/db/dist/esm/query/live-query-collection.js360 B
      packages/db/dist/esm/query/live/collection-config-builder.js9.1 kB
      packages/db/dist/esm/query/live/collection-registry.js264 B
      packages/db/dist/esm/query/live/collection-subscriber.js1.93 kB
      packages/db/dist/esm/query/live/internal.js145 B
      packages/db/dist/esm/query/live/utils.js1.81 kB
      packages/db/dist/esm/query/optimizer.js2.92 kB
      packages/db/dist/esm/query/predicate-utils.js2.97 kB
      packages/db/dist/esm/query/query-once.js359 B
      packages/db/dist/esm/query/subset-dedupe.js960 B
      packages/db/dist/esm/scheduler.js1.3 kB
      packages/db/dist/esm/SortedMap.js1.3 kB
      packages/db/dist/esm/strategies/debounceStrategy.js247 B
      packages/db/dist/esm/strategies/queueStrategy.js428 B
      packages/db/dist/esm/strategies/throttleStrategy.js246 B
      packages/db/dist/esm/transactions.js3.04 kB
      packages/db/dist/esm/utils.js927 B
      packages/db/dist/esm/utils/array-utils.js273 B
      packages/db/dist/esm/utils/browser-polyfills.js304 B
      packages/db/dist/esm/utils/btree.js5.61 kB
      packages/db/dist/esm/utils/comparison.js1.11 kB
      packages/db/dist/esm/utils/cursor.js457 B
      packages/db/dist/esm/utils/index-optimization.js2.39 kB
      packages/db/dist/esm/utils/type-guards.js157 B
      packages/db/dist/esm/utils/uuid.js449 B
      packages/db/dist/esm/virtual-props.js360 B
      compressed-size-action::db-package-size
    4. Size Change: 0 B

      Total Size: 4.26 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/react-db/dist/esm/index.js249 B
      packages/react-db/dist/esm/useLiveInfiniteQuery.js1.32 kB
      packages/react-db/dist/esm/useLiveQuery.js1.37 kB
      packages/react-db/dist/esm/useLiveQueryEffect.js355 B
      packages/react-db/dist/esm/useLiveSuspenseQuery.js567 B
      packages/react-db/dist/esm/usePacedMutations.js401 B
      compressed-size-action::react-db-package-size
    5. KyleAMathews(GitHub profile, opens in a new tab) approved these changes

Sign in to join this conversation.