Skip to content
Source
Sign inSign up
TanStack/db

test(browser-sqlite): cover two-tab remote subset transport #1905

MergedKyleAMathews(GitHub profile, opens in a new tab)merged 4 commits intomain fromrefs/pull/1905/headmerged by KyleAMathews(GitHub profile, opens in a new tab)

Why

Issue #1498 reports a clone error and repeated warnings after a second browser tab starts a filtered on-demand query. Current main has a clone-safe remote-subset route, but no real two-tab OPFS test for that route. This PR adds the missing browser witness. It does not change production code or close the issue.

What the test does

The first Chromium tab starts a persisted, QueryClient-backed on-demand source Collection. The second tab opens the same OPFS database and requests one ID through a filtered live-query Collection. The test checks that the second tab remains a follower, posts a remote-subset request, makes no upstream Query call, and receives the expected public row.

The request contains a predicate, an abort signal, and a live subscription callback before transport. The test checks that the browser post succeeds. It also checks that an unsupported nested function fails with its exact wire path before another post. A short warning window covers the retry flood reported in #1498.

The existing CI step runs this test with the OPFS browser suite through pnpm test:opfs-fairness. The oracle review record names the reviewed commit and each applicable guide requirement.

Checks and limits

  • The full local Chromium OPFS suite passed: 3 tests.
  • A temporary raw-options mutant failed in the second tab with four DataCloneError posts. The test passed again after removal of the mutant.
  • TypeScript, ESLint, Prettier, and the diff check passed.

This test does not run React, Firefox/Zen, or a live backend. It does not check OPFS ownership during leadership transfer. The reporter can test the original Zen setup against a released build before #1498 closes.

Refs #1498.

Summary by CodeRabbit

  • Tests
    • Added browser coverage for filtered query synchronization between two tabs sharing an OPFS database, including invalid request rejection and cleanup behavior.
  • Documentation
    • Added a review record describing the test’s results, observations, and coverage limits.
    1. Review in Change Stack →

      Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

      Important

      Review skipped

      Review was skipped as selected files did not have any reviewable changes.

      ⛔ Files ignored due to path filters (1)
      • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Advanced

      Run ID: d9f92ccf-489b-4e86-b176-55f109b323c6

      📥 Commits

      Reviewing files that changed from the base of the PR and between 9aa536e3fa4b1c2fb1d51856427b4b38fba591d0 and c6ee677fa688edf79d6f774129aa91f03917289e.

      ⛔ Files ignored due to path filters (1)
      • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

      You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

      Use the checkbox below for a quick retry:

      • 🔍 Trigger review

      No actionable comments were generated in the recent review. 🎉

      ℹ️ Recent review info
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Advanced

      Run ID: 991adc45-1d06-4762-b621-686e54e0cd1e

      📥 Commits

      Reviewing files that changed from the base of the PR and between d3c38c8f4e83cef4545e8011dc3419be1fcf527a and 9aa536e3fa4b1c2fb1d51856427b4b38fba591d0.

      ⛔ Files ignored due to path filters (1)
      • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
      📒 Files selected for processing (9)
      • docs/contributing/oracle-coverage.md
      • docs/contributing/oracle-reviews/2026-09-27-remote-subset-two-tab.md
      • packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.html
      • packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.spec.ts
      • packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.ts
      • packages/browser-db-sqlite-persistence/package.json
      • packages/browser-db-sqlite-persistence/playwright.opfs.config.ts
      • packages/browser-db-sqlite-persistence/tsconfig.json
      • packages/browser-db-sqlite-persistence/vite.opfs.config.ts

      Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


      📝 Walkthrough

      Walkthrough

      This change adds a two-tab OPFS browser oracle for remote-subset requests. The probe records query and post observations, and the Playwright test checks leader and follower results, invalid wire-value rejection, warnings, and cleanup.

      Changes

      Two-tab remote-subset oracle

      Layer / File(s)Summary
      Probe setup and remote-subset observations
      packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.ts
      The probe initializes the OPFS coordinator and query collection. It records leadership, rows, upstream loads, ensure requests, and remote-subset post results. It also exposes an invalid-wire probe and cleanup operation.
      Two-tab test and oracle record
      packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.html, packages/browser-db-sqlite-persistence/e2e/remote-subset-two-tab.opfs.spec.ts, packages/browser-db-sqlite-persistence/package.json, packages/browser-db-sqlite-persistence/playwright.opfs.config.ts, packages/browser-db-sqlite-persistence/tsconfig.json, packages/browser-db-sqlite-persistence/vite.opfs.config.ts, docs/contributing/oracle-reviews/2026-09-27-remote-subset-two-tab.md, docs/contributing/oracle-coverage.md
      The Playwright test opens two tabs and checks filtered rows, remote-subset posts, invalid wire-value rejection, warnings, and cleanup. Package and test configuration enable the probe. The review record and coverage documentation describe the oracle’s observations and limits.

      Priority: ⬇️ Low

      Estimated code review effort: 3 (Moderate) | ~20 minutes

      Change: Other

      Merge Risk: ⚪ Minimal · up to 9aa53

      The new two-tab test checks that the follower receives the expected row after a successful remote-subset request. No issue requiring a change before merge was established.

      🚥 Pre-merge checks | ✅ 4 | ❌ 1

      ❌ Failed checks (1 warning)

      Check nameStatusExplanationResolution
      Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (5 skipped: 5 …Write docstrings for the functions missing them to satisfy the coverage threshold.
      ✅ Passed checks (4 passed)
      Check nameStatusExplanation
      Title check✅ PassedThe title clearly and concisely describes the main change: testing two-tab remote-subset transport in the browser SQLite package.
      Description check✅ PassedThe description provides the motivation, test behavior, validation results, scope limits, CI entry point, and issue reference. It does not use the exact template headings or checkbox format, but it is…
      Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
      Full details: Docstring Coverage

      Explanation

      Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. (5 skipped: 5 unsupported.)

      ✨ Finishing Touches 💡 1
      📝 Generate docstrings 💡
      • Commit to this branch
      • Create a new PR
      🧪 Generate unit tests (beta)
      • Commit to this branch
      • Create a new PR

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands.
    2. More templates

      @tanstack/angular-db

      npm i https://pkg.pr.new/@tanstack/angular-db@1905

      @tanstack/browser-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/browser-db-sqlite-persistence@1905

      @tanstack/capacitor-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/capacitor-db-sqlite-persistence@1905

      @tanstack/cloudflare-durable-objects-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/cloudflare-durable-objects-db-sqlite-persistence@1905

      @tanstack/db

      npm i https://pkg.pr.new/@tanstack/db@1905

      @tanstack/db-ivm

      npm i https://pkg.pr.new/@tanstack/db-ivm@1905

      @tanstack/db-sqlite-persistence-core

      npm i https://pkg.pr.new/@tanstack/db-sqlite-persistence-core@1905

      @tanstack/electric-db-collection

      npm i https://pkg.pr.new/@tanstack/electric-db-collection@1905

      @tanstack/electron-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/electron-db-sqlite-persistence@1905

      @tanstack/expo-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/expo-db-sqlite-persistence@1905

      @tanstack/node-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/node-db-sqlite-persistence@1905

      @tanstack/offline-transactions

      npm i https://pkg.pr.new/@tanstack/offline-transactions@1905

      @tanstack/powersync-db-collection

      npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1905

      @tanstack/query-db-collection

      npm i https://pkg.pr.new/@tanstack/query-db-collection@1905

      @tanstack/react-db

      npm i https://pkg.pr.new/@tanstack/react-db@1905

      @tanstack/react-native-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/react-native-db-sqlite-persistence@1905

      @tanstack/react-router-with-db

      npm i https://pkg.pr.new/@tanstack/react-router-with-db@1905

      @tanstack/rxdb-db-collection

      npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1905

      @tanstack/solid-db

      npm i https://pkg.pr.new/@tanstack/solid-db@1905

      @tanstack/svelte-db

      npm i https://pkg.pr.new/@tanstack/svelte-db@1905

      @tanstack/tauri-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/tauri-db-sqlite-persistence@1905

      @tanstack/trailbase-db-collection

      npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1905

      @tanstack/vue-db

      npm i https://pkg.pr.new/@tanstack/vue-db@1905

      commit: c6ee677

    3. Size Change: 0 B

      Total Size: 172 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/db/dist/esm/client.js3.66 kB
      packages/db/dist/esm/collection-options.js236 B
      packages/db/dist/esm/collection/change-events.js1.44 kB
      packages/db/dist/esm/collection/changes.js2.4 kB
      packages/db/dist/esm/collection/cleanup-queue.js794 B
      packages/db/dist/esm/collection/events.js481 B
      packages/db/dist/esm/collection/index.js4.46 kB
      packages/db/dist/esm/collection/indexes.js1.99 kB
      packages/db/dist/esm/collection/lifecycle.js2.69 kB
      packages/db/dist/esm/collection/mutations.js2.61 kB
      packages/db/dist/esm/collection/state.js6.94 kB
      packages/db/dist/esm/collection/subscription.js8.81 kB
      packages/db/dist/esm/collection/sync.js5.03 kB
      packages/db/dist/esm/collection/transaction-metadata.js144 B
      packages/db/dist/esm/deferred.js207 B
      packages/db/dist/esm/errors.js5.34 kB
      packages/db/dist/esm/event-emitter.js964 B
      packages/db/dist/esm/index.js3.82 kB
      packages/db/dist/esm/indexes/auto-index.js829 B
      packages/db/dist/esm/indexes/base-index.js1.18 kB
      packages/db/dist/esm/indexes/basic-index.js2.07 kB
      packages/db/dist/esm/indexes/btree-index.js2.26 kB
      packages/db/dist/esm/indexes/index-registry.js820 B
      packages/db/dist/esm/indexes/reverse-index.js376 B
      packages/db/dist/esm/live-query-adapter.js318 B
      packages/db/dist/esm/live-query-observer.js3.69 kB
      packages/db/dist/esm/live-query-options.js731 B
      packages/db/dist/esm/live-query-window-controller.js4.36 kB
      packages/db/dist/esm/local-only.js989 B
      packages/db/dist/esm/local-storage.js2.17 kB
      packages/db/dist/esm/optimistic-action.js359 B
      packages/db/dist/esm/paced-mutations.js496 B
      packages/db/dist/esm/proxy.js3.32 kB
      packages/db/dist/esm/query/builder/clone-query.js748 B
      packages/db/dist/esm/query/builder/functions.js1.47 kB
      packages/db/dist/esm/query/builder/index.js6.76 kB
      packages/db/dist/esm/query/builder/query-ir.js116 B
      packages/db/dist/esm/query/builder/ref-proxy.js1.28 kB
      packages/db/dist/esm/query/compiler/evaluators.js2.04 kB
      packages/db/dist/esm/query/compiler/expressions.js603 B
      packages/db/dist/esm/query/compiler/group-by.js4.14 kB
      packages/db/dist/esm/query/compiler/index.js9.11 kB
      packages/db/dist/esm/query/compiler/joins.js2.99 kB
      packages/db/dist/esm/query/compiler/lazy-targets.js1.12 kB
      packages/db/dist/esm/query/compiler/order-by.js1.93 kB
      packages/db/dist/esm/query/compiler/parent-routes.js319 B
      packages/db/dist/esm/query/compiler/query-equivalence.js455 B
      packages/db/dist/esm/query/compiler/route-metadata.js1.24 kB
      packages/db/dist/esm/query/compiler/select.js1.59 kB
      packages/db/dist/esm/query/effect.js5.22 kB
      packages/db/dist/esm/query/equality-value-identity.js591 B
      packages/db/dist/esm/query/expression-helpers.js1.45 kB
      packages/db/dist/esm/query/ir-stable-identity.js4.21 kB
      packages/db/dist/esm/query/ir.js1.74 kB
      packages/db/dist/esm/query/live-query-collection.js391 B
      packages/db/dist/esm/query/live/bucket-facade-adapter.js2.73 kB
      packages/db/dist/esm/query/live/collection-config-builder.js7.11 kB
      packages/db/dist/esm/query/live/collection-registry.js264 B
      packages/db/dist/esm/query/live/collection-subscriber.js2.31 kB
      packages/db/dist/esm/query/live/internal.js145 B
      packages/db/dist/esm/query/live/materialized-pipeline.js2.32 kB
      packages/db/dist/esm/query/live/ordered-source-loader.js4.32 kB
      packages/db/dist/esm/query/live/subset-demand-controller.js1.57 kB
      packages/db/dist/esm/query/live/utils.js1.19 kB
      packages/db/dist/esm/query/optimizer.js3.11 kB
      packages/db/dist/esm/query/query-once.js359 B
      packages/db/dist/esm/query/runtime-reference-identity.js630 B
      packages/db/dist/esm/query/subset-dedupe.js497 B
      packages/db/dist/esm/scheduler.js1.34 kB
      packages/db/dist/esm/SortedMap.js1.3 kB
      packages/db/dist/esm/strategies/debounceStrategy.js247 B
      packages/db/dist/esm/strategies/queueStrategy.js428 B
      packages/db/dist/esm/strategies/throttleStrategy.js246 B
      packages/db/dist/esm/sync-persistence.js530 B
      packages/db/dist/esm/transactions.js3.71 kB
      packages/db/dist/esm/utils.js1.21 kB
      packages/db/dist/esm/utils/array-utils.js270 B
      packages/db/dist/esm/utils/browser-polyfills.js304 B
      packages/db/dist/esm/utils/btree.js4.51 kB
      packages/db/dist/esm/utils/callbacks.js174 B
      packages/db/dist/esm/utils/comparison.js1.5 kB
      packages/db/dist/esm/utils/cursor.js677 B
      packages/db/dist/esm/utils/error.js167 B
      packages/db/dist/esm/utils/get-or-create.js155 B
      packages/db/dist/esm/utils/index-optimization.js2.42 kB
      packages/db/dist/esm/utils/type-guards.js230 B
      packages/db/dist/esm/utils/uuid.js449 B
      packages/db/dist/esm/virtual-props.js360 B
      compressed-size-action::db-package-size
    4. Size Change: 0 B

      Total Size: 7.97 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/react-db/dist/esm/DbProvider.js317 B
      packages/react-db/dist/esm/HydrationBoundary.js263 B
      packages/react-db/dist/esm/index.js330 B
      packages/react-db/dist/esm/live-query-internals.js282 B
      packages/react-db/dist/esm/useLiveInfiniteQuery.js1.9 kB
      packages/react-db/dist/esm/useLiveQuery.js3.3 kB
      packages/react-db/dist/esm/useLiveQueryEffect.js355 B
      packages/react-db/dist/esm/useLiveSuspenseQuery.js820 B
      packages/react-db/dist/esm/usePacedMutations.js401 B
      compressed-size-action::react-db-package-size

Sign in to join this conversation.