Skip to content
Source
Sign inSign up
TanStack/db

ci: skip the Electric E2E suites while the Electric image cannot be pulled #1985

MergedKyleAMathews(GitHub profile, opens in a new tab)merged 2 commits intomain fromrefs/pull/1985/headmerged by KyleAMathews(GitHub profile, opens in a new tab)

The E2E workflow fails on main and on every pull request, before any test runs. This PR skips only the steps that need the Electric image, so the other E2E suites run again.

The Start Docker services step pulls electricsql/electric:canary, and the pull fails:

pull access denied for electricsql/electric, repository does not exist or may require 'docker login'

Docker Hub started to reject anonymous pulls of this repository at about 21:40 UTC on 2026-10-01. The last successful E2E run on main was at 21:28 UTC. A direct registry check gives these results:

RequestResult
Manifest for electricsql/electric:canary or :latest, anonymous token401 UNAUTHORIZED, "authentication required"
Repository page electricsql/electric404
Manifest for library/alpine:latest (control)200

The tag metadata still exists, with a last pull at 21:35 UTC. The repository was probably made private or removed. This is not a rate limit, because other public images pull normally.

Change

.github/workflows/e2e-tests.yml sets ELECTRIC_E2E: 'false' on the job. Four steps run only when it is 'true':

  • Start Docker services (Postgres and Electric)
  • Run Electric E2E tests
  • Run Browser SQLite OPFS with live Electric E2E tests
  • Stop Docker services

These E2E suites do not use Electric or Postgres, so they still run:

  • Query
  • Browser SQLite OPFS fairness
  • React Start SSR and Next.js SSR
  • Node, Electron, Cloudflare Durable Object, and React Native SQLite persistence

To restore the Electric suites, set the flag to 'true'. Do this when the image can be pulled again, or after CI gets Docker Hub credentials or another image source.

This pull request and its description were written by Isaac.

Summary by CodeRabbit

  • Chores
    • Automated end-to-end test runs and related cleanup are now gated by a configuration setting. Other end-to-end workflow steps continue to run as before. This change affects the project’s testing workflow and does not change application features or behavior.
    1. Review in Change Stack →

      Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

      No actionable comments were generated in the recent review. 🎉

      ℹ️ Recent review info
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Advanced

      Run ID: 325ed352-e86c-4e5a-adce-87983ac2b18f

      📥 Commits

      Reviewing files that changed from the base of the PR and between a96bbb538afe3e49585c1dcf6b3cea6d75917da4 and e3c4d799cb74294d18bbdff7e0a720b48be98a1c.

      📒 Files selected for processing (1)
      • .github/workflows/e2e-tests.yml

      Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


      📝 Walkthrough

      Walkthrough

      The workflow sets ELECTRIC_E2E to false by default. When it is true, the workflow starts Docker services, runs Electric E2E and live-Electric OPFS tests, and performs Docker cleanup.

      Changes

      Electric E2E Workflow

      Layer / File(s)Summary
      Gate Electric E2E steps and cleanup
      .github/workflows/e2e-tests.yml
      The workflow sets ELECTRIC_E2E to false. Docker service startup, Electric E2E tests, live-Electric OPFS tests, and Docker cleanup run only when the setting is true. Cleanup also requires always().

      Priority: ⬇️ Low

      Estimated code review effort: 1 (Trivial) | ~5 minutes

      Change: Other

      Merge Risk: ⚪ Minimal · up to e3c4d

      Electric-dependent E2E runs are intentionally disabled while the image cannot be pulled; the other E2E suites remain eligible, so no actionable merge-blocking risk remains.

      Architecture Summary

      Architecture risk: 🔵 Low · up to e3c4d

      The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

      Changed systems: None identified.

      Architecture concerns No architecture-level concerns identified.

      Review details

      Before / after behavior

      • observed — Modified behavior in .github/workflows/e2e-tests.yml: Adds the job-level ELECTRIC_E2E: 'false' setting and comments describing the current image-pull issue and the instruction to set it back to 'true'.
      • observed — Modified behavior in .github/workflows/e2e-tests.yml: Docker service startup now runs only when ELECTRIC_E2E equals 'true'.
      • observed — Modified behavior in .github/workflows/e2e-tests.yml: The Electric E2E test step now runs only when ELECTRIC_E2E equals 'true'.
      • observed — Modified behavior in .github/workflows/e2e-tests.yml: The live-Electric Browser SQLite OPFS test step now runs only when ELECTRIC_E2E equals 'true'.
      🚥 Pre-merge checks | ✅ 5
      ✅ Passed checks (5 passed)
      Check nameStatusExplanation
      Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
      Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
      Title check✅ PassedThe title clearly and concisely describes the main CI change: skipping Electric E2E suites while the Electric image cannot be pulled.
      Description check✅ PassedThe description clearly explains the failure, motivation, exact workflow changes, unaffected suites, and restoration condition. It omits the template headings and checklist items, but the required cha…
      ✨ Finishing Touches
      🧪 Generate unit tests (beta)
      • Commit to this branch
      • Create a new PR
      • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Autopilot is currently an internal CodeRabbit preview.


      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands.
    2. More templates

      @tanstack/angular-db

      npm i https://pkg.pr.new/@tanstack/angular-db@1985

      @tanstack/browser-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/browser-db-sqlite-persistence@1985

      @tanstack/capacitor-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/capacitor-db-sqlite-persistence@1985

      @tanstack/cloudflare-durable-objects-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/cloudflare-durable-objects-db-sqlite-persistence@1985

      @tanstack/db

      npm i https://pkg.pr.new/@tanstack/db@1985

      @tanstack/db-ivm

      npm i https://pkg.pr.new/@tanstack/db-ivm@1985

      @tanstack/db-sqlite-persistence-core

      npm i https://pkg.pr.new/@tanstack/db-sqlite-persistence-core@1985

      @tanstack/electric-db-collection

      npm i https://pkg.pr.new/@tanstack/electric-db-collection@1985

      @tanstack/electron-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/electron-db-sqlite-persistence@1985

      @tanstack/expo-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/expo-db-sqlite-persistence@1985

      @tanstack/node-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/node-db-sqlite-persistence@1985

      @tanstack/offline-transactions

      npm i https://pkg.pr.new/@tanstack/offline-transactions@1985

      @tanstack/powersync-db-collection

      npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1985

      @tanstack/query-db-collection

      npm i https://pkg.pr.new/@tanstack/query-db-collection@1985

      @tanstack/react-db

      npm i https://pkg.pr.new/@tanstack/react-db@1985

      @tanstack/react-native-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/react-native-db-sqlite-persistence@1985

      @tanstack/react-router-with-db

      npm i https://pkg.pr.new/@tanstack/react-router-with-db@1985

      @tanstack/rxdb-db-collection

      npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1985

      @tanstack/solid-db

      npm i https://pkg.pr.new/@tanstack/solid-db@1985

      @tanstack/svelte-db

      npm i https://pkg.pr.new/@tanstack/svelte-db@1985

      @tanstack/tauri-db-sqlite-persistence

      npm i https://pkg.pr.new/@tanstack/tauri-db-sqlite-persistence@1985

      @tanstack/trailbase-db-collection

      npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1985

      @tanstack/vue-db

      npm i https://pkg.pr.new/@tanstack/vue-db@1985

      commit: e3c4d79

    3. Size Change: 0 B

      Total Size: 175 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/db/dist/esm/client.js3.61 kB
      packages/db/dist/esm/collection-options.js236 B
      packages/db/dist/esm/collection/change-events.js2.07 kB
      packages/db/dist/esm/collection/changes.js2.72 kB
      packages/db/dist/esm/collection/cleanup-queue.js808 B
      packages/db/dist/esm/collection/events.js481 B
      packages/db/dist/esm/collection/index.js4.57 kB
      packages/db/dist/esm/collection/indexes.js2.06 kB
      packages/db/dist/esm/collection/lifecycle.js2.63 kB
      packages/db/dist/esm/collection/mutations.js2.59 kB
      packages/db/dist/esm/collection/state.js8.32 kB
      packages/db/dist/esm/collection/subscription.js8.63 kB
      packages/db/dist/esm/collection/sync.js4.96 kB
      packages/db/dist/esm/collection/transaction-metadata.js144 B
      packages/db/dist/esm/deferred.js207 B
      packages/db/dist/esm/errors.js5.49 kB
      packages/db/dist/esm/event-emitter.js961 B
      packages/db/dist/esm/index.js3.94 kB
      packages/db/dist/esm/indexes/auto-index.js841 B
      packages/db/dist/esm/indexes/base-index.js1.25 kB
      packages/db/dist/esm/indexes/basic-index.js2.01 kB
      packages/db/dist/esm/indexes/btree-index.js2.3 kB
      packages/db/dist/esm/indexes/index-registry.js820 B
      packages/db/dist/esm/indexes/reverse-index.js370 B
      packages/db/dist/esm/live-query-adapter.js318 B
      packages/db/dist/esm/live-query-observer.js4.53 kB
      packages/db/dist/esm/live-query-options.js731 B
      packages/db/dist/esm/live-query-window-controller.js4.12 kB
      packages/db/dist/esm/local-only.js989 B
      packages/db/dist/esm/local-storage.js2.17 kB
      packages/db/dist/esm/optimistic-action.js359 B
      packages/db/dist/esm/paced-mutations.js702 B
      packages/db/dist/esm/persisted-readiness.js195 B
      packages/db/dist/esm/proxy.js3.32 kB
      packages/db/dist/esm/query/builder/clone-query.js766 B
      packages/db/dist/esm/query/builder/functions.js1.45 kB
      packages/db/dist/esm/query/builder/index.js6.79 kB
      packages/db/dist/esm/query/builder/query-ir.js116 B
      packages/db/dist/esm/query/builder/ref-proxy-identity.js198 B
      packages/db/dist/esm/query/builder/ref-proxy.js1.35 kB
      packages/db/dist/esm/query/builder/wrapper-identity.js221 B
      packages/db/dist/esm/query/compiler/evaluators.js2.1 kB
      packages/db/dist/esm/query/compiler/expressions.js603 B
      packages/db/dist/esm/query/compiler/group-by.js4.2 kB
      packages/db/dist/esm/query/compiler/index.js9.39 kB
      packages/db/dist/esm/query/compiler/joins.js3.06 kB
      packages/db/dist/esm/query/compiler/lazy-targets.js1.14 kB
      packages/db/dist/esm/query/compiler/order-by.js2 kB
      packages/db/dist/esm/query/compiler/parent-routes.js319 B
      packages/db/dist/esm/query/compiler/query-equivalence.js455 B
      packages/db/dist/esm/query/compiler/route-metadata.js1.24 kB
      packages/db/dist/esm/query/compiler/select.js1.59 kB
      packages/db/dist/esm/query/effect.js4.86 kB
      packages/db/dist/esm/query/equality-value-identity.js591 B
      packages/db/dist/esm/query/expression-helpers.js1.45 kB
      packages/db/dist/esm/query/ir-stable-identity.js4.22 kB
      packages/db/dist/esm/query/ir.js1.69 kB
      packages/db/dist/esm/query/live-query-collection.js391 B
      packages/db/dist/esm/query/live/bucket-facade-adapter.js2.67 kB
      packages/db/dist/esm/query/live/collection-config-builder.js6.47 kB
      packages/db/dist/esm/query/live/collection-registry.js264 B
      packages/db/dist/esm/query/live/collection-subscriber.js2.05 kB
      packages/db/dist/esm/query/live/graph-scheduler.js303 B
      packages/db/dist/esm/query/live/internal.js145 B
      packages/db/dist/esm/query/live/materialized-pipeline.js2.32 kB
      packages/db/dist/esm/query/live/ordered-source-loader.js4.14 kB
      packages/db/dist/esm/query/live/subset-demand-controller.js1.65 kB
      packages/db/dist/esm/query/live/utils.js1.2 kB
      packages/db/dist/esm/query/optimizer.js2.92 kB
      packages/db/dist/esm/query/query-once.js359 B
      packages/db/dist/esm/query/runtime-reference-identity.js630 B
      packages/db/dist/esm/query/subset-dedupe.js493 B
      packages/db/dist/esm/scheduler.js1.13 kB
      packages/db/dist/esm/SortedMap.js1.58 kB
      packages/db/dist/esm/strategies/debounceStrategy.js331 B
      packages/db/dist/esm/strategies/queueStrategy.js488 B
      packages/db/dist/esm/strategies/throttleStrategy.js386 B
      packages/db/dist/esm/sync-persistence.js530 B
      packages/db/dist/esm/transactions.js3.89 kB
      packages/db/dist/esm/utils.js1.22 kB
      packages/db/dist/esm/utils/array-utils.js270 B
      packages/db/dist/esm/utils/browser-polyfills.js304 B
      packages/db/dist/esm/utils/btree.js3.02 kB
      packages/db/dist/esm/utils/callbacks.js174 B
      packages/db/dist/esm/utils/comparison.js1.59 kB
      packages/db/dist/esm/utils/cursor.js677 B
      packages/db/dist/esm/utils/error.js167 B
      packages/db/dist/esm/utils/get-or-create.js155 B
      packages/db/dist/esm/utils/index-optimization.js2.42 kB
      packages/db/dist/esm/utils/source-record.js140 B
      packages/db/dist/esm/utils/type-guards.js230 B
      packages/db/dist/esm/utils/uuid.js449 B
      packages/db/dist/esm/virtual-props.js413 B
      compressed-size-action::db-package-size
    4. Size Change: 0 B

      Total Size: 8.51 kB

      ℹ️ View Unchanged
      FilenameSize
      packages/react-db/dist/esm/DbProvider.js317 B
      packages/react-db/dist/esm/HydrationBoundary.js263 B
      packages/react-db/dist/esm/index.js330 B
      packages/react-db/dist/esm/live-query-internals.js282 B
      packages/react-db/dist/esm/useLiveInfiniteQuery.js1.93 kB
      packages/react-db/dist/esm/useLiveQuery.js3.3 kB
      packages/react-db/dist/esm/useLiveQueryEffect.js355 B
      packages/react-db/dist/esm/useLiveSuspenseQuery.js1.33 kB
      packages/react-db/dist/esm/usePacedMutations.js401 B
      compressed-size-action::react-db-package-size

Sign in to join this conversation.