Skip to content
Source
Sign inSign up
TanStack/db

Request: SQLite compiler falls back to full-table reads for zero/one-argument AND and OR #1994

Send to my agent
ClosedTimFL(GitHub profile, opens in a new tab) opened this issue 0 comments

Problem

The SQLite persistence compiler marks and and or expressions with fewer than two arguments as unsupported.

loadSubsetInternal then omits the SQL WHERE clause, reads and deserializes the entire collection, and filters the rows in JavaScript.

Results can still be correct, but a selective query—or a query that should return no rows—does unnecessary work over the whole cached table.

Versions

  • @tanstack/db-sqlite-persistence-core: 0.4.0
  • @tanstack/browser-db-sqlite-persistence: 0.2.25
  • @tanstack/db: 0.11.0

The same compiler checks are present in upstream main inspected on October 2, 2026.

Reproduction

Populate a persisted collection with many rows and instrument the SQL passed to its driver:

import { IR } from '@tanstack/db'

const predicate = new IR.Func('eq', [
  new IR.PropRef(['id']),
  new IR.Value('row-1'),
])

await adapter.loadSubset(collectionId, {
  where: new IR.Func('and', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', []),
})

Source inspection shows that each expression is rejected by the SQL compiler. The resulting collection read has no WHERE clause.

The empty or case is particularly wasteful: the final result is empty, but the adapter first reads every persisted row.

Expected behavior

Compile these expressions consistently with the core evaluator:

  • One-argument and or or: compile the contained predicate.
  • Empty and: compile a true predicate.
  • Empty or: compile a false predicate.

Unsupported child expressions should retain the existing fallback behavior.

Downstream workaround

We add these cases to the SQLite compiler. An existing downstream regression assertion checks that an empty-result initialization query includes WHERE (0 = 1) rather than reading the entire cache.

This report is based on source inspection; downstream tests were not rerun for this report.

#506 discusses zero/one-argument support in the public query API. This report specifically concerns SQL compilation and full-table fallback in the persistence adapter.

Sign in to join this conversation.