Skip to content
Source
Sign inSign up
TanStack/query

refactor(solid-query): solid 2 reactivity compliance #10316

Merged2wheeh(GitHub profile, opens in a new tab)merged 4 commits intosolid-query-v6-pre fromrefs/pull/10316/headmerged by birkskyum(GitHub profile, opens in a new tab)

🎯 Changes

From RFC: Reactivity, batching, and effects,

  • 2.0 introduces strict top-level access - explicit untrack is necessary for the top-level reactive reads in component body.
  • No writes under owned scope - signals that sync external state (e.g., query cache subscriptions) use { pureWrite: true } to opt out of the dev warning, as these are one-way writes from external callbacks, not reactive feedback loops.
  • And warning for no destructuring reactive proxies: destructuring a store proxy (const { status } = useQuery(...)) evaluates the property immediately, losing reactivity. Accessing via state.status preserves tracking.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
    1. Important

      Review skipped

      Auto reviews are disabled on base/target branches other than the default branch.

      Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Pro

      Run ID: e4be1e9b-f372-4d41-9235-6a64ba222229

      You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

      Use the checkbox below for a quick retry:

      • 🔍 Trigger review
      ✨ Finishing Touches
      🧪 Generate unit tests (beta)
      • Create PR with unit tests

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    2. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-query

    3. View your CI Pipeline Execution ↗ for commit 72ddf97cfdb5f7576f008f88ad0244cb9e4df46e

      CommandStatusDurationResult
      nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded2m 15sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded42sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-03-23 06:07:02 UTC

    4. More templates

      @tanstack/angular-query-experimental

      npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10316

      @tanstack/eslint-plugin-query

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10316

      @tanstack/preact-query

      npm i https://pkg.pr.new/@tanstack/preact-query@10316

      @tanstack/preact-query-devtools

      npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10316

      @tanstack/preact-query-persist-client

      npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10316

      @tanstack/query-async-storage-persister

      npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10316

      @tanstack/query-broadcast-client-experimental

      npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10316

      @tanstack/query-core

      npm i https://pkg.pr.new/@tanstack/query-core@10316

      @tanstack/query-devtools

      npm i https://pkg.pr.new/@tanstack/query-devtools@10316

      @tanstack/query-persist-client-core

      npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10316

      @tanstack/query-sync-storage-persister

      npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10316

      @tanstack/react-query

      npm i https://pkg.pr.new/@tanstack/react-query@10316

      @tanstack/react-query-devtools

      npm i https://pkg.pr.new/@tanstack/react-query-devtools@10316

      @tanstack/react-query-next-experimental

      npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10316

      @tanstack/react-query-persist-client

      npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10316

      @tanstack/solid-query

      npm i https://pkg.pr.new/@tanstack/solid-query@10316

      @tanstack/solid-query-devtools

      npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10316

      @tanstack/solid-query-persist-client

      npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10316

      @tanstack/svelte-query

      npm i https://pkg.pr.new/@tanstack/svelte-query@10316

      @tanstack/svelte-query-devtools

      npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10316

      @tanstack/svelte-query-persist-client

      npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10316

      @tanstack/vue-query

      npm i https://pkg.pr.new/@tanstack/vue-query@10316

      @tanstack/vue-query-devtools

      npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10316

      commit: 2641790

    5. @brenelz @birkskyum Hi, I added some tweaks to reduce warnings

    6. birkskyum(GitHub profile, opens in a new tab) approved these changes

Sign in to join this conversation.