Open History to see the last commit
1import {
2 createStart,
3 createMiddleware,
4 createServerOnlyFn,
5} from '@tanstack/react-start'
6import { getRequest } from '@tanstack/react-start/server'
7β
8// Use a WeakMap keyed by Request object for request-scoped tracking
9// This is cleaner than global state and automatically garbage collects
10const requestMiddlewareCounts = new WeakMap<Request, Record<string, number>>()
11β
12// Helper to track middleware execution - attaches to the Request object
13// This is server-only since it uses getRequest()
14export const trackMiddlewareExecution = createServerOnlyFn(
15 (middlewareName: string) => {
16 const request = getRequest()
17 let counts = requestMiddlewareCounts.get(request)
18 if (!counts) {
19 counts = {}
20 requestMiddlewareCounts.set(request, counts)
21 }
22 counts[middlewareName] = (counts[middlewareName] || 0) + 1
23 console.log(
24 `[MIDDLEWARE] ${middlewareName} executed. Count: ${counts[middlewareName]}`,
25 )
26 return counts[middlewareName]
27 },
28)
29β
30// Helper to get execution counts for the current request
31// Wrapped in createServerOnlyFn since it uses getRequest()
32export const getMiddlewareExecutionCounts = createServerOnlyFn(
33 (): Record<string, number> => {
34 const request = getRequest()
35 return requestMiddlewareCounts.get(request) || {}
36 },
37)
38β
39// This is the middleware from issue #5239 - it's registered as BOTH:
40// 1. Global request middleware (in startInstance)
41// 2. Server function middleware (attached to individual server functions)
42// The bug is that it executes multiple times instead of being deduped
43export const loggingMiddleware = createMiddleware().server(async ({ next }) => {
44 trackMiddlewareExecution('loggingMiddleware')
45 return next({
46 context: {
47 loggingMiddlewareExecuted: true,
48 },
49 })
50})
51β
52// Regression test for #6647: verify that pathname is correctly passed to
53// global request middleware by createStartHandler
54export const pathnameMiddleware = createMiddleware().server(
55 async ({ next, pathname }) => {
56 return next({
57 context: {
58 requestMiddlewarePathname: pathname,
59 },
60 })
61 },
62)
63β
64export const trustedUserMiddleware = createMiddleware().server(
65 async ({ next }) => {
66 return next({
67 context: {
68 trustedUser: 'server-user',
69 },
70 })
71 },
72)
73β
74// Global function middleware that should be deduped across server functions
75export const globalFunctionMiddleware = createMiddleware({
76 type: 'function',
77}).server(async ({ next }) => {
78 trackMiddlewareExecution('globalFunctionMiddleware')
79 return next({
80 context: {
81 globalMiddlewareExecuted: true,
82 },
83 })
84})
85β
86// A second global middleware to test multiple global middlewares
87export const globalFunctionMiddleware2 = createMiddleware({
88 type: 'function',
89}).server(async ({ next }) => {
90 trackMiddlewareExecution('globalFunctionMiddleware2')
91 return next({
92 context: {
93 globalMiddleware2Executed: true,
94 },
95 })
96})
97β
98// Create the start instance with global middleware
99export const startInstance = createStart(() => ({
100 // Global function middleware that applies to all server functions
101 functionMiddleware: [globalFunctionMiddleware, globalFunctionMiddleware2],
102 // Request middleware - includes loggingMiddleware (issue #5239 scenario)
103 // AND the same loggingMiddleware is also attached to server functions
104 requestMiddleware: [
105 trustedUserMiddleware,
106 loggingMiddleware,
107 pathnameMiddleware,
108 ],
109}))