Skip to content
Source
Sign inSign up
TanStack/router

fix(start-plugin-core): Properly declare start-client-core in dependencies #5408

Mergedonlywei(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/5408/headmerged by schiller-manuel(GitHub profile, opens in a new tab)

Fixes #5398

fixes #5350

Under strict pnpm dependencies, if we require a package from a package, that package MUST be listed in its dependencies.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies by adding a new workspace package to the core plugin.
    • No user-facing changes or behavior adjustments.
    1. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core

    2. Walkthrough

      Added a new dependency entry "@tanstack/start-client-core": "workspace:*" to packages/start-plugin-core/package.json. No other files or logic were changed.

      Changes

      Cohort / File(s)Summary
      Dependency update
      packages/start-plugin-core/package.json
      Added dependency @tanstack/start-client-core with version workspace:* under dependencies.

      Estimated code review effort

      🎯 1 (Trivial) | ⏱️ ~3 minutes

      • TanStack/router#5350 — Addresses missing @tanstack/start-client-core dependency causing module resolution failures in workspace setups.

      Suggested labels

      package: start-client-core

      Poem

      A hop, a skip, a package in tow, I nudged a dep where it needed to go. Now builds won’t stumble, they’ll swiftly start— pnpm paths aligned like a rabbit’s heart. With workspace stars to light the way, We ship, we sip clover—hip hooray! 🐇✨

      Pre-merge checks and finishing touches

      ✅ Passed checks (5 passed)
      Check nameStatusExplanation
      Linked Issues Check✅ PassedThe pull request adds the @tanstack/start-client-core dependency to start-plugin-core, which directly resolves the module-not-found error described in issue #5398 when using pnpm or npm workspaces. This change fulfills the coding requirement of listing the internal package dependency to prevent the missing-package error in workspace environments.
      Out of Scope Changes Check✅ PassedAll modifications are confined to adding the single required dependency in the package.json file and align precisely with the objectives in linked issue #5398. There are no unrelated or extraneous changes introduced in this pull request.
      Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Title Check✅ PassedThe title succinctly and accurately captures the core change of the PR by indicating that the start-client-core dependency has been properly declared in the start-plugin-core package, aligning with the fix described in the changeset.
      ✨ Finishing touches
      • 📝 Generate docstrings
        🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Post copyable unit tests in a comment

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    3. View your CI Pipeline Execution ↗ for commit 10d5873c2abf328082dfa5c604862365483f9cd5

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded7m 4sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded16sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-10-08 17:38:52 UTC

    4. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5408

      @tanstack/directive-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5408

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5408

      @tanstack/history

      npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5408

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5408

      @tanstack/react-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5408

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5408

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5408

      @tanstack/react-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5408

      @tanstack/react-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5408

      @tanstack/react-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5408

      @tanstack/router-cli

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5408

      @tanstack/router-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5408

      @tanstack/router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5408

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5408

      @tanstack/router-generator

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5408

      @tanstack/router-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5408

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5408

      @tanstack/router-utils

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5408

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5408

      @tanstack/server-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5408

      @tanstack/solid-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5408

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5408

      @tanstack/solid-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5408

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5408

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5408

      @tanstack/start-client-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5408

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5408

      @tanstack/start-server-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5408

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5408

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5408

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5408

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5408

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5408

      commit: 10d5873

Sign in to join this conversation.