fix: set statusCode to 500 if error occurs #5541
Merged
schiller-manuel(GitHub profile, opens in a new tab)merged 1 commit into
main fromrefs/pull/5541/head·merged by schiller-manuel(GitHub profile, opens in a new tab) fixes #5535
Summary by CodeRabbit#
New Features
notFoundis now available as a public API export from router core.
Bug Fixes
- Improved status code computation to conditionally update based on not-found and error matches (404 or 500 respectively).
Tests
- Added comprehensive test coverage for status code behavior when loaders throw exceptions under synchronous and asynchronous conditions.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-router
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-core
View your CI Pipeline Execution ↗ for commit 3d15cc7ba12d643dd314b6935ebc2a0bfc572a48
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 5m 25s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 1m 22s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-19 21:53:14UTCMore templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5541@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5541@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5541@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5541@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5541@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5541@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5541@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5541@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5541@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5541@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5541@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5541@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5541@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5541@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5541@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5541@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5541@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5541@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5541@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5541@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5541@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5541@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5541@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5541@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5541@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5541@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5541@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5541@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5541@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5541@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5541@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5541@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5541@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5541commit:
3d15cc7
Sign in to join this conversation.
Walkthrough#
The PR fixes SSR status code handling by computing appropriate HTTP status codes (404 for not-found, 500 for errors) when loaders throw exceptions. It exports the
notFoundfunction from core and adds comprehensive tests verifying correct status code behavior across synchronous and asynchronous scenarios.Changes#
packages/router-core/src/router.tspackages/router-core/src/...notFoundfunction as a public entity from@tanstack/router-corepackages/react-router/tests/router.test.tsxSequence Diagram#
Estimated code review effort#
🎯 3 (Moderate) | ⏱️ ~20 minutes
The changes involve conditional logic modifications in the router's load handling and new test coverage across multiple scenarios. The logic shift from unconditional to conditional status code assignment requires careful verification of edge cases, but the overall scope remains focused on status code handling.
Possibly related PRs#
notFoundis processed in control flow.Poem#
Pre-merge checks and finishing touches#
✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between e87bd302aa0f2b7a06e48a9eeb4fde79fc6de2b1 and 3d15cc7ba12d643dd314b6935ebc2a0bfc572a48.
📒 Files selected for processing (2)
packages/react-router/tests/router.test.tsx(3 hunks)packages/router-core/src/router.ts(1 hunks)🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/router-core/src/router.tspackages/react-router/tests/router.test.tsxpackages/router-core/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/router-core/src/router.tspackages/{react-router,solid-router}/**
📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/react-router/tests/router.test.tsx🧠 Learnings (1)
📚 Learning: 2025-10-08T08:11:47.088Z
Applied to files:
packages/react-router/tests/router.test.tsx🧬 Code graph analysis (1)
packages/react-router/tests/router.test.tsx (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (4)
Comment `@coderabbitai help` to get the list of available commands and usage tips.