Skip to content
Source
Sign inSign up
TanStack/router

test(solid-start): prerendering - sync #5475 to solid #5627

Mergedbirkskyum(GitHub profile, opens in a new tab)merged 4 commits intomain fromrefs/pull/5627/headmerged by birkskyum(GitHub profile, opens in a new tab)

Blocked by

Related to

Summary by CodeRabbit

  • New Features

    • Added prerendering support for Solid Start projects, enabling static generation of routes.
  • Tests

    • Added end-to-end prerender test suite validating generated static routes and content.
    • Extended the test pipeline to run prerender mode and added lifecycle scripts to start/stop the test server and run prerender checks.
    1. Walkthrough

      Adds prerender mode support and wiring for e2e: new scripts and mode detector, Playwright and Vite changes to select prerender commands and plugin options, a new prerendering test suite, and updates to existing tests to account for prerender behavior.

      Changes

      Cohort / File(s)Summary
      Build & test scripts
      e2e/solid-start/basic/package.json
      Added build:prerender, test:e2e:prerender, test:e2e:startDummyServer, test:e2e:stopDummyServer; extended test:e2e sequence to include prerender tests.
      Test utils
      e2e/solid-start/basic/tests/utils/isPrerender.ts
      New exported isPrerender boolean (process.env.MODE === 'prerender').
      Playwright config
      e2e/solid-start/basic/playwright.config.ts
      Added prerender detection, prerenderModeCommand and getCommand() to select spa/prerender/ssr server command; added logging for prerender mode.
      Vite config
      e2e/solid-start/basic/vite.config.ts
      Imported isPrerender; added prerenderConfiguration (enabled, filter, maxRedirects) and conditionally passed it to tanstackStart plugin when prerender enabled.
      Prerender tests
      e2e/solid-start/basic/tests/prerendering.spec.ts
      New test suite verifying prerendered static routes exist/are excluded and validating generated HTML content for specific routes.
      Existing tests updated
      e2e/solid-start/basic/tests/search-params.spec.ts
      Added isPrerender import and adjusted redirect assertions to skip redirects in both SPA and prerender modes; minor import path changes.
      Minor/no-op
      packages/start-plugin-core/src/prerender.ts
      Whitespace/newline normalization; no logic changes.

      Sequence Diagram(s)

      sequenceDiagram
        autonumber
        actor Dev
        participant npm as package.json scripts
        participant PW as Playwright
        participant DevSrv as Dev/Build Server (vite)
        participant Tests as E2E Tests
        rect rgb(230, 245, 255)
          Dev->>npm: run test:e2e (includes prerender)
          npm->>PW: start playwright with project (chromium)
        end
        rect rgb(245, 255, 230)
          PW->>PW: determine mode (isSpaMode / isPrerender / isSsr)
          PW->>DevSrv: run webServer.command = getCommand()
          note right of PW: getCommand selects\nspa/prerender/ssr command
        end
        rect rgb(255, 250, 240)
          DevSrv->>Tests: serve app (or build prerendered assets)
          Tests->>DevSrv: if prerender -> read dist/client files
          Tests->>PW: report results
        end

      Estimated code review effort

      🎯 3 (Moderate) | ⏱️ ~20 minutes

      • Reviewers should focus on:
        • prerender test assertions in prerendering.spec.ts (file path checks and content expectations)
        • getCommand() logic and environment handling in playwright.config.ts
        • Vite prerenderConfiguration.filter correctness and its interaction with the start plugin
      • TanStack/router#5475 — Core prerendering work (autoStaticPathsDiscovery and generator/plugin changes) related to the prerender wiring and tests in this PR.
      • TanStack/router#5657 — Modifies the same search-params.spec.ts; related due to overlapping test adjustments.
      • TanStack/router#5643 — Adjusts redirect assertions in tests that overlap with this PR’s redirect conditional updates.

      Suggested reviewers

      • schiller-manuel

      Poem

      🐇 I hopped through modes both calm and spry, Built static paths beneath the sky, Tests now peek into dist and cheer, Prerendered pages gathered near — A crunchy carrot for CI! 🥕

      Pre-merge checks and finishing touches

      ✅ Passed checks (2 passed)
      Check nameStatusExplanation
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Title Check✅ PassedThe pull request title "test(solid-start): prerendering - sync #5475 to solid" directly addresses the primary changes in the changeset. The main modifications involve adding prerendering support to the Solid Start e2e test suite, including new test scripts, configuration files (playwright.config.ts, vite.config.ts), new test specifications for prerendering validation, and utility functions to detect prerender mode. The title explicitly mentions "prerendering" as the feature being added and correctly scopes it to "solid-start," making it clear and specific enough for a reviewer to understand the changeset's purpose.
      ✨ Finishing touches
      • 📝 Generate docstrings
        🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Post copyable unit tests in a comment
      • Commit unit tests in branch `sync-#5475-to-solid`

      📜 Recent review details

      Configuration used: CodeRabbit UI

      Review profile: CHILL

      Plan: Pro

      📥 Commits

      Reviewing files that changed from the base of the PR and between 7b61b60ae143bdc710eefe4b31008e5a53bbbb59 and d7c32dbafea44e5fcc3a869874e7f6ca1d709bea.

      📒 Files selected for processing (7)
      • e2e/solid-start/basic/package.json (1 hunks)
      • e2e/solid-start/basic/playwright.config.ts (4 hunks)
      • e2e/solid-start/basic/tests/prerendering.spec.ts (1 hunks)
      • e2e/solid-start/basic/tests/search-params.spec.ts (3 hunks)
      • e2e/solid-start/basic/tests/utils/isPrerender.ts (1 hunks)
      • e2e/solid-start/basic/vite.config.ts (3 hunks)
      • packages/start-plugin-core/src/prerender.ts (1 hunks)
      ✅ Files skipped from review due to trivial changes (1)
      • packages/start-plugin-core/src/prerender.ts
      🚧 Files skipped from review as they are similar to previous changes (4)
      • e2e/solid-start/basic/tests/search-params.spec.ts
      • e2e/solid-start/basic/playwright.config.ts
      • e2e/solid-start/basic/vite.config.ts
      • e2e/solid-start/basic/tests/prerendering.spec.ts
      🧰 Additional context used
      📓 Path-based instructions (3)
      **/package.json

      📄 CodeRabbit inference engine (AGENTS.md)

      Use workspace:* protocol for internal dependencies in package.json files

      Files:

      • e2e/solid-start/basic/package.json
      e2e/**

      📄 CodeRabbit inference engine (AGENTS.md)

      Store end-to-end tests under the e2e/ directory

      Files:

      • e2e/solid-start/basic/package.json
      • e2e/solid-start/basic/tests/utils/isPrerender.ts
      **/*.{ts,tsx}

      📄 CodeRabbit inference engine (AGENTS.md)

      Use TypeScript in strict mode with extensive type safety across the codebase

      Files:

      • e2e/solid-start/basic/tests/utils/isPrerender.ts
      🔇 Additional comments (3)
      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)

      1-1: LGTM! Clean and type-safe mode detection.

      The implementation correctly checks the environment variable and provides a typed boolean export. The implicit handling of undefined process.env.MODE (evaluating to false) is the appropriate default behavior.

      e2e/solid-start/basic/package.json (2)

      11-11: LGTM! Consistent with existing build patterns.

      The build:prerender script correctly follows the same pattern as build:spa, setting the MODE environment variable and running the build with type checking.


      18-19: LGTM! Prerender test integration follows established patterns.

      The new test:e2e:prerender script correctly follows the same structure as the existing spa and ssr test modes, and the updated test:e2e script properly chains all three modes for comprehensive coverage.


      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    2. View your CI Pipeline Execution ↗ for commit d7c32dbafea44e5fcc3a869874e7f6ca1d709bea

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded5m 28sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded16sView ↗

      ☁️ Nx Cloud last updated this comment at 2025-11-03 03:02:16 UTC

    3. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5627

      @tanstack/directive-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5627

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5627

      @tanstack/history

      npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5627

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5627

      @tanstack/react-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5627

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5627

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5627

      @tanstack/react-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5627

      @tanstack/react-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5627

      @tanstack/react-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5627

      @tanstack/router-cli

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5627

      @tanstack/router-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5627

      @tanstack/router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5627

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5627

      @tanstack/router-generator

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5627

      @tanstack/router-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5627

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5627

      @tanstack/router-utils

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5627

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5627

      @tanstack/server-functions-plugin

      npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5627

      @tanstack/solid-router

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5627

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5627

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5627

      @tanstack/solid-start

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5627

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5627

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5627

      @tanstack/start-client-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5627

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5627

      @tanstack/start-server-core

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5627

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5627

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5627

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5627

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5627

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5627

      commit: d7c32db

    4. Actionable comments posted: 3

      🧹 Nitpick comments (2)
      e2e/solid-start/basic/tests/prerendering.spec.ts (2)

      10-31: Consider adding a dist directory existence check.

      The test assumes dist/client exists without verifying. If the build fails or the test runs from an unexpected location, the error messages could be confusing.

      Apply this diff to add an initial check:

        test('should automatically discover and prerender static routes', () => {
          // Check that static routes were automatically discovered and prerendered
          const distDir = join(process.cwd(), 'dist', 'client')
      +   expect(existsSync(distDir)).toBe(true)
      
          // These static routes should be automatically discovered and prerendered
          expect(existsSync(join(distDir, 'index.html'))).toBe(true)

      34-52: Consider parameterizing the content verification tests.

      The two tests have identical structure and could be combined using test.each to reduce duplication and make it easier to add more content checks.

      Example refactor:

      test.describe('Static Files Verification', () => {
        test.each([
          { route: 'posts', expectedContent: 'Select a post.' },
          { route: 'users', expectedContent: 'Select a user.' },
        ])('should contain prerendered content in $route.html', ({ route, expectedContent }) => {
          const distDir = join(process.cwd(), 'dist', 'client')
          const htmlPath = join(distDir, route, 'index.html')
          
          expect(existsSync(htmlPath)).toBe(true)
          const html = readFileSync(htmlPath, 'utf-8')
          expect(html).toContain(expectedContent)
        })
      })
      📜 Review details

      Configuration used: CodeRabbit UI

      Review profile: CHILL

      Plan: Pro

      📥 Commits

      Reviewing files that changed from the base of the PR and between 6e557f9d40d5c6ad70cf6b54427c33bf59f0550d and 7b61b60ae143bdc710eefe4b31008e5a53bbbb59.

      📒 Files selected for processing (6)
      • e2e/solid-start/basic/package.json (1 hunks)
      • e2e/solid-start/basic/playwright.config.ts (4 hunks)
      • e2e/solid-start/basic/tests/prerendering.spec.ts (1 hunks)
      • e2e/solid-start/basic/tests/search-params.spec.ts (4 hunks)
      • e2e/solid-start/basic/tests/utils/isPrerender.ts (1 hunks)
      • e2e/solid-start/basic/vite.config.ts (3 hunks)
      🧰 Additional context used
      📓 Path-based instructions (3)
      **/*.{ts,tsx}

      📄 CodeRabbit inference engine (AGENTS.md)

      Use TypeScript in strict mode with extensive type safety across the codebase

      Files:

      • e2e/solid-start/basic/tests/utils/isPrerender.ts
      • e2e/solid-start/basic/vite.config.ts
      • e2e/solid-start/basic/tests/search-params.spec.ts
      • e2e/solid-start/basic/playwright.config.ts
      • e2e/solid-start/basic/tests/prerendering.spec.ts
      e2e/**

      📄 CodeRabbit inference engine (AGENTS.md)

      Store end-to-end tests under the e2e/ directory

      Files:

      • e2e/solid-start/basic/tests/utils/isPrerender.ts
      • e2e/solid-start/basic/package.json
      • e2e/solid-start/basic/vite.config.ts
      • e2e/solid-start/basic/tests/search-params.spec.ts
      • e2e/solid-start/basic/playwright.config.ts
      • e2e/solid-start/basic/tests/prerendering.spec.ts
      **/package.json

      📄 CodeRabbit inference engine (AGENTS.md)

      Use workspace:* protocol for internal dependencies in package.json files

      Files:

      • e2e/solid-start/basic/package.json
      🧬 Code graph analysis (4)
      e2e/solid-start/basic/vite.config.ts (1)
      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)
      • isPrerender (1-1)
      e2e/solid-start/basic/tests/search-params.spec.ts (1)
      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)
      • isPrerender (1-1)
      e2e/solid-start/basic/playwright.config.ts (2)
      e2e/solid-start/basic/tests/utils/isSpaMode.ts (1)
      • isSpaMode (1-1)
      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)
      • isPrerender (1-1)
      e2e/solid-start/basic/tests/prerendering.spec.ts (1)
      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)
      • isPrerender (1-1)
      🔇 Additional comments (11)
      e2e/solid-start/basic/vite.config.ts (2)

      6-6: LGTM!

      The import follows the established pattern of the isSpaMode utility.


      15-26: Clarify the filter logic concern — one example is invalid, and the suggested fix has issues.

      The substring matching concern is partially valid but contains errors:

      • Valid: A path like /redirect-me would incorrectly match and be filtered out (false positive)
      • Invalid: A path /not-found/something/else would NOT match /not-found/via-loader (that substring doesn't exist in the path)

      Additionally, the first suggested fix is incorrect: .includes(page.path) checks if the array contains the path as an element (exact matching), which is not the intended behavior.

      The .startsWith() approach would be appropriate if you want prefix-based exclusion of all nested routes under /redirect and /not-found. However, you should verify whether the current substring-matching behavior is intentional given that the codebase has routes like /redirect/$target/via-beforeLoad that would match the /redirect pattern regardless.

      e2e/solid-start/basic/tests/utils/isPrerender.ts (1)

      1-1: LGTM!

      Clean utility following the established pattern of isSpaMode.

      e2e/solid-start/basic/playwright.config.ts (3)

      7-8: LGTM!

      The imports are correct, and the JSON import assertion syntax is appropriate.


      28-28: LGTM!

      The console logging helps with debugging test execution modes.


      46-46: LGTM!

      Using the getCommand() helper improves code clarity.

      e2e/solid-start/basic/tests/search-params.spec.ts (2)

      31-33: LGTM!

      The updated redirect logic correctly accounts for prerender mode. Prerendered pages are static, so server-side redirects don't occur at request time—they're handled during the build.

      Also applies to: 56-58


      69-69: LGTM!

      URL normalization by removing the unnecessary trailing slash before the query parameters improves consistency.

      e2e/solid-start/basic/tests/prerendering.spec.ts (1)

      1-8: LGTM!

      The imports are appropriate for filesystem-based prerender verification, and the conditional skip ensures tests only run in the correct mode.

      e2e/solid-start/basic/package.json (2)

      11-11: LGTM!

      The build script follows the established pattern and correctly sets the MODE environment variable.


      18-19: LGTM!

      The test scripts properly integrate prerender mode into the e2e test workflow, and the sequential chaining with && ensures that failures in any mode stop the test run.

      Resolvedby coderabbitai[bot](GitHub profile, opens in a new tab)
      e2e/solid-start/basic/playwright.config.ts lines 20 to 26
      @@ -16,4 +17,10 @@
      1617 const baseURL = `http://localhost:${PORT}`
      1718 const spaModeCommand = `pnpm build:spa && pnpm start:spa`
      1819 const ssrModeCommand = `pnpm build && pnpm start`
      20+const prerenderModeCommand = `pnpm run test:e2e:startDummyServer && pnpm build:prerender && pnpm run test:e2e:stopDummyServer && pnpm start`
      1921
      22+const getCommand = () => {
      23+ if (isSpaMode) return spaModeCommand
      24+ if (isPrerender) return prerenderModeCommand
      25+ return ssrModeCommand
      26+}

      ⚠️ Potential issue | 🔴 Critical

      🧩 Analysis chain

      Review the dummy server lifecycle management for potential issues.

      The prerenderModeCommand chains commands with &&, which could lead to:

      1. Resource leak: If build:prerender fails, stopDummyServer won't execute, leaving the dummy server running.
      2. Race condition: There's no synchronization between startDummyServer and build:prerender. If the dummy server takes time to initialize, the build might start before the server is ready.

      The getCommand() helper refactoring is clean and improves readability.

      Consider adding error handling to ensure cleanup:

      -const prerenderModeCommand = `pnpm run test:e2e:startDummyServer && pnpm build:prerender && pnpm run test:e2e:stopDummyServer && pnpm start`
      +const prerenderModeCommand = `pnpm run test:e2e:startDummyServer && (pnpm build:prerender; pnpm run test:e2e:stopDummyServer) && pnpm start`

      Or verify that the dummy server scripts include their own timeout/retry logic to handle startup delays.


      🏁 Script executed:

      #!/bin/bash
      # View the playwright config file to see the current state
      cat e2e/solid-start/basic/playwright.config.ts

      Length of output: 1965


      🏁 Script executed:

      #!/bin/bash
      # Search for dummy server script definitions in package.json or other config files
      fd -t f "package.json" | head -5 | xargs -I {} sh -c 'echo "=== {} ===" && grep -A 2 -B 2 "startDummyServer\|stopDummyServer" {} 2>/dev/null || true'

      Length of output: 254


      🏁 Script executed:

      #!/bin/bash
      # Check for any scripts directory or test setup files that might define the dummy server
      fd -t f "(startDummyServer|stopDummyServer|dummy)" e2e/

      Length of output: 0


      🏁 Script executed:

      #!/bin/bash
      # Look for any error handling or cleanup logic in e2e test setup
      rg -n "trap\|catch\|error\|cleanup" e2e/solid-start/basic/ --type ts --type js

      Length of output: 0


      🏁 Script executed:

      #!/bin/bash
      # Search for dummy server script definitions in root package.json
      cat package.json | grep -A 100 '"scripts"' | head -50

      Length of output: 2485


      🏁 Script executed:

      #!/bin/bash
      # Search for these specific scripts across the entire codebase
      rg -n "startDummyServer|stopDummyServer" --type json --type ts --type js -B 1 -A 1

      Length of output: 1672


      🏁 Script executed:

      #!/bin/bash
      # Check if there's a workspace configuration that might define these scripts
      fd -t f "pnpm-workspace.yaml|turbo.json|package.json" -x grep -l "startDummyServer\|stopDummyServer" {} \;

      Length of output: 73


      🏁 Script executed:

      #!/bin/bash
      # View the global setup and teardown files to understand their robustness
      cat e2e/solid-start/basic/tests/setup/global.setup.ts

      Length of output: 220


      🏁 Script executed:

      #!/bin/bash
      # View teardown file
      cat e2e/solid-start/basic/tests/setup/global.teardown.ts

      Length of output: 221


      🏁 Script executed:

      #!/bin/bash
      # Check if there are any existing error handling patterns in the e2e config or setup
      grep -r "trap\|error\|catch\|finally" e2e/solid-start/basic/tests/setup/ --include="*.ts" -n

      Length of output: 0


      Address dummy server lifecycle management issues in prerender command.

      The resource leak and race condition concerns are confirmed valid:

      1. Resource leak: If build:prerender fails, stopDummyServer never executes due to && chaining, leaving the background dummy server process orphaned.
      2. Race condition: startDummyServer runs backgrounded (&), allowing build:prerender to start immediately without explicit synchronization. The server may still be initializing when the build begins.

      The suggested fix using subshell syntax (pnpm build:prerender; pnpm run test:e2e:stopDummyServer) does ensure cleanup runs, but it changes error propagation—if cleanup fails, the subsequent pnpm start also fails.

      Verify and apply one of these approaches:

      • Option A (Cleanup priority): Use the suggested subshell approach if cleanup failures should halt execution.
      • Option B (Explicit trap): Use shell trap to guarantee cleanup: trap 'pnpm run test:e2e:stopDummyServer' EXIT before the build.
      • Option C (Explicit wait): Add explicit wait logic after startDummyServer to ensure the dummy server is ready before proceeding.

      Same issue exists in e2e/react-start/basic/playwright.config.ts line 20.

      🤖 Prompt for AI Agents
      In e2e/solid-start/basic/playwright.config.ts around lines 20 to 26, the
      prerender command uses chained commands that can leak the background dummy
      server and race with the build; replace the one-liner with a safe sequence that
      starts the dummy server, waits for it to be ready, runs build:prerender, and
      always stops the dummy server on exit—either (A) wrap build and cleanup in a
      subshell so cleanup runs and failures propagate, (B) set a shell trap to run
      pnpm run test:e2e:stopDummyServer on EXIT before starting the server, or (C) add
      an explicit readiness wait after starting the server (e.g., polling a health
      endpoint) then run build and finally stop the server; apply the same change to
      e2e/react-start/basic/playwright.config.ts at line 20.
      e2e/solid-start/basic/tests/search-params.spec.ts lines 3 to 4
      @@ -1,3 +1,4 @@
      11 import { expect } from '@playwright/test'
      22 import { test } from '@tanstack/router-e2e-utils'
      3-import { isSpaMode } from '../tests/utils/isSpaMode'
      3+import { isSpaMode } from 'tests/utils/isSpaMode'
      4+import { isPrerender } from './utils/isPrerender'

      ⚠️ Potential issue | 🟡 Minor

      Inconsistent import paths for utilities.

      Line 3 uses tests/utils/isSpaMode (absolute/tsconfig path) while line 4 uses ./utils/isPrerender (relative path). For consistency, both utilities should use the same import pattern.

      Apply this diff to make imports consistent:

      -import { isSpaMode } from 'tests/utils/isSpaMode'
      -import { isPrerender } from './utils/isPrerender'
      +import { isSpaMode } from './utils/isSpaMode'
      +import { isPrerender } from './utils/isPrerender'

      Or if tsconfig paths are preferred:

      -import { isSpaMode } from 'tests/utils/isSpaMode'
      -import { isPrerender } from './utils/isPrerender'
      +import { isSpaMode } from 'tests/utils/isSpaMode'
      +import { isPrerender } from 'tests/utils/isPrerender'
      📝 Committable suggestion

      ‼️ IMPORTANT Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

      import { isSpaMode } from 'tests/utils/isSpaMode'
      import { isPrerender } from 'tests/utils/isPrerender'
      🤖 Prompt for AI Agents
      In e2e/solid-start/basic/tests/search-params.spec.ts around lines 3 to 4, the
      two utility imports use inconsistent paths (one using tsconfig/absolute
      'tests/utils/isSpaMode' and the other a relative './utils/isPrerender'); make
      them consistent by changing the import so both use the same pattern—either
      update line 3 to a relative import './utils/isSpaMode' or update line 4 to the
      tsconfig path 'tests/utils/isPrerender' depending on the project convention
      (prefer tsconfig paths if that is the established pattern), and run a quick
      compile to ensure the chosen path resolves.
    5. birkskyum(GitHub profile, opens in a new tab) added labelsneeded-for-start-stable

    6. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core

    7. birkskyum(GitHub profile, opens in a new tab) removed labelsneeded-for-start-stable

Sign in to join this conversation.