fix: fix static server functions #5650
main fromrefs/pull/5650/head·merged by schiller-manuel(GitHub profile, opens in a new tab) Fixes https://github.com/TanStack/router/issues/5472
Summary by CodeRabbit#
New Features
- Added React framework support to the basic static example project.
Chores
- Enhanced dependency optimization for server-side rendering scenarios.
- Updated optional peer dependency configuration for improved cross-framework compatibility.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-static-server-functions
View your CI Pipeline Execution ↗ for commit 5632c0f3b5272852b21d75497afa6fa3c0a9a0ba
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 5m 35s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 11s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-27 23:03:42UTCMore templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5650@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5650@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5650@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5650@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5650@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5650@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5650@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5650@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5650@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5650@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5650@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5650@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5650@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5650@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5650@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5650@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5650@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5650@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5650@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5650@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5650@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5650@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5650@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5650@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5650@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5650@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5650@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5650@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5650@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5650@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5650@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5650@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5650@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5650@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5650commit:
5632c0fDidn't seem to fix the issue. Tested by installing the pkg.new
brenelz(GitHub profile, opens in a new tab) closed this
brenelz(GitHub profile, opens in a new tab) reopened this
brenelz(GitHub profile, opens in a new tab) closed this
brenelz(GitHub profile, opens in a new tab) reopened this
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-start
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-start
brenelz(GitHub profile, opens in a new tab) changed the title
schiller-manuel(GitHub profile, opens in a new tab) changed the title
Sign in to join this conversation.
Caution
Review failed#
The pull request is closed.
Walkthrough#
The PR addresses rendering issues in the start-basic-static examples by adding the React Vite plugin to the React example's configuration, excluding the static server functions package from dependency optimization in both react-start and solid-start Vite plugins, and declaring optional peer dependencies for framework packages in the start-static-server-functions package.
Changes#
examples/react/start-basic-static/package.json,examples/react/start-basic-static/vite.config.tspackages/react-start/src/plugin/vite.ts,packages/solid-start/src/plugin/vite.tspackages/start-static-server-functions/package.jsonEstimated code review effort#
🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs#
Suggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (1 warning)
@coderabbitai generate docstringsto improve docstring coverage.✅ Passed checks (2 passed)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ad0e70200cc52320d0c189d4f7c903c257e842a2 and 5632c0f3b5272852b21d75497afa6fa3c0a9a0ba.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml📒 Files selected for processing (2)
packages/react-start/src/plugin/vite.ts(1 hunks)packages/solid-start/src/plugin/vite.ts(1 hunks)Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share