feat(start-plugin-core): vite preview support #5910
main fromrefs/pull/5910/head·merged by birkskyum(GitHub profile, opens in a new tab) This adds vite preview support with a new preview server plugin that loads the built server bundle and serves SSR requests. Both the react-start and solid-start basic e2e projects have been updated to re-run their test suites in preview mode.
Summary by CodeRabbit#
New Features
- Added preview-server integration to enable running built apps in preview mode.
- Added a runtime preview mode toggle for e2e runs.
Tests
- Added preview-mode e2e test scripts and included preview validation in test orchestration.
- Test configs updated to support preview-specific ports and execution paths.
Chores
- Added a small runtime helper to detect preview mode from the environment.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core
View your CI Pipeline Execution ↗ for commit 5b7b4bf6dd5890b35ed0caaca4542a3b464f1ea6
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 7m 18s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 16s View ↗
☁️ Nx Cloud last updated this comment at
2025-11-20 00:40:43UTCMore templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5910@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5910@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5910@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5910@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5910@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5910@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5910@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5910@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5910@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5910@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5910@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5910@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5910@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5910@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5910@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5910@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5910@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5910@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5910@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5910@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5910@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5910@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5910@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5910@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5910@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5910@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5910@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5910@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5910@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5910@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5910@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5910@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5910@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5910@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5910commit:
5b7b4bf- packages/start-plugin-core/src/preview-server-plugin/plugin.ts lines 49 to 53@@ -0,0 +33,21 @@33+ }34+35+ // Get basename without extension and add .js36+ const outputFilename = `${basename(serverInput, extname(serverInput))}.js`37+ const serverOutputDir = getServerOutputDirectory(server.config)38+ const serverEntryPath = join(serverOutputDir, outputFilename)39+ const imported = await import(40+ pathToFileURL(serverEntryPath).toString()41+ )42+43+ serverBuild = imported.default44+ }45+46+ const webReq = new NodeRequest({ req, res })47+ const webRes: Response = await serverBuild.fetch(webReq)48+49+ // Temporary workaround50+ // Vite preview's compression middleware doesn't support flattened array headers that srvx sets51+ // Call writeHead() before srvx to avoid corruption52+ res.setHeaders(webRes.headers)53+ res.writeHead(webRes.status, webRes.statusText)
For context:
Vite preview server uses
@polka/compressionto handle compression. This middleware overwrites theres.writeHeadmethod, which expects headers to be an object and uses afor...inloop to iterate over them.However,
srvxpasses headers as a flattened array towriteHead(). When the middleware'sfor...inloop runs through an array, it iterates over array indices ('0','1','2', ...) instead of the actual header names.This causes header corruption where a header like:
Content-Type: text/html; charset=utf-8Becomes:
0: Content-Type 1: text/html; charset=utf-8The workaround is to call
res.writeHead()directly beforesendNodeResponse(), which setsres.headersSent = trueand causessendNodeResponse()to skip header writing entirely.I will try to submit a patch to either Vite or
@polka/compression, but we will likely want to keep this workaround for compatibility with earlier versions of Vite. Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 292b82a2081be3f7c88f83600d2a06ee82327931 and 4153eb68f6a4f788d99eb4d3fce3b1c8f2b739e9.
📒 Files selected for processing (11)
e2e/react-start/basic/package.json(1 hunks)e2e/react-start/basic/playwright.config.ts(2 hunks)e2e/react-start/basic/tests/redirect.spec.ts(1 hunks)e2e/react-start/basic/tests/utils/isPreview.ts(1 hunks)e2e/solid-start/basic/package.json(1 hunks)e2e/solid-start/basic/playwright.config.ts(2 hunks)e2e/solid-start/basic/tests/redirect.spec.ts(1 hunks)e2e/solid-start/basic/tests/utils/isPreview.ts(1 hunks)packages/start-plugin-core/src/output-directory.ts(1 hunks)packages/start-plugin-core/src/plugin.ts(2 hunks)packages/start-plugin-core/src/preview-server-plugin/plugin.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-02T16:16:24.898Z
Learnt from: nlynzaad Repo: TanStack/router PR: 5732 File: packages/start-client-core/src/client/hydrateStart.ts:6-9 Timestamp: 2025-11-02T16:16:24.898Z Learning: In packages/start-client-core/src/client/hydrateStart.ts, the `import/no-duplicates` ESLint disable is necessary for imports from `#tanstack-router-entry` and `#tanstack-start-entry` because both aliases resolve to the same placeholder file (`fake-start-entry.js`) in package.json during static analysis, even though they resolve to different files at runtime.Applied to files:
packages/start-plugin-core/src/plugin.tse2e/solid-start/basic/tests/redirect.spec.tse2e/react-start/basic/tests/redirect.spec.tse2e/solid-start/basic/playwright.config.tse2e/react-start/basic/playwright.config.ts
📚 Learning: 2025-10-01T18:30:26.591Z
Learnt from: schiller-manuel Repo: TanStack/router PR: 5330 File: packages/router-core/src/router.ts:2231-2245 Timestamp: 2025-10-01T18:30:26.591Z Learning: In `packages/router-core/src/router.ts`, the `resolveRedirect` method intentionally strips the router's origin from redirect URLs when they match (e.g., `https://foo.com/bar` → `/bar` for same-origin redirects) while preserving the full URL for cross-origin redirects. This logic should not be removed or simplified to use `location.publicHref` directly.Applied to files:
e2e/solid-start/basic/tests/redirect.spec.tse2e/react-start/basic/tests/redirect.spec.ts
📚 Learning: 2025-10-08T08:11:47.088Z
Learnt from: nlynzaad Repo: TanStack/router PR: 5402 File: packages/router-generator/tests/generator/no-formatted-route-tree/routeTree.nonnested.snapshot.ts:19-21 Timestamp: 2025-10-08T08:11:47.088Z Learning: Test snapshot files in the router-generator tests directory (e.g., files matching the pattern `packages/router-generator/tests/generator/**/routeTree*.snapshot.ts` or `routeTree*.snapshot.js`) should not be modified or have issues flagged, as they are fixtures used to verify the generator's output and are intentionally preserved as-is.Applied to files:
e2e/solid-start/basic/tests/redirect.spec.tse2e/react-start/basic/tests/redirect.spec.tse2e/solid-start/basic/playwright.config.tse2e/react-start/basic/playwright.config.ts
🧬 Code graph analysis (9)
e2e/solid-start/basic/tests/utils/isPreview.ts (1)
e2e/react-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
packages/start-plugin-core/src/output-directory.ts (1)
packages/start-plugin-core/src/constants.ts (1)
VITE_ENVIRONMENT_NAMES(1-6)
packages/start-plugin-core/src/plugin.ts (1)
packages/start-plugin-core/src/preview-server-plugin/plugin.ts (1)
previewServerPlugin(8-64)
e2e/solid-start/basic/tests/redirect.spec.ts (2)
e2e/e2e-utils/src/derivePort.ts (1)
getTestServerPort(25-27)
e2e/solid-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
e2e/react-start/basic/tests/redirect.spec.ts (3)
e2e/e2e-utils/src/derivePort.ts (1)
getTestServerPort(25-27)
e2e/react-start/basic/tests/utils/isSpaMode.ts (1)
isSpaMode(1-1)
e2e/react-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
e2e/react-start/basic/tests/utils/isPreview.ts (1)
e2e/solid-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
packages/start-plugin-core/src/preview-server-plugin/plugin.ts (2)
packages/start-plugin-core/src/constants.ts (1)
VITE_ENVIRONMENT_NAMES(1-6)
packages/start-plugin-core/src/output-directory.ts (1)
getServerOutputDirectory(12-16)
e2e/solid-start/basic/playwright.config.ts (5)
e2e/react-start/server-functions/playwright.config.ts (1)
PORT(5-5)
e2e/e2e-utils/src/derivePort.ts (1)
getTestServerPort(25-27)
e2e/solid-start/basic/tests/utils/isSpaMode.ts (1)
isSpaMode(1-1)
e2e/solid-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
e2e/solid-start/basic/tests/utils/isPrerender.ts (1)
isPrerender(1-1)
e2e/react-start/basic/playwright.config.ts (4)
e2e/e2e-utils/src/derivePort.ts (1)
getTestServerPort(25-27)
e2e/react-start/basic/tests/utils/isSpaMode.ts (1)
isSpaMode(1-1)
e2e/react-start/basic/tests/utils/isPreview.ts (1)
isPreview(1-1)
e2e/react-start/basic/tests/utils/isPrerender.ts (1)
isPrerender(1-1)
🔇 Additional comments (10)
e2e/react-start/basic/tests/redirect.spec.ts (1)
10-18: Preview port key wiring looks consistentUsing
isPreviewto append the_previewsuffix to thegetTestServerPortkey mirrors the Playwright config and cleanly separates preview ports from SSR/SPA runs. Looks good.e2e/solid-start/basic/package.json (1)
12-21: Preview scripts align with new test modeThe
previewandtest:e2e:previewscripts, plus the updatedtest:e2echain, match the MODE-based setup and existing patterns for spa/prerender/SSR. No changes needed.e2e/react-start/basic/tests/utils/isPreview.ts (1)
1-1: MODE-based isPreview flag is straightforwardisPreviewmirrors the existingisSpaModepattern and cleanly expresses preview mode fromMODE. Looks good as-is.e2e/solid-start/basic/tests/utils/isPreview.ts (1)
1-1: Solid isPreview helper matches React counterpartSame
MODE === 'preview'check as in the React tests, keeping the mode handling consistent between suites.e2e/solid-start/basic/tests/redirect.spec.ts (1)
11-18: Preview-aware port derivation matches Solid configIncluding
isPreviewin thegetTestServerPortkey ensures the redirect tests hit the same preview-specific port that the Playwright config uses. Looks correct.e2e/solid-start/basic/playwright.config.ts (1)
8-33: Preview mode integration into Solid Playwright config looks soundThe
isPreviewflag,_preview-suffixed port key, andpreviewModeCommandbranch ingetCommand()fit the existing spa/prerender/SSR pattern and stay in sync with the test expectations. Logging the preview state should also help debug CI runs.e2e/react-start/basic/playwright.config.ts (1)
8-33: React Playwright preview support is consistent and minimalThe
isPreviewimport,_previewport key, andpreviewModeCommandhook neatly into the existing mode switch without affecting spa/prerender/SSR behavior. This looks correct and aligned with the tests.e2e/react-start/basic/package.json (1)
12-21: React preview scripts mirror Solid and fit the new flowThe new
previewandtest:e2e:previewscripts, plus the extendedtest:e2echain, line up with the React Playwright config and isPreview helper. All good.packages/start-plugin-core/src/plugin.ts (1)
14-14: Preview plugin wiring looks solid.Importing and registering
previewServerPlugin()ahead of the bundle capture keeps the lifecycle intact for preview runs. 👍Also applies to: 403-403
packages/start-plugin-core/src/output-directory.ts (1)
6-20: AcceptingResolvedConfighere is helpful.The widened signatures let runtime hooks share the same helper without duplicating logic—looks good.
packages/start-plugin-core/src/preview-server-plugin/plugin.ts lines 52 to 55@@ -0,0 +35,21 @@35+ // Get basename without extension and add .js36+ const outputFilename = `${basename(serverInput, extname(serverInput))}.js`37+ const serverOutputDir = getServerOutputDirectory(server.config)38+ const serverEntryPath = join(serverOutputDir, outputFilename)39+ const imported = await import(40+ pathToFileURL(serverEntryPath).toString()41+ )42+43+ serverBuild = imported.default44+ }45+46+ const webReq = new NodeRequest({ req, res })47+ const webRes: Response = await serverBuild.fetch(webReq)48+49+ // Temporary workaround50+ // Vite preview's compression middleware doesn't support flattened array headers that srvx sets51+ // Call writeHead() before srvx to avoid corruption52+ res.setHeaders(webRes.headers)53+ res.writeHead(webRes.status, webRes.statusText)54+55+ return sendNodeResponse(res, webRes)⚠️ Potential issue | 🟠 Major
Guard
res.setHeadersfor older Node runtimes.During
vite preview, many projects still run on Node 18.14 or earlier. On those versionsServerResponse#setHeadersis undefined, so these lines throw and the preview server never responds. Please gate this by checkingtypeof res.setHeaders === 'function'and fall back to iteratingwebRes.headerswithres.setHeader(...)when it isn’t available.🤖 Prompt for AI Agents
In packages/start-plugin-core/src/preview-server-plugin/plugin.ts around lines 52 to 55, res.setHeaders may be undefined on older Node versions (e.g., Node 18.14) which causes a crash; guard that call by checking if typeof res.setHeaders === 'function' and call it when available, otherwise iterate over webRes.headers and call res.setHeader(headerName, headerValue) for each entry (normalize headerValue to a string or join arrays with ',') before calling res.writeHead and returning sendNodeResponse.SeanCassiere reviewed
Love it!
We should probably update all the e2e sandboxes to use the preview command, but that might make more sense to ship once this PR lands in, just to avoid huge-PR-syndrome.
SeanCassiere changed the title
Tested this out, and it seems to work as expected
birkskyum(GitHub profile, opens in a new tab) approved these changes
I've tried it out a bit, and it sure does appear to work. Great to get support for this!
birkskyum(GitHub profile, opens in a new tab) closed this
Thanks for the review @birkskyum @SeanCassiere!
Sign in to join this conversation.
Walkthrough#
Adds a preview test mode across React and Solid e2e suites with new scripts and preview-aware Playwright ports; introduces an isPreview test utility; broadens Vite config types in output-directory utilities; and adds a new preview-server Vite plugin that lazily loads and proxies the server build during preview.
Changes#
e2e/react-start/basic/package.jsonpreviewscript (vite preview), addedtest:e2e:preview, and updatedtest:e2eto include preview testse2e/react-start/basic/playwright.config.tsisPreview, addedpreviewModeCommand, and append_previewsuffix to PORT whenisPreviewis true;getCommand()selects preview command accordinglye2e/react-start/basic/tests/redirect.spec.ts,e2e/react-start/basic/tests/utils/isPreview.tsisPreviewutility (exports boolean fromprocess.env.MODE === 'preview'); tests append_previewsuffix to port/package name when preview mode is activee2e/solid-start/basic/package.jsonpreviewscript (vite preview), addedtest:e2e:preview, and updatedtest:e2eto include preview testse2e/solid-start/basic/playwright.config.tsisPreview, addedpreviewModeCommand, and append_previewsuffix to PORT whenisPreviewis true;getCommand()selects preview command accordinglye2e/solid-start/basic/tests/redirect.spec.ts,e2e/solid-start/basic/tests/utils/isPreview.tsisPreviewutility; tests append_previewsuffix to port/package name when preview mode is activepackages/start-plugin-core/src/output-directory.tsgetClientOutputDirectory,getServerOutputDirectory, and internalgetOutputDirectorynow accept `vite.UserConfigpackages/start-plugin-core/src/plugin.tspreviewServerPlugin()in core plugin array (placed before capture-bundle stage)packages/start-plugin-core/src/preview-server-plugin/plugin.tspreviewServerPlugin()that registers post-order middleware, lazily imports server build on first request, caches it, proxies requests viaserverBuild.fetch(), writes headers/status, sends Node responses, and forwards errors tonext()Sequence Diagram#
Estimated code review effort#
🎯 4 (Complex) | ⏱️ ~45 minutes
Areas requiring extra attention:
packages/start-plugin-core/src/preview-server-plugin/plugin.ts— concurrency on first-request dynamic import, correct path resolution, header handling, and error forwarding tonext().packages/start-plugin-core/src/plugin.ts— plugin insertion point relative to capture-bundle and other middleware.Possibly related PRs#
packages/start-plugin-core/src/plugin.tsand plugin wiring; likely directly related to plugin registration changes.Suggested labels#
ssr,package: react-start,package: solid-startSuggested reviewers#
Poem#
Pre-merge checks and finishing touches#
❌ Failed checks (1 warning)
@coderabbitai generate docstringsto improve docstring coverage.✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 4153eb68f6a4f788d99eb4d3fce3b1c8f2b739e9 and 5b7b4bf6dd5890b35ed0caaca4542a3b464f1ea6.
📒 Files selected for processing (2)
e2e/react-start/basic/package.json(1 hunks)e2e/solid-start/basic/package.json(1 hunks)🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share