Skip to content
Source
Sign inSign up
TanStack/router

fix: disable rsbuild server compression #7348

Mergedschiller-manuel(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/7348/headmerged by schiller-manuel(GitHub profile, opens in a new tab)

fixes #7344

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue with Server-Side Rendering response header handling to prevent data corruption during transmission.
    1. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core

    2. No actionable comments were generated in the recent review. 🎉

      ℹ️ Recent review info
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Pro

      Run ID: 270c32b8-a7d5-4f7e-b53c-988ff090b992

      📥 Commits

      Reviewing files that changed from the base of the PR and between bcefc84d7e83fc4fd97e75ee4b95a7726f17f1f0 and 042bbfef4a63f263ee434fc4569b4213c3ff4ae6.

      📒 Files selected for processing (1)
      • packages/start-plugin-core/src/rsbuild/plugin.ts

      📝 Walkthrough

      Walkthrough

      A bug fix that disables HTTP compression in the Rsbuild server configuration by setting compress: false. This prevents Rsbuild's compression layer from corrupting SSR response headers when Node.js writes headers using the writeHead object form.

      Changes

      SSR Header Corruption Fix

      Layer / File(s)Summary
      Server Configuration
      packages/start-plugin-core/src/rsbuild/plugin.ts
      Rsbuild server config now explicitly disables compression with compress: false to prevent header array corruption during SSR.

      Estimated code review effort

      🎯 1 (Trivial) | ⏱️ ~2 minutes

      Poem

      A header went walking, all twisted and strange, Compression had scrambled its numeric exchange. One line, one setting—the fix came so quick, compress: false was the medicinal trick! 🐰✨

      🚥 Pre-merge checks | ✅ 4 | ❌ 1

      ❌ Failed checks (1 warning)

      Check nameStatusExplanationResolution
      Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
      ✅ Passed checks (4 passed)
      Check nameStatusExplanation
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Title check✅ PassedThe title clearly and specifically describes the main change: disabling rsbuild server compression to fix malformed headers.
      Linked Issues check✅ PassedThe PR adds compress: false to rsbuild configuration, directly addressing the root cause of malformed headers reported in issue #7344.
      Out of Scope Changes check✅ PassedThe change is narrowly scoped to fixing the reported issue; only the rsbuild server compression setting was modified.
      ✏️ Tip: You can configure your own custom pre-merge checks in the settings.
      ✨ Finishing Touches
      📝 Generate docstrings
      • Create stacked PR
      • Commit on current branch
      🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Commit unit tests in branch `fix-7344`

      Comment `@coderabbitai help` to get the list of available commands and usage tips.
    3. View your CI Pipeline Execution ↗ for commit 042bbfef4a63f263ee434fc4569b4213c3ff4ae6

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...❌ Failed8m 29sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded53sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-05-05 20:10:40 UTC

    4. 🚀 Changeset Version Preview

      No changeset entries found. Merging this PR will not cause a version bump for any packages.

    5. Bundle Size Benchmarks

      • Commit: bcefc84d7e83
      • Measured at: 2026-05-05T20:03:01.768Z
      • Baseline source: history:056337ef02cc
      • Dashboard: bundle-size history
      ScenarioCurrent (gzip)Delta vs baselineRawBrotliTrend
      react-router.minimal87.15 KiB0 B (0.00%)273.94 KiB75.70 KiB▅▅▅▅▅▅▅▅▅▅▅
      react-router.full90.68 KiB0 B (0.00%)285.45 KiB78.71 KiB▅▅▅▅▅▅▅▅▅▅▅
      solid-router.minimal35.38 KiB0 B (0.00%)106.25 KiB31.81 KiB▅▅▅▅▅▅▅▅▅▅▅
      solid-router.full40.10 KiB0 B (0.00%)120.46 KiB36.04 KiB▅▅▅▅▅▅▅▅▅▅▅
      vue-router.minimal53.15 KiB0 B (0.00%)151.39 KiB47.73 KiB▅▅▅▅▅▅▅▅▅▅▅
      vue-router.full58.28 KiB0 B (0.00%)167.56 KiB52.18 KiB▅▅▅▅▅▅▅▅▅▅▅
      react-start.minimal101.76 KiB0 B (0.00%)322.10 KiB87.97 KiB▅▅▅▅▅▅▅▅▅▅▅
      react-start.full105.19 KiB0 B (0.00%)332.43 KiB90.96 KiB▅▅▅▅▅▅▅▅▅▅▅
      react-start.rsbuild.minimal99.33 KiB0 B (0.00%)316.47 KiB85.46 KiB▅▅▅▅▅▅▅▅▅▅▅
      react-start.rsbuild.full102.63 KiB0 B (0.00%)326.90 KiB88.28 KiB▅▅▅▅▅▅▅▅▅▅▅
      solid-start.minimal49.40 KiB0 B (0.00%)152.08 KiB43.60 KiB▅▅▅▅▅▅▅▅▅▅▅
      solid-start.full55.20 KiB0 B (0.00%)168.98 KiB48.51 KiB▅▅▅▅▅▅▅▅▅▅▅

      Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

    6. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/@tanstack/arktype-adapter@7348

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7348

      @tanstack/eslint-plugin-start

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7348

      @tanstack/history

      npm i https://pkg.pr.new/@tanstack/history@7348

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7348

      @tanstack/react-router

      npm i https://pkg.pr.new/@tanstack/react-router@7348

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/@tanstack/react-router-devtools@7348

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7348

      @tanstack/react-start

      npm i https://pkg.pr.new/@tanstack/react-start@7348

      @tanstack/react-start-client

      npm i https://pkg.pr.new/@tanstack/react-start-client@7348

      @tanstack/react-start-rsc

      npm i https://pkg.pr.new/@tanstack/react-start-rsc@7348

      @tanstack/react-start-server

      npm i https://pkg.pr.new/@tanstack/react-start-server@7348

      @tanstack/router-cli

      npm i https://pkg.pr.new/@tanstack/router-cli@7348

      @tanstack/router-core

      npm i https://pkg.pr.new/@tanstack/router-core@7348

      @tanstack/router-devtools

      npm i https://pkg.pr.new/@tanstack/router-devtools@7348

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/@tanstack/router-devtools-core@7348

      @tanstack/router-generator

      npm i https://pkg.pr.new/@tanstack/router-generator@7348

      @tanstack/router-plugin

      npm i https://pkg.pr.new/@tanstack/router-plugin@7348

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7348

      @tanstack/router-utils

      npm i https://pkg.pr.new/@tanstack/router-utils@7348

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7348

      @tanstack/solid-router

      npm i https://pkg.pr.new/@tanstack/solid-router@7348

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7348

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7348

      @tanstack/solid-start

      npm i https://pkg.pr.new/@tanstack/solid-start@7348

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/@tanstack/solid-start-client@7348

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/@tanstack/solid-start-server@7348

      @tanstack/start-client-core

      npm i https://pkg.pr.new/@tanstack/start-client-core@7348

      @tanstack/start-fn-stubs

      npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7348

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/@tanstack/start-plugin-core@7348

      @tanstack/start-server-core

      npm i https://pkg.pr.new/@tanstack/start-server-core@7348

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7348

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/@tanstack/start-storage-context@7348

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/@tanstack/valibot-adapter@7348

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7348

      @tanstack/vue-router

      npm i https://pkg.pr.new/@tanstack/vue-router@7348

      @tanstack/vue-router-devtools

      npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7348

      @tanstack/vue-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7348

      @tanstack/vue-start

      npm i https://pkg.pr.new/@tanstack/vue-start@7348

      @tanstack/vue-start-client

      npm i https://pkg.pr.new/@tanstack/vue-start-client@7348

      @tanstack/vue-start-server

      npm i https://pkg.pr.new/@tanstack/vue-start-server@7348

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/@tanstack/zod-adapter@7348

      commit: 042bbfe

    7. Nx Cloud has identified a flaky task in your failed CI:

      🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

      Nx Cloud View detailed reasoning in Nx Cloud ↗


      🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)
    8. Merging this PR will not alter performance

      ✅ 5 untouched benchmarks ⏩ 1 skipped benchmark1


      Comparing fix-7344 (042bbfe) with main (056337e)[^unexpected-base] Open in CodSpeed

      Footnotes

      1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

Sign in to join this conversation.