chore: migrate linting to Oxlint #8057
main fromchore/migrate-to-oxlint·opened Summary#
- replace the repository lint setup with a centralized, type-aware Oxlint configuration
- rename package and Nx lint targets from
test:eslinttotest:lint - remove obsolete package ESLint configs and translate existing disable directives to Oxlint rule IDs
- keep ESLint only where it is the product or integration under test, including the ESLint plugin e2e fixture
Performance#
Full uncached 40-project lint run, with task dependencies excluded for a like-for-like comparison:
- ESLint: 28.22s
- Oxlint: 9.05s
- 67.9% less wall time, or 3.12x faster
Validation#
- all 40
test:linttargets pass with zero errors - full unit suite passes for 34 projects and dependent tasks
- type tests pass
- formatting and
git diff --checkpass
Summary by CodeRabbit#
Chores
- Replaced the previous linting workflow with a unified, faster project-wide linting process.
- Standardized lint commands across packages, tests, CI, and development tasks.
- Expanded code quality checks for TypeScript, imports, React, browser compatibility, and correctness.
Documentation
- Updated contributor and development guidance with the new lint command.
- Refreshed workflow and verification instructions to reflect the current tooling.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-router
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-plugin
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-generator
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-utils
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-cli
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: history
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: eslint-plugin-router
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: valibot-adapter
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-devtools
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: zod-adapter
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-router
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: arktype-adapter
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-vite-plugin
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-start-server
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-start
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-start-client
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-start-client
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-start-server
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-devtools-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-router-devtools
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-start
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-router-devtools
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-server-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-client-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: virtual-file-routes
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-static-server-functions
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-storage-context
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-router-ssr-query
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-ssr-query-core
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: nitro-v2-vite-plugin
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: solid-router-ssr-query
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-router
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-router-devtools
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-router-ssr-query
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-start-client
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-fn-stubs
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-start
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: vue-start-server
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: react-start-rsc
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: eslint-plugin-start
🚀 Changeset Version Preview#
4 package(s) bumped directly, 19 bumped as dependents.
🟩 Patch bumps#
Package Version Reason @tanstack/react-router1.170.29 → 1.170.30 Changeset @tanstack/router-core1.171.24 → 1.171.25 Changeset @tanstack/solid-router1.170.27 → 1.170.28 Changeset @tanstack/vue-router1.170.26 → 1.170.27 Changeset @tanstack/react-start1.168.46 → 1.168.47 Dependent @tanstack/react-start-client1.168.27 → 1.168.28 Dependent @tanstack/react-start-rsc0.1.45 → 0.1.46 Dependent @tanstack/react-start-server1.167.34 → 1.167.35 Dependent @tanstack/router-cli1.167.30 → 1.167.31 Dependent @tanstack/router-generator1.167.30 → 1.167.31 Dependent @tanstack/router-plugin1.168.32 → 1.168.33 Dependent @tanstack/router-vite-plugin1.167.32 → 1.167.33 Dependent @tanstack/solid-start1.168.44 → 1.168.45 Dependent @tanstack/solid-start-client1.168.26 → 1.168.27 Dependent @tanstack/solid-start-server1.167.33 → 1.167.34 Dependent @tanstack/start-client-core1.170.24 → 1.170.25 Dependent @tanstack/start-plugin-core1.171.36 → 1.171.37 Dependent @tanstack/start-server-core1.169.28 → 1.169.29 Dependent @tanstack/start-static-server-functions1.167.29 → 1.167.30 Dependent @tanstack/start-storage-context1.167.26 → 1.167.27 Dependent @tanstack/vue-start1.168.43 → 1.168.44 Dependent @tanstack/vue-start-client1.167.29 → 1.167.30 Dependent @tanstack/vue-start-server1.167.33 → 1.167.34 Dependent Review the following changes in direct dependencies. Learn more about Socket for GitHub.
Diff Package Supply Chain
SecurityVulnerability Quality Maintenance License oxlint@1.78.0 oxlint-tsgolint@7.0.2001 No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID:
b67b20a0-db53-4378-b798-a40c35bc1151📥 Commits
Reviewing files that changed from the base of the PR and between 63d2cc9155ff5374112f7d067d0b278bafeb8486 and 0266c250933a1e60845207581f9ec60e62ebd156.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (259)
.oxlintrc.jsonAGENTS.mdCONTRIBUTING.mde2e/e2e-utils/eslint.config.jse2e/e2e-utils/package.jsone2e/e2e-utils/src/hmrFileEditor.tse2e/eslint-plugin-start/README.mde2e/eslint-plugin-start/package.jsoneslint.config.jsnx.jsonpackage.jsonpackages/arktype-adapter/eslint.config.jspackages/arktype-adapter/package.jsonpackages/eslint-plugin-router/eslint.config.jspackages/eslint-plugin-router/package.jsonpackages/eslint-plugin-router/tsconfig.jsonpackages/eslint-plugin-start/eslint.config.jspackages/eslint-plugin-start/package.jsonpackages/eslint-plugin-start/src/rules/no-async-client-component/context-analyzer.tspackages/eslint-plugin-start/src/rules/no-async-client-component/no-async-client-component.rule.tspackages/eslint-plugin-start/src/rules/no-async-client-component/render-graph-builder.tspackages/eslint-plugin-start/src/rules/no-client-code-in-server-component/constants.tspackages/eslint-plugin-start/src/rules/no-client-code-in-server-component/no-client-code-in-server-component.rule.tspackages/eslint-plugin-start/src/rules/no-client-code-in-server-component/transitive-analyzer.tspackages/eslint-plugin-start/src/rules/no-client-code-in-server-component/violation-detector.tspackages/eslint-plugin-start/src/shared/use-client-resolver.tspackages/eslint-plugin-start/tsconfig.jsonpackages/history/eslint.config.jspackages/history/package.jsonpackages/history/src/index.tspackages/nitro-v2-vite-plugin/eslint.config.jspackages/nitro-v2-vite-plugin/package.jsonpackages/react-router-devtools/eslint.config.jspackages/react-router-devtools/package.jsonpackages/react-router-ssr-query/eslint.config.jspackages/react-router-ssr-query/package.jsonpackages/react-router/eslint.config.tspackages/react-router/package.jsonpackages/react-router/src/Asset.tsxpackages/react-router/src/Match.tsxpackages/react-router/src/Matches.tsxpackages/react-router/src/Scripts.tsxpackages/react-router/src/Transitioner.tsxpackages/react-router/src/fileRoute.tspackages/react-router/src/headContentUtils.tsxpackages/react-router/src/link.tsxpackages/react-router/src/not-found.tsxpackages/react-router/src/route.tsxpackages/react-router/src/ssr/renderRouterToStream.tsxpackages/react-router/src/useBlocker.tsxpackages/react-router/src/useCanGoBack.tspackages/react-router/src/useLocation.tsxpackages/react-router/src/useMatch.tsxpackages/react-router/src/useRouterState.tsxpackages/react-router/tests/blocker.test.tsxpackages/react-router/tests/link.test-d.tsxpackages/react-router/tests/link.test.tsxpackages/react-router/tests/navigate.test.tsxpackages/react-router/tests/renderRouterToStream.test.tsxpackages/react-router/tests/route.test-d.tsxpackages/react-router/tests/router.test-d.tsxpackages/react-router/tests/useBlocker.test-d.tsxpackages/react-router/tests/useLoaderData.test-d.tsxpackages/react-router/tests/useMatch.test-d.tsxpackages/react-router/tests/useParams.test-d.tsxpackages/react-router/tests/useRouteContext.test-d.tsxpackages/react-router/tests/useSearch.test-d.tsxpackages/react-router/tsconfig.jsonpackages/react-start-client/eslint.config.jspackages/react-start-client/package.jsonpackages/react-start-client/src/GenericHydrate.tsxpackages/react-start-client/src/Hydrate.tsxpackages/react-start-client/src/hydration/load.tsxpackages/react-start-client/src/hydration/never.tsxpackages/react-start-client/src/hydration/visible.tsxpackages/react-start-rsc/eslint.config.jspackages/react-start-rsc/package.jsonpackages/react-start-rsc/src/CompositeComponent.tsxpackages/react-start-rsc/src/ReplayableStream.tspackages/react-start-rsc/src/RscNodeRenderer.tsxpackages/react-start-rsc/src/ServerComponentTypes.tspackages/react-start-rsc/src/awaitLazyElements.tspackages/react-start-rsc/src/createCompositeComponent.tspackages/react-start-rsc/src/createRscProxy.tsxpackages/react-start-rsc/src/createServerComponentFromStream.tspackages/react-start-rsc/src/plugin/rscCssTransform.tspackages/react-start-rsc/src/plugin/vite.tspackages/react-start-rsc/src/rsbuild/ssr-decode.tspackages/react-start-rsc/src/serialization.server.tspackages/react-start-rsc/src/slotUsageSanitizer.tspackages/react-start-server/eslint.config.jspackages/react-start-server/package.jsonpackages/react-start/eslint.config.jspackages/react-start/package.jsonpackages/router-cli/eslint.config.jspackages/router-cli/package.jsonpackages/router-core/eslint.config.jspackages/router-core/package.jsonpackages/router-core/src/lru-cache.tspackages/router-core/src/new-process-route-tree.tspackages/router-core/src/not-found.tspackages/router-core/src/path.tspackages/router-core/src/qss.tspackages/router-core/src/router.tspackages/router-core/src/scroll-restoration-inline.tspackages/router-core/src/ssr/headers.tspackages/router-core/src/ssr/serializer/RawStream.tspackages/router-core/src/ssr/ssr-server.tspackages/router-core/src/ssr/transformStreamWithRouter.tspackages/router-core/src/utils.tspackages/router-devtools-core/eslint.config.jspackages/router-devtools-core/package.jsonpackages/router-devtools-core/src/AgeTicker.tsxpackages/router-devtools-core/src/BaseTanStackRouterDevtoolsPanel.tsxpackages/router-devtools-core/src/Explorer.tsxpackages/router-devtools-core/src/FloatingTanStackRouterDevtools.tsxpackages/router-devtools-core/src/useLocalStorage.tspackages/router-devtools-core/src/useMediaQuery.tspackages/router-devtools-core/src/utils.tsxpackages/router-devtools/eslint.config.jspackages/router-devtools/package.jsonpackages/router-generator/eslint.config.jspackages/router-generator/package.jsonpackages/router-generator/src/generator.tspackages/router-generator/src/logger.tspackages/router-generator/src/transform/transform.tspackages/router-generator/src/utils.tspackages/router-generator/tests/generator/types-disabled/routes/__root.tsxpackages/router-generator/tests/generator/types-disabled/routes/index.tsxpackages/router-generator/tests/generator/types-disabled/routes/posts.tsxpackages/router-generator/tests/generator/types-disabled/routes/posts/$postId.tsxpackages/router-generator/tests/generator/types-disabled/routes/users.$userId.tsxpackages/router-plugin/eslint.config.jspackages/router-plugin/package.jsonpackages/router-plugin/src/core/code-splitter/compilers.tspackages/router-plugin/src/core/router-code-splitter-plugin.tspackages/router-plugin/src/core/router-hmr-plugin.tspackages/router-ssr-query-core/eslint.config.jspackages/router-ssr-query-core/package.jsonpackages/router-ssr-query-core/src/index.tspackages/router-utils/eslint.config.jspackages/router-utils/package.jsonpackages/router-utils/src/compiler-helpers.tspackages/router-utils/src/logger.tspackages/router-vite-plugin/eslint.config.jspackages/router-vite-plugin/package.jsonpackages/solid-router-devtools/eslint.config.jspackages/solid-router-devtools/package.jsonpackages/solid-router-ssr-query/eslint.config.jspackages/solid-router-ssr-query/package.jsonpackages/solid-router/eslint.config.tspackages/solid-router/package.jsonpackages/solid-router/src/Asset.tsxpackages/solid-router/src/Matches.tsxpackages/solid-router/src/fileRoute.tspackages/solid-router/src/link.tsxpackages/solid-router/src/ssr/renderRouterToStream.tsxpackages/solid-router/src/useBlocker.tsxpackages/solid-router/src/useLocation.tsxpackages/solid-router/src/useMatch.tsxpackages/solid-router/src/useRouterState.tsxpackages/solid-router/tests/blocker.test.tsxpackages/solid-router/tests/link.test-d.tsxpackages/solid-router/tests/link.test.tsxpackages/solid-router/tests/navigate.test.tsxpackages/solid-router/tests/renderRouterToStream.test.tsxpackages/solid-router/tsconfig.jsonpackages/solid-start-client/eslint.config.jspackages/solid-start-client/package.jsonpackages/solid-start-client/src/GenericHydrate.tsxpackages/solid-start-server/eslint.config.jspackages/solid-start-server/package.jsonpackages/solid-start/eslint.config.jspackages/solid-start/package.jsonpackages/start-client-core/eslint.config.jspackages/start-client-core/package.jsonpackages/start-client-core/src/client-rpc/frame-decoder.tspackages/start-client-core/src/client-rpc/serverFnFetcher.tspackages/start-client-core/src/client/ServerFunctionSerializationAdapter.tspackages/start-client-core/src/createCsrfMiddleware.tspackages/start-client-core/src/createServerFn.tspackages/start-client-core/src/hydration/interaction.tspackages/start-client-core/src/hydration/media.tspackages/start-client-core/src/hydration/runtime.tspackages/start-client-core/src/safeObjectMerge.tspackages/start-client-core/src/tests/createServerFn.test-d.tspackages/start-client-core/src/tests/createServerMiddleware.test-d.tspackages/start-fn-stubs/eslint.config.jspackages/start-fn-stubs/package.jsonpackages/start-plugin-core/eslint.config.jspackages/start-plugin-core/package.jsonpackages/start-plugin-core/src/hydrate-when-transform.tspackages/start-plugin-core/src/import-protection/analysis.tspackages/start-plugin-core/src/import-protection/extensionlessAbsoluteIdResolver.tspackages/start-plugin-core/src/import-protection/rewrite.tspackages/start-plugin-core/src/import-protection/sourceLocation.tspackages/start-plugin-core/src/import-protection/trace.tspackages/start-plugin-core/src/import-protection/utils.tspackages/start-plugin-core/src/import-protection/virtualModules.tspackages/start-plugin-core/src/prerender.tspackages/start-plugin-core/src/rsbuild/import-protection.tspackages/start-plugin-core/src/rsbuild/normalized-client-build.tspackages/start-plugin-core/src/rsbuild/plugin.tspackages/start-plugin-core/src/rsbuild/swc-rsc.tspackages/start-plugin-core/src/start-compiler/compiler.tspackages/start-plugin-core/src/start-compiler/config.tspackages/start-plugin-core/src/start-compiler/handleCreateServerFn.tspackages/start-plugin-core/src/start-compiler/handleEnvOnly.tspackages/start-plugin-core/src/start-manifest-plugin/inlineCss.tspackages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.tspackages/start-plugin-core/src/start-router-plugin/generator-plugins/prerender-routes-plugin.tspackages/start-plugin-core/src/vite/dev-server-plugin/dev-styles.tspackages/start-plugin-core/src/vite/import-protection-plugin/plugin.tspackages/start-plugin-core/src/vite/start-compiler-plugin/plugin.tspackages/start-plugin-core/src/vite/start-manifest-plugin/normalized-client-build.tspackages/start-server-core/eslint.config.jspackages/start-server-core/package.jsonpackages/start-server-core/src/createStartHandler.tspackages/start-server-core/src/early-hints.tspackages/start-server-core/src/finalManifest.tspackages/start-server-core/src/frame-protocol.tspackages/start-server-core/src/serializer/ServerFunctionSerializationAdapter.tspackages/start-server-core/src/transformAssetUrls.tspackages/start-static-server-functions/eslint.config.jspackages/start-static-server-functions/package.jsonpackages/start-storage-context/eslint.config.jspackages/start-storage-context/package.jsonpackages/valibot-adapter/eslint.config.jspackages/valibot-adapter/package.jsonpackages/virtual-file-routes/eslint.config.jspackages/virtual-file-routes/package.jsonpackages/vue-router-devtools/eslint.config.jspackages/vue-router-devtools/package.jsonpackages/vue-router-ssr-query/eslint.config.tspackages/vue-router-ssr-query/package.jsonpackages/vue-router-ssr-query/tsconfig.jsonpackages/vue-router/eslint.config.tspackages/vue-router/package.jsonpackages/vue-router/src/Asset.tsxpackages/vue-router/src/fileRoute.tspackages/vue-router/src/lazyRouteComponent.tsxpackages/vue-router/src/link.tsxpackages/vue-router/src/useBlocker.tsxpackages/vue-router/src/useRouterState.tsxpackages/vue-router/tests/blocker.test.tsxpackages/vue-router/tests/link.test-d.tsxpackages/vue-router/tests/link.test.tsxpackages/vue-router/tests/navigate.test.tsxpackages/vue-router/tests/renderRouterToStream.test.tsxpackages/vue-router/tsconfig.jsonpackages/vue-start-client/eslint.config.tspackages/vue-start-client/package.jsonpackages/vue-start-client/src/hydrateStart.tspackages/vue-start-server/eslint.config.tspackages/vue-start-server/package.jsonpackages/vue-start/eslint.config.tspackages/zod-adapter/eslint.config.jspackages/zod-adapter/package.jsonpnpm-workspace.yaml
💤 Files with no reviewable changes (47)
- packages/vue-router-ssr-query/eslint.config.ts
- packages/react-router-ssr-query/eslint.config.js
- packages/react-start-client/eslint.config.js
- pnpm-workspace.yaml
- packages/solid-router-ssr-query/eslint.config.js
- packages/router-devtools/eslint.config.js
- packages/start-fn-stubs/eslint.config.js
- packages/nitro-v2-vite-plugin/eslint.config.js
- packages/eslint-plugin-router/eslint.config.js
- packages/router-generator/eslint.config.js
- packages/solid-router-devtools/eslint.config.js
- packages/solid-start/eslint.config.js
- packages/react-start/eslint.config.js
- packages/vue-router-devtools/eslint.config.js
- packages/arktype-adapter/eslint.config.js
- packages/vue-router/eslint.config.ts
- packages/solid-start-client/eslint.config.js
- packages/router-core/eslint.config.js
- packages/start-storage-context/eslint.config.js
- packages/react-start-server/eslint.config.js
- eslint.config.js
- packages/valibot-adapter/eslint.config.js
- packages/vue-start-server/eslint.config.ts
- packages/vue-start/eslint.config.ts
- packages/router-plugin/eslint.config.js
- packages/router-vite-plugin/eslint.config.js
- packages/history/eslint.config.js
- packages/start-server-core/eslint.config.js
- packages/react-router-devtools/eslint.config.js
- packages/router-cli/eslint.config.js
- e2e/e2e-utils/eslint.config.js
- packages/router-devtools-core/eslint.config.js
- packages/solid-start/package.json
- packages/start-plugin-core/eslint.config.js
- packages/react-start-rsc/eslint.config.js
- packages/virtual-file-routes/eslint.config.js
- packages/vue-start-client/eslint.config.ts
- packages/react-start/package.json
- packages/react-router/eslint.config.ts
- packages/zod-adapter/eslint.config.js
- packages/start-static-server-functions/eslint.config.js
- packages/solid-router/eslint.config.ts
- packages/start-client-core/eslint.config.js
- packages/eslint-plugin-start/eslint.config.js
- packages/router-ssr-query-core/eslint.config.js
- packages/solid-start-server/eslint.config.js
- packages/router-utils/eslint.config.js
🚧 Files skipped from review as they are similar to previous changes (91)
- packages/react-router/src/Scripts.tsx
- CONTRIBUTING.md
- packages/start-fn-stubs/package.json
- packages/zod-adapter/package.json
- packages/valibot-adapter/package.json
- packages/vue-router/package.json
- packages/router-devtools-core/src/useLocalStorage.ts
- packages/solid-start-client/package.json
- packages/router-plugin/package.json
- packages/solid-router-devtools/package.json
- packages/react-router/src/useCanGoBack.ts
- packages/router-core/package.json
- packages/vue-router-devtools/package.json
- e2e/eslint-plugin-start/package.json
- packages/react-router/tests/useParams.test-d.tsx
- packages/react-router/tests/router.test-d.tsx
- packages/router-vite-plugin/package.json
- packages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.ts
- packages/react-router/src/not-found.tsx
- packages/react-start-client/src/hydration/visible.tsx
- packages/start-client-core/package.json
- packages/react-router/src/Match.tsx
- packages/arktype-adapter/package.json
- packages/router-generator/tests/generator/types-disabled/routes/__root.tsx
- packages/eslint-plugin-router/tsconfig.json
- packages/react-router/src/headContentUtils.tsx
- packages/history/package.json
- packages/vue-router-ssr-query/package.json
- packages/virtual-file-routes/package.json
- packages/react-router/tests/useBlocker.test-d.tsx
- packages/router-generator/tests/generator/types-disabled/routes/users.$userId.tsx
- packages/react-router/package.json
- packages/eslint-plugin-router/package.json
- packages/router-generator/tests/generator/types-disabled/routes/posts/$postId.tsx
- packages/react-start-rsc/src/createServerComponentFromStream.ts
- packages/eslint-plugin-start/package.json
- packages/start-server-core/package.json
- packages/nitro-v2-vite-plugin/package.json
- packages/react-router-devtools/package.json
- packages/react-router/src/useLocation.tsx
- packages/router-devtools-core/package.json
- packages/react-router/tests/useMatch.test-d.tsx
- packages/react-router/src/Matches.tsx
- packages/react-start-client/src/hydration/never.tsx
- packages/router-utils/package.json
- packages/router-ssr-query-core/package.json
- packages/react-start-rsc/src/ReplayableStream.ts
- packages/solid-router/src/fileRoute.ts
- packages/router-devtools-core/src/useMediaQuery.ts
- package.json
- packages/solid-router/package.json
- packages/react-start-client/src/Hydrate.tsx
- packages/vue-start-server/package.json
- packages/start-static-server-functions/package.json
- packages/react-router/src/useMatch.tsx
- packages/router-cli/package.json
- packages/vue-router/src/fileRoute.ts
- packages/react-router/tests/useSearch.test-d.tsx
- AGENTS.md
- e2e/e2e-utils/package.json
- packages/react-start-server/package.json
- packages/start-storage-context/package.json
- packages/eslint-plugin-start/tsconfig.json
- packages/start-client-core/src/hydration/runtime.ts
- .oxlintrc.json
- packages/react-router/src/Transitioner.tsx
- packages/solid-router-ssr-query/package.json
- nx.json
- packages/router-devtools-core/src/Explorer.tsx
- packages/solid-start-server/package.json
- packages/react-router/tests/useRouteContext.test-d.tsx
- packages/router-generator/package.json
- packages/vue-start-client/package.json
- packages/react-router/tests/useLoaderData.test-d.tsx
- packages/react-router/src/useRouterState.tsx
- packages/react-router-ssr-query/package.json
- packages/react-router/tests/route.test-d.tsx
- packages/router-generator/tests/generator/types-disabled/routes/index.tsx
- packages/react-router/src/link.tsx
- packages/react-router/src/fileRoute.ts
- packages/start-client-core/src/client-rpc/serverFnFetcher.ts
- packages/react-start-rsc/package.json
- packages/router-devtools-core/src/FloatingTanStackRouterDevtools.tsx
- packages/start-client-core/src/client-rpc/frame-decoder.ts
- packages/solid-start-client/src/GenericHydrate.tsx
- packages/router-core/src/utils.ts
- packages/react-start-client/src/GenericHydrate.tsx
- packages/react-router/src/route.tsx
- packages/router-generator/tests/generator/types-disabled/routes/posts.tsx
- packages/start-plugin-core/package.json
- packages/router-generator/src/utils.ts
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.
📝 Walkthrough
Walkthrough#
The pull request replaces repository ESLint configuration with centralized Oxlint configuration, updates Nx and package lint commands, removes package-specific ESLint files, and renames suppression directives for Oxlint rule namespaces.
Changes#
Oxlint migration
Layer / File(s) Summary Central lint configuration
.oxlintrc.json,package.jsonAdds Oxlint plugins, environments, type-aware options, correctness rules, React rules, test overrides, and React Server Components import restrictions. Adds Oxlint dependencies and removes ESLint-specific dependencies. Task and package integration
nx.json,package.json,packages/*/package.json,e2e/*/package.json,AGENTS.md,CONTRIBUTING.mdRenames lint targets from test:eslinttotest:lintand changes commands from ESLint to Oxlint. Nx inputs now track.oxlintrc.json.Configuration cleanup and directives
eslint.config.js,packages/*/eslint.config.*,packages/*/src/*,packages/*/tests/*Removes package-specific ESLint configurations and updates suppression directives to react,typescript,unused-vars, and related Oxlint namespaces.TypeScript project scope
packages/eslint-plugin-*/tsconfig.json,packages/*/tests/*Removes deleted ESLint configuration files from TypeScript includes and updates lint suppressions in type tests and generated-route fixtures. Estimated code review effort: 3 (Moderate) | ~25 minutes
Merge Risk: ⚪ Minimal · up to
0266cThis PR centralizes linting on Oxlint and renames lint targets while preserving the reported test and validation results; no actionable merge-blocking risk remains beyond normal checks and review.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)#
Check name Status Explanation Resolution Docstring Coverage ⚠️ Warning Docstring coverage is 40.38% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold. ✅ Passed checks (4 passed)
Check name Status Explanation Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled. Title check ✅ Passed The title clearly and concisely summarizes the main change: migrating repository linting from ESLint to Oxlint. Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. ✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch `chore/migrate-to-oxlint`
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment `@coderabbitai help` to get the list of available commands.Bundle Size Benchmarks#
This pull request does not affect bundle size in any measured scenario.
More templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-router-react-example-basic-authjs
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-rsbuild
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-example-rscs
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-vue-example-basic-jsx
- tanstack-router-vue-example-basic-file-based-jsx
- tanstack-router-vue-example-basic-file-based-sfc
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- @tanstack/router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-authjs
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8057@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8057@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8057@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8057@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8057@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8057@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8057@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8057@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8057@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8057@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8057@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8057@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8057@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8057@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8057@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8057@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8057@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8057@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8057@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8057@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8057@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8057@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8057@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8057@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8057@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8057@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8057@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8057@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8057@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8057@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8057@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8057@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8057@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8057@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8057@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8057@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8057@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8057@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8057@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8057@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8057@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8057commit:
0266c25Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In @.oxlintrc.json: - Line 26: Update the rules configuration in .oxlintrc.json to enable the curly rule with error severity and the all option, enforcing braces for every control statement.🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID:
10c5c68f-23f9-4647-9af7-99b094a0286c📥 Commits
Reviewing files that changed from the base of the PR and between 38485038c52ff898777cabeeeb2eaaa29c93f789 and dee31e51091566f351e2357b3c05d5985123a49a.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (141)
.oxlintrc.jsonAGENTS.mdCONTRIBUTING.mde2e/e2e-utils/eslint.config.jse2e/e2e-utils/package.jsone2e/eslint-plugin-start/package.jsoneslint.config.jsnx.jsonpackage.jsonpackages/arktype-adapter/eslint.config.jspackages/arktype-adapter/package.jsonpackages/eslint-plugin-router/eslint.config.jspackages/eslint-plugin-router/package.jsonpackages/eslint-plugin-router/tsconfig.jsonpackages/eslint-plugin-start/eslint.config.jspackages/eslint-plugin-start/package.jsonpackages/eslint-plugin-start/src/rules/no-async-client-component/no-async-client-component.rule.tspackages/eslint-plugin-start/tsconfig.jsonpackages/history/eslint.config.jspackages/history/package.jsonpackages/nitro-v2-vite-plugin/eslint.config.jspackages/nitro-v2-vite-plugin/package.jsonpackages/react-router-devtools/eslint.config.jspackages/react-router-devtools/package.jsonpackages/react-router-ssr-query/eslint.config.jspackages/react-router-ssr-query/package.jsonpackages/react-router/eslint.config.tspackages/react-router/package.jsonpackages/react-router/src/Match.tsxpackages/react-router/src/Matches.tsxpackages/react-router/src/Scripts.tsxpackages/react-router/src/Transitioner.tsxpackages/react-router/src/fileRoute.tspackages/react-router/src/headContentUtils.tsxpackages/react-router/src/link.tsxpackages/react-router/src/not-found.tsxpackages/react-router/src/route.tsxpackages/react-router/src/useCanGoBack.tspackages/react-router/src/useLocation.tsxpackages/react-router/src/useMatch.tsxpackages/react-router/src/useRouterState.tsxpackages/react-router/tests/route.test-d.tsxpackages/react-router/tests/router.test-d.tsxpackages/react-router/tests/useBlocker.test-d.tsxpackages/react-router/tests/useLoaderData.test-d.tsxpackages/react-router/tests/useMatch.test-d.tsxpackages/react-router/tests/useParams.test-d.tsxpackages/react-router/tests/useRouteContext.test-d.tsxpackages/react-router/tests/useSearch.test-d.tsxpackages/react-start-client/eslint.config.jspackages/react-start-client/package.jsonpackages/react-start-client/src/GenericHydrate.tsxpackages/react-start-client/src/Hydrate.tsxpackages/react-start-client/src/hydration/never.tsxpackages/react-start-client/src/hydration/visible.tsxpackages/react-start-rsc/eslint.config.jspackages/react-start-rsc/package.jsonpackages/react-start-rsc/src/ReplayableStream.tspackages/react-start-rsc/src/createServerComponentFromStream.tspackages/react-start-server/eslint.config.jspackages/react-start-server/package.jsonpackages/react-start/eslint.config.jspackages/router-cli/eslint.config.jspackages/router-cli/package.jsonpackages/router-core/eslint.config.jspackages/router-core/package.jsonpackages/router-core/src/utils.tspackages/router-devtools-core/eslint.config.jspackages/router-devtools-core/package.jsonpackages/router-devtools-core/src/BaseTanStackRouterDevtoolsPanel.tsxpackages/router-devtools-core/src/Explorer.tsxpackages/router-devtools-core/src/FloatingTanStackRouterDevtools.tsxpackages/router-devtools-core/src/useLocalStorage.tspackages/router-devtools-core/src/useMediaQuery.tspackages/router-devtools-core/src/utils.tsxpackages/router-devtools/eslint.config.jspackages/router-devtools/package.jsonpackages/router-generator/eslint.config.jspackages/router-generator/package.jsonpackages/router-generator/src/utils.tspackages/router-generator/tests/generator/types-disabled/routes/__root.tsxpackages/router-generator/tests/generator/types-disabled/routes/index.tsxpackages/router-generator/tests/generator/types-disabled/routes/posts.tsxpackages/router-generator/tests/generator/types-disabled/routes/posts/$postId.tsxpackages/router-generator/tests/generator/types-disabled/routes/users.$userId.tsxpackages/router-plugin/eslint.config.jspackages/router-plugin/package.jsonpackages/router-ssr-query-core/eslint.config.jspackages/router-ssr-query-core/package.jsonpackages/router-utils/eslint.config.jspackages/router-utils/package.jsonpackages/router-vite-plugin/eslint.config.jspackages/router-vite-plugin/package.jsonpackages/solid-router-devtools/eslint.config.jspackages/solid-router-devtools/package.jsonpackages/solid-router-ssr-query/eslint.config.jspackages/solid-router-ssr-query/package.jsonpackages/solid-router/eslint.config.tspackages/solid-router/package.jsonpackages/solid-router/src/fileRoute.tspackages/solid-start-client/eslint.config.jspackages/solid-start-client/package.jsonpackages/solid-start-client/src/GenericHydrate.tsxpackages/solid-start-server/eslint.config.jspackages/solid-start-server/package.jsonpackages/solid-start/eslint.config.jspackages/start-client-core/eslint.config.jspackages/start-client-core/package.jsonpackages/start-client-core/src/client-rpc/frame-decoder.tspackages/start-client-core/src/client-rpc/serverFnFetcher.tspackages/start-client-core/src/hydration/runtime.tspackages/start-fn-stubs/eslint.config.jspackages/start-fn-stubs/package.jsonpackages/start-plugin-core/eslint.config.jspackages/start-plugin-core/package.jsonpackages/start-plugin-core/src/start-compiler/compiler.tspackages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.tspackages/start-server-core/eslint.config.jspackages/start-server-core/package.jsonpackages/start-static-server-functions/eslint.config.jspackages/start-static-server-functions/package.jsonpackages/start-storage-context/eslint.config.jspackages/start-storage-context/package.jsonpackages/valibot-adapter/eslint.config.jspackages/valibot-adapter/package.jsonpackages/virtual-file-routes/eslint.config.jspackages/virtual-file-routes/package.jsonpackages/vue-router-devtools/eslint.config.jspackages/vue-router-devtools/package.jsonpackages/vue-router-ssr-query/eslint.config.tspackages/vue-router-ssr-query/package.jsonpackages/vue-router/eslint.config.tspackages/vue-router/package.jsonpackages/vue-router/src/fileRoute.tspackages/vue-start-client/eslint.config.tspackages/vue-start-client/package.jsonpackages/vue-start-server/eslint.config.tspackages/vue-start-server/package.jsonpackages/vue-start/eslint.config.tspackages/zod-adapter/eslint.config.jspackages/zod-adapter/package.json
💤 Files with no reviewable changes (44)
- packages/solid-router-ssr-query/eslint.config.js
- packages/router-generator/eslint.config.js
- packages/vue-start/eslint.config.ts
- packages/router-core/eslint.config.js
- eslint.config.js
- packages/router-ssr-query-core/eslint.config.js
- packages/start-server-core/eslint.config.js
- packages/start-fn-stubs/eslint.config.js
- packages/zod-adapter/eslint.config.js
- packages/virtual-file-routes/eslint.config.js
- packages/react-router-devtools/eslint.config.js
- packages/history/eslint.config.js
- packages/start-client-core/eslint.config.js
- packages/router-devtools/eslint.config.js
- packages/eslint-plugin-router/eslint.config.js
- packages/router-devtools-core/eslint.config.js
- e2e/e2e-utils/eslint.config.js
- packages/react-start-rsc/eslint.config.js
- packages/arktype-adapter/eslint.config.js
- packages/router-utils/eslint.config.js
- packages/router-vite-plugin/eslint.config.js
- packages/start-storage-context/eslint.config.js
- packages/solid-start/eslint.config.js
- packages/solid-router-devtools/eslint.config.js
- packages/vue-router-ssr-query/eslint.config.ts
- packages/solid-router/eslint.config.ts
- packages/vue-start-server/eslint.config.ts
- packages/vue-start-client/eslint.config.ts
- packages/nitro-v2-vite-plugin/eslint.config.js
- packages/start-plugin-core/eslint.config.js
- packages/valibot-adapter/eslint.config.js
- packages/eslint-plugin-start/eslint.config.js
- packages/vue-router-devtools/eslint.config.js
- packages/start-static-server-functions/eslint.config.js
- packages/router-cli/eslint.config.js
- packages/react-router-ssr-query/eslint.config.js
- packages/vue-router/eslint.config.ts
- packages/solid-start-client/eslint.config.js
- packages/react-router/eslint.config.ts
- packages/router-plugin/eslint.config.js
- packages/react-start/eslint.config.js
- packages/react-start-client/eslint.config.js
- packages/solid-start-server/eslint.config.js
- packages/react-start-server/eslint.config.js
@@ -0,0 +6,21 @@6+ "plugins": ["eslint", "typescript", "import", "unicorn", "react"],7+ "env": {8+ "browser": true,9+ "builtin": true,10+ "es2020": true11+ },12+ "ignorePatterns": [13+ "**/.nx/**",14+ "**/.svelte-kit/**",15+ "**/build/**",16+ "**/coverage/**",17+ "**/dist/**",18+ "**/snap/**",19+ "**/vite.config.*.timestamp-*.*",20+ "packages/{react-router,solid-router,vue-router,vue-start}/bin/**"21+ ],22+ "options": {23+ "typeAware": true,24+ "respectEslintDisableDirectives": true25+ },26+ "rules": {📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/sh set -eu printf '%s\n' '--- .oxlintrc.json ---' cat -n .oxlintrc.json | sed -n '1,150p' printf '%s\n' '--- repository references to curly and Oxlint configuration ---' rg -n --hidden -g '!node_modules' -g '!dist' -g '!build' \ '"curly"|curly|oxlint|oxlintrc' . | sed -n '1,240p' printf '%s\n' '--- local Oxlint metadata, if present ---' find . -maxdepth 3 \( -iname '*oxlint*' -o -name 'package.json' \) -type f -print | sed -n '1,120p'Repository: TanStack/router
Length of output: 21764
🌐 Web query:
Oxlint curly rule support configuration schema💡 Result:
In Oxlint, the curly rule is configured using an array format that accepts up to two elements, mirroring the traditional ESLint configuration style [1][2]. It does not support a single configuration object with named properties [3]. The configuration schema for the curly rule is as follows: 1. The first element (required) is the enforcement type, which must be one of: "all", "multi", "multi-line", or "multi-or-nest" [1][2]. 2. The second element (optional) accepts the string "consistent", which enforces consistent brace usage within if-else chains [1][2]. Example configurations in your.oxlintrc.json or oxlint.config.ts file: // Require braces for multi-statement blocks "rules": { "curly": ["error", "multi"] } // Require braces for multi-line blocks, with consistent usage in if-else chains "rules": { "curly": ["error", "multi-line", "consistent"] } Oxlint maintains its own rule implementations in Rust [4][5], and the curly rule's behavior and accepted configuration options are defined by the underlying native implementation, not by passing a configuration object [2][3]. If you encounter documentation or suggestions indicating that a configuration object (e.g., { "curlyType": "..." }) is supported, please note that this is incorrect and such configurations will not function as expected [3].
Citations:
- 1: https://oxc.rs/docs/guide/usage/linter/rules/eslint/curly
- 2: https://github.com/oxc-project/oxc/blob/7b80010b91591903b5f89a125193e2a6eda8e893/crates/oxc_linter/src/rules/eslint/curly.rs
- 3: https://github.com/oxc-project/oxc/issues/18661
- 4: https://oxc.rs/docs/guide/usage/linter/rules.html
- 5: https://oxc.rs/blog/2026-03-11-oxlint-js-plugins-alpha.html
🏁 Script executed:
#!/bin/sh set -eu repo='oxc-project/oxc' tag='oxlint_v1.78.0' printf '%s\n' '--- exact-version curly rule source ---' curl -fsSL "https://raw.githubusercontent.com/${repo}/${tag}/crates/oxc_linter/src/rules/eslint/curly.rs" \ | sed -n '1,240p' printf '%s\n' '--- exact-version rule registration references ---' curl -fsSL "https://api.github.com/repos/${repo}/git/trees/${tag}?recursive=1" \ | jq -r '.tree[]?.path' \ | rg 'curly|configuration_schema' \ | sed -n '1,120p' printf '%s\n' '--- exact-version commit resolution ---' curl -fsSL "https://api.github.com/repos/${repo}/git/ref/tags/${tag}" \ | jq '{ref, object}'Repository: TanStack/router
Length of output: 7918
🌐 Web query:
site:github.com/oxc-project/oxc "oxlint_v1.78.0" "curly"💡 Result:
In oxlint, the curly rule corresponds to the standard ESLint rule of the same name, which enforces consistent use of curly braces for control statements [1][2]. As of oxlint v1.78.0, the rule configuration follows the ESLint-style format, using strings as arguments rather than an object-based configuration [3][4][5]. The rule supports the following configuration options: "all" (default): Requires curly braces for all control statements [1]. "multi": Requires curly braces only when the control statement block contains multiple lines [1]. "multi-line": Requires curly braces if the statement is multiline or if the body spans multiple lines [1]. "multi-or-nest": Requires curly braces for control statements that are multiline or nested [1]. Additionally, the "consistent" option can be added as a separate string argument to ensure consistency across statements (e.g., ["error", "multi-or-nest", "consistent"]) [4][5]. While there was previous confusion in the documentation regarding whether "consistent" should be an object property or a string argument, the project has clarified that it is implemented as a string argument to match ESLint's behavior [3][6][4]. If you are working with JSX, oxlint also provides the react/jsx-curly-brace-presence rule, which manages the presence of curly braces for JSX props and children [7].
Citations:
- 1: https://github.com/oxc-project/oxc/blob/7b80010b91591903b5f89a125193e2a6eda8e893/crates/oxc_linter/src/rules/eslint/curly.rs
- 2: https://github.com/oxc-project/oxc/pull/8123
- 3: https://github.com/oxc-project/oxc/issues/18661
- 4: https://github.com/oxc-project/oxc/issues/18566
- 5: https://github.com/oxc-project/oxc/pull/13498
- 6: https://github.com/oxc-project/oxc/pull/18374
- 7: https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules/react/jsx_curly_brace_presence.rs
Enable the required
curlyrule.Oxlint
1.78.0supports this rule. Add"curly": ["error", "all"]to enforce braces for all control statements.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.oxlintrc.json at line 26, Update the rules configuration in .oxlintrc.json to enable the curly rule with error severity and the all option, enforcing braces for every control statement.Source: Coding guidelines
✅ Confirmed as addressed by @Sheraff
Enabled
curlyas["error", "all"], applied the safe fixes across the package lint scopes, and verified the affected lint, type, and unit suites.@Sheraff, thanks for the update. Thecurlyrule requirement is addressed.🐇 ✅
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
✅ Review thread resolved.
You are interacting with an AI system.Merging this PR will degrade performance by 0.76%#
:warning: Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments, which may affect the accuracy of the results.
⚡ 11improved benchmarks❌ 9 (👁 9)regressed benchmarks✅ 160untouched benchmarksPerformance Changes#
Tip
Curious why this is faster? Comment
@codspeedbot explain why this is fasteron this PR, or directly use the CodSpeed MCP with your agent.
Comparingchore/migrate-to-oxlint(0266c25) withmain(63d2cc9)schiller-manuel(GitHub profile, opens in a new tab) approved these changes
@Sheraff maybe its better to try out this?
Enabled
curlyas["error", "all"], applied the safe fixes across the package lint scopes, and verified the affected lint, type, and unit suites.Note
GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.
@Sheraff, thanks for the update. Thecurlyrule requirement is addressed.🐇 ✅
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
✅ Review thread resolved.
You are interacting with an AI system.
Sign in to join this conversation.
View your CI Pipeline Execution ↗ for commit 0266c250933a1e60845207581f9ec60e62ebd156
nx affected --targets=test:lint,test:unit,test:...nx run-many --target=build --exclude=examples/*...☁️ Nx Cloud last updated this comment at
2026-08-18 13:09:37UTC