fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS #8695
main fromrefs/pull/8695/head·merged by schiller-manuel(GitHub profile, opens in a new tab) 🎯 Changes#
imports on a normalized client chunk was read as a complete list when building route preloads, but walked as a graph everywhere else. Rolldown and Rsbuild list direct imports only, so a route lost every second-level modulepreload, and with Rsbuild shared chunks the sibling-based import list carried unrelated route CSS into the SSR response or dropped the shared CSS.
manifestBuilder.ts: one memoized depth-first walk over the static import graph now serves both preloads (discovery order) and stylesheets (dependencies first), replacing the flatimportsread for preloads and the separate recursive CSS collector. Each chunk in an import cycle now sees the whole cycle instead of a partially cached result.rsbuild/normalized-client-build.ts: deriveimportsfrom active module dependencies instead of chunk-group siblings, including concatenated modules and CSS-only chunks. Based on #8466 by @SyMind. Static dependency resolution is memoized per chunk.- Document the
importscontract onNormalizedClientChunk. - Tests: real Rspack fixtures for shared, second-level and initial vendor chunks; a direct-imports-only manifest test (from #8520 by @TiagoGranelli); the css-modules e2e now has shared chunks and runs on Vite and Rsbuild with JavaScript disabled.
✅ Checklist#
- I have followed the steps in the Contributing guide.
- I have tested code changes locally with the relevant test commands, or tests do not apply to this pull request.
- I fully understand the code in this pull request.
🚀 Release Impact#
- This change affects published code, and I have generated a changeset.
- This change is docs/CI/dev-only (no release).
Summary by CodeRabbit#
- Bug Fixes
- Improved route preloading in Rsbuild builds so pages include assets from their static import chains while dynamically loaded content remains separate.
- Improved stylesheet handling for shared and route-specific CSS, helping pages load relevant styles without unrelated route styles.
- New Features
- Added Rsbuild build coverage for CSS modules, including checks for route styles, shared styles, and preload behavior.
- 1
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: Repository: TanStack/router/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
174a2152-c6ce-40d4-a341-a7413fd85200
📥 Commits
-
Reviewing files that changed from the base of the PR and between 1420d00f821db0e5f3bdc5448b46d4d89e3004cf and 504f08ffff9cf26d576b12aefadf1c894a5925cf.
⛔ Files ignored due to path filters (1)
-
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
-
packages/start-plugin-core/src/rsbuild/normalized-client-build.tspackages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.tspackages/start-plugin-core/src/types.tspackages/start-plugin-core/tests/start-manifest-plugin/manifestBuilder.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
-
- packages/start-plugin-core/src/types.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
-
📝 Walkthrough
-
Walkthrough#
Rsbuild chunk normalization now derives static imports and CSS from module dependencies. Manifest generation traverses transitive static imports for route preloads. The CSS Modules E2E app adds Rsbuild support and production checks.
Changes#
Static chunk assets and preloads
Layer / File(s) Summary Normalize Rsbuild static dependencies
packages/start-plugin-core/src/rsbuild/normalized-client-build.ts,packages/start-plugin-core/tests/rsbuild/normalized-client-build.test.tsNormalized chunk imports now reflect active static dependencies rather than sibling chunks. CSS-only dependencies contribute styles before importer CSS. Real Rspack tests cover dependency handling, CSS ordering, and inline CSS. Traverse static imports for route preloads
packages/start-plugin-core/src/start-manifest-plugin/manifestBuilder.ts,packages/start-plugin-core/src/types.ts,packages/start-plugin-core/src/vite/start-manifest-plugin/plugin.ts,packages/start-plugin-core/tests/start-manifest-plugin/manifestBuilder.test.ts,.changeset/start-manifest-static-import-closure.mdManifest preloads now include transitive static imports; dynamic imports remain excluded. CSS links are collected in dependency-first order. Inline CSS URLs use joined base paths. Tests cover cycles and preload contents. Add shared and route-specific CSS fixtures
e2e/react-start/css-modules/src/components/*,e2e/react-start/css-modules/src/routes/*,e2e/react-start/css-modules/src/styles/*,e2e/react-start/css-modules/src/utils/formatTitle.ts,e2e/react-start/css-modules/src/routeTree.gen.tsThe E2E app adds a shared Header and formatting utility, plus Alpha, Beta, and Gamma routes with route-specific styles. The generated route tree registers the new routes. Configure and test production builds
e2e/react-start/css-modules/package.json,e2e/react-start/css-modules/{playwright.config.ts,rsbuild.config.ts,vite.config.ts},e2e/react-start/css-modules/tests/shared-css.prod.spec.tsThe E2E app adds Rsbuild build configuration and production checks for CSS isolation, shared-header styling, and script preloads. Playwright and Vite builds can use E2E_DIST_DIR.Priority: ➖ Normal
Estimated code review effort: 4 (Complex) | ~40 minutes
Change: Bug fix · Severity of issue fixed: Medium
Merge Risk: ⚪ Minimal · up to
504f0Route preloads now include the full chain of static imports, and Rsbuild shared-chunk CSS is limited to dependencies the route actually uses. Tests cover both changes, and no concrete regression was identified, so this is ready to merge.
Pre-merge checks ·
4 · 1-
Failed checks (1 warning)Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 40.91% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 16 files. Write docstrings for the functions missing them to satisfy the coverage threshold. Passed checks (4 passed)-
Check name Status Explanation Linked Issues check The PR satisfies both active linked issues. For #8511,manifestBuilder.tstraverses the direct static-import graph transitively and uses the traversal for route preloads. The manifest test covers di…Out of Scope Changes check The changes remain within the scope of #8415and#8511. TheNormalizedClientChunk.importsdocumentation, changeset, manifest resolver refactor, fixture changes, and automated tests support the stati…Title check The title clearly and concisely identifies both primary fixes: transitive static-import preloads and Rsbuild shared-chunk CSS. Description check The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, implementation, tests, linked issues, and changeset status. All checklist items are a…
-
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment `@coderabbitai help` to get the list of available commands.-
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
Diff Package Supply Chain
SecurityVulnerability Quality Maintenance License @rsbuild/plugin-sass@2.0.1 github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core
View your CI Pipeline Execution ↗ for commit 504f08ffff9cf26d576b12aefadf1c894a5925cf
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...❌ Failed 8m 49s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 19s View ↗
☁️ Nx Cloud last updated this comment at
2026-10-12 23:05:55UTCBundle Size Benchmarks#
- Commit:
6a8c63b1c9db - Measured at:
2026-10-12T22:58:35.648Z - Baseline source:
history:f243c61e95da - Dashboard: bundle-size history
The following scenarios have bundle-size changes compared with the baseline:
Scenario Current (gzip) Initial (gzip) Raw Brotli Trend react-start.rsbuild.minimal100.3 KiB
0 B100.2 KiB
-2 B313.2 KiB
+4 B86.6 KiB
-42 B▁▁▁▁▁▁▁████
react-start.rsbuild.minimal-iife100.7 KiB
-5 B100.6 KiB
-7 B314.2 KiB
+3 B87.0 KiB
+18 B▁▁▁▁▁▁▁████▄
react-start.rsbuild.full103.5 KiB
+3 B103.3 KiB
+1 B322.9 KiB
+4 B89.4 KiB
+49 B███████▄▁▁▁▁
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.
- Commit:
🚀 Changeset Version Preview#
14 package(s) bumped directly, 9 bumped as dependents.
🟨 Minor bumps#
Package Version Reason @tanstack/react-start1.168.61 → 1.169.0 Changeset @tanstack/solid-start1.168.58 → 1.169.0 Changeset @tanstack/vue-start1.168.57 → 1.169.0 Changeset 🟩 Patch bumps#
Package Version Reason @tanstack/react-start-rsc0.1.60 → 0.1.61 Changeset @tanstack/react-start-server1.167.47 → 1.167.48 Changeset @tanstack/router-core1.171.35 → 1.171.36 Changeset @tanstack/router-generator1.167.41 → 1.167.42 Changeset @tanstack/router-plugin1.168.43 → 1.168.44 Changeset @tanstack/solid-start-server1.167.45 → 1.167.46 Changeset @tanstack/start-client-core1.170.35 → 1.170.36 Changeset @tanstack/start-plugin-core1.171.50 → 1.171.51 Changeset @tanstack/start-server-core1.169.40 → 1.169.41 Changeset @tanstack/start-storage-context1.167.37 → 1.167.38 Changeset @tanstack/vue-start-server1.167.45 → 1.167.46 Changeset @tanstack/react-router1.170.42 → 1.170.43 Dependent @tanstack/react-start-client1.168.40 → 1.168.41 Dependent @tanstack/router-cli1.167.41 → 1.167.42 Dependent @tanstack/router-vite-plugin1.167.43 → 1.167.44 Dependent @tanstack/solid-router1.170.39 → 1.170.40 Dependent @tanstack/solid-start-client1.168.38 → 1.168.39 Dependent @tanstack/start-static-server-functions1.167.40 → 1.167.41 Dependent @tanstack/vue-router1.170.38 → 1.170.39 Dependent @tanstack/vue-start-client1.167.41 → 1.167.42 Dependent More templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-router-react-example-basic-authjs
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-rsbuild
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-example-next-migration
- tanstack-start-example-rscs
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- @tanstack/router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-authjs
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
- tanstack-router-vue-example-basic-jsx
- tanstack-router-vue-example-basic-file-based-jsx
- tanstack-router-vue-example-basic-file-based-sfc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8695@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8695@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8695@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8695@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8695@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8695@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8695@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8695@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8695@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8695@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8695@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8695@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8695@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8695@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8695@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8695@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8695@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8695@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8695@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8695@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8695@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8695@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8695@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8695@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8695@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8695@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8695@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8695@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8695@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8695@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8695@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8695@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8695@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8695@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8695@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8695@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8695@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8695@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8695@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8695@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8695commit:
504f08fMerging this PR will improve performance by 3.61%#
:information_source: 3 benchmarks have no flame graph
The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.
:warning: Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments, which may affect the accuracy of the results.
⚡ 1improved benchmark✅ 193untouched benchmarks⏩ 3skipped benchmarks1Performance Changes#
Mode Benchmark BASEHEADEfficiency ⚡ Memory mem client navigation-churn (solid)95 KB 91.6 KB +3.61% Tip
Curious why performance improved? Comment
@codspeedbot explain why performance improvedon this PR, or directly use the CodSpeed MCP with your agent.
Comparingfix/start-manifest-static-import-closure(504f08f) withmain(f243c61)Footnotes#
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
Sign in to join this conversation.
🦋 Changeset detected#
Latest commit: 504f08ffff9cf26d576b12aefadf1c894a5925cf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR