Skip to content
Source
Sign inSign up
TanStack/router

perf(router,start): update Seroval to 1.7.1 #8806

OpenLadyBluenotes(GitHub profile, opens in a new tab)wants to merge 1 commit intomain fromchore/update-seroval-1.7.1opened

🎯 Changes

Update Router and Start from Seroval 1.6.7 to 1.7.1, and the SSR benchmark dependency to match. Seroval 1.7 cuts per-node allocations in its parsers and streaming serializers, and adds backpressure for streamed async iterables and ReadableStream values (1.7.0 release notes).

  • Seroval 1.7 deserializes streams as instances of its new Stream class. The RawStream factory tests now build real streams with createStream() and spy on on, instead of typing hand-built objects as Stream.
  • Disposing crossSerializeStream or toCrossJSONStream no longer calls onDone. The SSR and server-function dispose paths are abort and cleanup paths that close their output themselves, so nothing depended on it.
  • Seroval now requires Node 20 or later, which Router and Start already require.

Start client bundles built with Vite grow. Most of the growth is the new LiveStream class: isStream checks value instanceof LiveStream, so bundles keep the class even though the client never creates one. A minimal Rolldown entry with Start's client Seroval imports goes from 7,460 B to 8,652 B gzip. Rsbuild bundles shrink, because 1.7 lets Rspack tree-shake Seroval modules it previously kept.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with the relevant test commands, or tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated the serialization components used across router, client, plugin, and server packages. Server-rendering benchmarks now use the same updated version.
  • Tests
    • Improved coverage of stream cancellation and disposal behavior using real streams. No public API changes are included.
    1. 🦋 Changeset detected

      Latest commit: fb223d5a9ffe679ca0a8b1d68c122d8d5c03738f

      The changes in this PR will be included in the next version bump.

      This PR includes changesets to release 23 packages
      NameType
      @tanstack/router-corePatch
      @tanstack/start-client-corePatch
      @tanstack/start-server-corePatch
      @tanstack/start-plugin-corePatch
      @tanstack/start-static-server-functionsPatch
      @tanstack/react-routerPatch
      @tanstack/react-start-clientPatch
      @tanstack/react-start-rscPatch
      @tanstack/react-start-serverPatch
      @tanstack/router-generatorPatch
      @tanstack/router-pluginPatch
      @tanstack/solid-routerPatch
      @tanstack/solid-start-clientPatch
      @tanstack/solid-start-serverPatch
      @tanstack/start-storage-contextPatch
      @tanstack/vue-routerPatch
      @tanstack/vue-start-clientPatch
      @tanstack/vue-start-serverPatch
      @tanstack/react-startPatch
      @tanstack/solid-startPatch
      @tanstack/vue-startPatch
      @tanstack/router-cliPatch
      @tanstack/router-vite-pluginPatch

      Not sure what this means? Click here to learn what changesets are.

      Click here if you're a maintainer who wants to add another changeset to this PR

    2. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-core

    3. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core

    4. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-server-core

    5. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-client-core

    6. github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-static-server-functions

    7. View your CI Pipeline Execution ↗ for commit fb223d5a9ffe679ca0a8b1d68c122d8d5c03738f

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 37sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded1m 50sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-10-24 18:22:29 UTC

    8. Review the following changes in direct dependencies. Learn more about Socket for GitHub.

      Diff Package Supply Chain
      Security
      Vulnerability Quality Maintenance License
      Updatedseroval-plugins@​1.6.7 ⏵ 1.7.110010087 +295 +1100
      Updatedseroval@​1.6.7 ⏵ 1.7.1100 +110010097 +1100

      View full report

    9. 🚀 Changeset Version Preview

      5 package(s) bumped directly, 18 bumped as dependents.

      🟩 Patch bumps

      PackageVersionReason
      @tanstack/router-core1.171.39 → 1.171.40Changeset
      @tanstack/start-client-core1.170.39 → 1.170.40Changeset
      @tanstack/start-plugin-core1.171.55 → 1.171.56Changeset
      @tanstack/start-server-core1.169.45 → 1.169.46Changeset
      @tanstack/start-static-server-functions1.167.44 → 1.167.45Changeset
      @tanstack/react-router1.170.46 → 1.170.47Dependent
      @tanstack/react-start1.169.4 → 1.169.5Dependent
      @tanstack/react-start-client1.168.44 → 1.168.45Dependent
      @tanstack/react-start-rsc0.1.65 → 0.1.66Dependent
      @tanstack/react-start-server1.167.52 → 1.167.53Dependent
      @tanstack/router-cli1.167.46 → 1.167.47Dependent
      @tanstack/router-generator1.167.46 → 1.167.47Dependent
      @tanstack/router-plugin1.168.48 → 1.168.49Dependent
      @tanstack/router-vite-plugin1.167.48 → 1.167.49Dependent
      @tanstack/solid-router1.170.43 → 1.170.44Dependent
      @tanstack/solid-start1.169.4 → 1.169.5Dependent
      @tanstack/solid-start-client1.168.42 → 1.168.43Dependent
      @tanstack/solid-start-server1.167.50 → 1.167.51Dependent
      @tanstack/start-storage-context1.167.41 → 1.167.42Dependent
      @tanstack/vue-router1.170.42 → 1.170.43Dependent
      @tanstack/vue-start1.169.4 → 1.169.5Dependent
      @tanstack/vue-start-client1.167.45 → 1.167.46Dependent
      @tanstack/vue-start-server1.167.50 → 1.167.51Dependent
    10. Review in Change Stack →

      No actionable comments were generated in the recent review.

      Recent review info
      Run configuration
      Commits

      Reviewing files that changed from the base of the PR and between 6b9fe6d29552270836c511bc9b343d73541f4424 and fb223d5a9ffe679ca0a8b1d68c122d8d5c03738f.

      Files ignored due to path filters: 1
      • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
      Files selected for processing: 8
      • .changeset/bump-seroval-1-7-1.md
      • benchmarks/ssr/package.json
      • packages/router-core/package.json
      • packages/router-core/tests/RawStream.test.ts
      • packages/start-client-core/package.json
      • packages/start-plugin-core/package.json
      • packages/start-server-core/package.json
      • packages/start-static-server-functions/package.json

      Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

      Walkthrough

      The pull request updates Seroval dependency ranges to 1.7.1 across TanStack packages and the SSR benchmark. It adds a patch changeset and revises RawStream tests to use real streams and a shared subscription spy.

      Changes: Seroval dependency upgrade

      Layer / File(s)Summary
      Update Seroval dependency ranges
      packages/router-core/package.json, packages/start-client-core/package.json, packages/start-plugin-core/package.json, packages/start-server-core/package.json, packages/start-static-server-functions/package.json, benchmarks/ssr/package.json, .changeset/bump-seroval-1-7-1.md
      The package manifests and SSR benchmark now specify Seroval 1.7.1. The changeset records the package updates and describes upstream changes.
      Revise RawStream test streams
      packages/router-core/tests/RawStream.test.ts
      The tests use real streams and a shared subscription spy to check cancellation and terminal-disposal behavior.
      Priority: Low

      Estimated code review effort: 2 (Simple) | ~10 minutes

      Change: Other

      Possibly related issues

      • TanStack/router#7706 — The dependency upgrade affects serialization dependencies used by Start, but the available summary does not establish that it fixes the reported deserialization error.

      Suggested reviewers: schiller-manuel, sheraff

      Merge Risk: Minimal · up to fb223

      This is a routine dependency upgrade with matching test updates. No concrete merge-blocking risk was identified. The author reports a modest client bundle size increase under Vite, which was an accepted tradeoff.

      Pre-merge checks: Passed 4 · Failed 1
      Failed Failed checks: 1 warning
      Check nameStatusExplanationResolution
      Docstring CoverageWarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (7 skipped: 7…Write docstrings for the functions missing them to satisfy the coverage threshold.
      Passed Passed checks: 4 passed
      Check nameStatusExplanation
      Title checkPassedThe title clearly summarizes the main change: updating Seroval to 1.7.1 in Router and Start.
      Description checkPassedThe description includes the required Changes, Checklist, and Release Impact sections. It explains the dependency update, motivation, test changes, and reported bundle-size effects. The testing and ch…
      Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
      Full details: Description check

      Explanation

      The description includes the required Changes, Checklist, and Release Impact sections. It explains the dependency update, motivation, test changes, and reported bundle-size effects. The testing and changeset checklist items are checked; the contributing-guide and code-understanding items remain unchecked.

      Full details: Docstring Coverage

      Explanation

      Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (7 skipped: 7 unsupported.)

      Resolution

      Write docstrings for the functions missing them to satisfy the coverage threshold.

      Finishing Touches: 💡 1
      📝 Generate docstrings: 💡
      • Commit to this branch
      • Create a new PR
      🧪 Generate unit tests (beta)
      • Commit to this branch
      • Create a new PR
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands.
    11. Bundle Size Benchmarks

      • Commit: 05a8b9257f0f
      • Measured at: 2026-10-24T18:12:54.764Z
      • Baseline source: history:6b9fe6d29552
      • Dashboard: bundle-size history

      The following scenarios have bundle-size changes compared with the baseline:

      ScenarioCurrent (gzip)Initial (gzip)RawBrotliTrend
      react-start.minimal97.9 KiB
      +1.1 KiB
      97.8 KiB
      +1.1 KiB
      303.9 KiB
      +1.5 KiB
      85.1 KiB
      +1,002 B
      ▁▁▁▁▁▁▁▁▁▁▁█
      react-start.query-integration105.3 KiB
      +1.1 KiB
      105.2 KiB
      +1.1 KiB
      330.5 KiB
      +1.5 KiB
      91.5 KiB
      +1.0 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      react-start.deferred-hydration98.6 KiB
      +1.1 KiB
      97.8 KiB
      +1.1 KiB
      305.3 KiB
      +1.5 KiB
      85.7 KiB
      +1.0 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      react-start.full101.0 KiB
      +1.1 KiB
      100.8 KiB
      +1.1 KiB
      313.2 KiB
      +1.5 KiB
      87.7 KiB
      +1.1 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      react-start.rsbuild.minimal97.8 KiB
      -2.5 KiB
      97.7 KiB
      -2.5 KiB
      300.9 KiB
      -12.3 KiB
      84.6 KiB
      -2.0 KiB
      ███████████▁
      react-start.rsbuild.minimal-iife98.2 KiB
      -2.5 KiB
      98.1 KiB
      -2.5 KiB
      301.9 KiB
      -12.3 KiB
      85.0 KiB
      -2.0 KiB
      ███████████▁
      react-start.rsbuild.full101.0 KiB
      -2.5 KiB
      100.9 KiB
      -2.5 KiB
      310.6 KiB
      -12.3 KiB
      87.3 KiB
      -2.1 KiB
      ███████████▁
      solid-start.minimal47.3 KiB
      +1.1 KiB
      47.2 KiB
      +1.1 KiB
      136.6 KiB
      +1.6 KiB
      42.3 KiB
      +1.1 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      solid-start.deferred-hydration50.4 KiB
      +1.2 KiB
      47.3 KiB
      +1.2 KiB
      143.9 KiB
      +1.6 KiB
      45.0 KiB
      +1.1 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      solid-start.full52.3 KiB
      +1.2 KiB
      52.2 KiB
      +1.2 KiB
      151.6 KiB
      +1.6 KiB
      46.5 KiB
      +1.0 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█
      vue-start.minimal66.5 KiB
      +1.1 KiB
      66.4 KiB
      +1.1 KiB
      187.2 KiB
      +1.6 KiB
      59.4 KiB
      +1,004 B
      ▁▁▁▁▁▁▁▁▁▁▁█
      vue-start.full70.3 KiB
      +1.2 KiB
      70.1 KiB
      +1.2 KiB
      199.1 KiB
      +1.6 KiB
      62.7 KiB
      +1.0 KiB
      ▁▁▁▁▁▁▁▁▁▁▁█

      Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

    12. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/@tanstack/arktype-adapter@8806

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8806

      @tanstack/eslint-plugin-start

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8806

      @tanstack/history

      npm i https://pkg.pr.new/@tanstack/history@8806

      @tanstack/react-router

      npm i https://pkg.pr.new/@tanstack/react-router@8806

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/@tanstack/react-router-devtools@8806

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8806

      @tanstack/react-start

      npm i https://pkg.pr.new/@tanstack/react-start@8806

      @tanstack/react-start-client

      npm i https://pkg.pr.new/@tanstack/react-start-client@8806

      @tanstack/react-start-rsc

      npm i https://pkg.pr.new/@tanstack/react-start-rsc@8806

      @tanstack/react-start-server

      npm i https://pkg.pr.new/@tanstack/react-start-server@8806

      @tanstack/router-cli

      npm i https://pkg.pr.new/@tanstack/router-cli@8806

      @tanstack/router-core

      npm i https://pkg.pr.new/@tanstack/router-core@8806

      @tanstack/router-devtools

      npm i https://pkg.pr.new/@tanstack/router-devtools@8806

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/@tanstack/router-devtools-core@8806

      @tanstack/router-generator

      npm i https://pkg.pr.new/@tanstack/router-generator@8806

      @tanstack/router-plugin

      npm i https://pkg.pr.new/@tanstack/router-plugin@8806

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8806

      @tanstack/router-utils

      npm i https://pkg.pr.new/@tanstack/router-utils@8806

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8806

      @tanstack/solid-router

      npm i https://pkg.pr.new/@tanstack/solid-router@8806

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8806

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8806

      @tanstack/solid-start

      npm i https://pkg.pr.new/@tanstack/solid-start@8806

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/@tanstack/solid-start-client@8806

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/@tanstack/solid-start-server@8806

      @tanstack/start-client-core

      npm i https://pkg.pr.new/@tanstack/start-client-core@8806

      @tanstack/start-fn-stubs

      npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8806

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/@tanstack/start-plugin-core@8806

      @tanstack/start-server-core

      npm i https://pkg.pr.new/@tanstack/start-server-core@8806

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8806

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/@tanstack/start-storage-context@8806

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/@tanstack/valibot-adapter@8806

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8806

      @tanstack/vue-router

      npm i https://pkg.pr.new/@tanstack/vue-router@8806

      @tanstack/vue-router-devtools

      npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8806

      @tanstack/vue-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8806

      @tanstack/vue-start

      npm i https://pkg.pr.new/@tanstack/vue-start@8806

      @tanstack/vue-start-client

      npm i https://pkg.pr.new/@tanstack/vue-start-client@8806

      @tanstack/vue-start-server

      npm i https://pkg.pr.new/@tanstack/vue-start-server@8806

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/@tanstack/zod-adapter@8806

      commit: fb223d5

    13. Merging this PR will regress 11 benchmarks

      2 warnings

      :warning: 39 benchmarks are dominated by system calls

      System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

      Learn more about system calls

      See affected benchmarks

      :warning: Base and head ran on different runner types

      Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

      Learn more about Macro Runners

      Open the report in CodSpeed to investigate

      ⚡ 65 improved benchmarks ❌ 11 regressed benchmarks ✅ 118 untouched benchmarks ⏩ 3 skipped benchmarks1

      Warning

      Please fix the performance issues or acknowledge them on CodSpeed.

      Performance Changes

      ModeBenchmarkBASEHEADEfficiency
      ❌Memorymem server streaming-peak chunked (vue)221.4 KB322.5 KB-31.35%
      ❌Memorymem server streaming-peak chunked (solid)350.6 KB482.4 KB-27.32%
      ❌Memorymem server error-paths error (vue)131.8 KB141.1 KB-6.53%
      ❌Memorymem server request-churn (vue)139.2 KB148.9 KB-6.51%
      ❌Memorymem server error-paths redirect (solid)11.4 KB12.1 KB-6.31%
      ❌Memorymem server aborted-requests (vue)116.1 KB123.5 KB-5.98%
      ❌Memorymem client navigation-churn (solid)107.4 KB113.6 KB-5.51%
      ❌Memorymem server request-churn (react)255.2 KB269.6 KB-5.34%
      ❌Memorymem server error-paths unmatched (solid)50.8 KB53 KB-4.1%
      ❌Memorymem server error-paths not-found (solid)63.4 KB66.1 KB-4.04%
      ❌Memorymem server error-paths error (solid)63.3 KB65.6 KB-3.48%
      ⚡CPU Simulationssr selective (react)509.2 ms338.4 ms+50.49%
      ⚡CPU Simulationssr selective (solid)515.9 ms343.6 ms+50.17%
      ⚡CPU Simulationssr loaders (react)324.8 ms225 ms+44.34%
      ⚡CPU Simulationssr loaders (solid)317.1 ms227.2 ms+39.54%
      ⚡CPU Simulationssr selective (vue)634.7 ms462.1 ms+37.35%
      ⚡CPU Simulationssr dehydrate plain control (react)202.7 ms156.9 ms+29.21%
      ⚡CPU Simulationssr dehydrate rich types (react)205 ms158.9 ms+28.96%
      ⚡CPU Simulationssr loaders (vue)403.7 ms315.1 ms+28.1%
      ⚡CPU Simulationssr global-mw server-fn (react)179.3 ms141 ms+27.21%
      ..................

      :information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

      [!TIP] Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


      Comparing chore/update-seroval-1.7.1 (fb223d5) with main (6b9fe6d) Open in CodSpeed

      Footnotes

      1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign in to join this conversation.