test(router-utils): re-enable unit tests #8849
main fromrefs/pull/8849/head·merged by Sheraff(GitHub profile, opens in a new tab) @tanstack/router-utils's test:unit script has been exit 0; vitest --typecheck since the package was created (#3287), so its tests never ran in CI. They already pass on main (2 files, 28 tests, no type errors), so this switches the script to vitest. Type checking stays on through typecheck: { enabled: true } in vite.config.ts.
This is split out of #8817, which makes the same script change.
Validated with nx run-many -p @tanstack/router-utils -t test:unit,test:types,test:eslint.
🤖 Generated with Claude Code
Summary by CodeRabbit#
- Tests
- Updated the unit-test workflow to run the test suite directly. The command no longer performs an additional type-check step, so its execution is focused on unit tests. This change affects the project’s testing workflow only; no user-facing features or product behavior have changed.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: router-utils
View your CI Pipeline Execution ↗ for commit 71e07abf1e48f8e6b6e0e9fa60719101c24bda20
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 11m 59s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 1m 22s View ↗
☁️ Nx Cloud last updated this comment at
2026-11-03 14:46:02UTC🚀 Changeset Version Preview#
No changeset entries found. Merging this PR will not cause a version bump for any packages.
More templates
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-router-react-example-basic-authjs
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-rsbuild
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-clerk-basic
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-example-next-migration
- tanstack-start-example-rscs
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
- tanstack-router-vue-example-basic-jsx
- tanstack-router-vue-example-basic-file-based-jsx
- tanstack-router-vue-example-basic-file-based-sfc
- tanstack-router-solid-example-authenticated-routes
- tanstack-router-solid-example-authenticated-routes-firebase
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-default-search-params
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-basic-virtual-file-based
- tanstack-router-solid-example-basic-virtual-inside-file-based
- tanstack-router-solid-example-deferred-data
- tanstack-router-solid-i18n-paraglide
- tanstack-router-solid-example-kitchen-sink
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-kitchen-sink-solid-query
- tanstack-router-solid-example-kitchen-sink-solid-query-file-based
- tanstack-router-solid-example-large-file-based
- tanstack-router-solid-example-location-masking
- tanstack-router-solid-example-navigation-blocking
- tanstack-router-solid-example-quickstart
- tanstack-router-solid-example-quickstart-esbuild-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-router-solid-example-quickstart-rspack-file-based
- tanstack-router-solid-example-quickstart-webpack-file-based
- @tanstack/router-solid-mono-simple
- router-solid-mono-simple-lazy
- router-solid-monorepo-solid-query
- tanstack-router-solid-example-scroll-restoration
- tanstack-solid-router-search-validator-adapters
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-auth
- tanstack-solid-start-example-basic-authjs
- tanstack-solid-start-example-basic-cloudflare
- tanstack-solid-start-example-basic-netlify
- tanstack-solid-start-example-basic-nitro
- tanstack-start-example-basic-solid-query
- tanstack-solid-start-example-basic-static
- tanstack-solid-start-bun-hosting
- tanstack-solid-start-example-convex-better-auth
- tanstack-solid-start-example-counter
- tanstack-solid-start-i18n-paraglide
- tanstack-solid-start-example-large
- tanstack-solid-start-streaming-data-from-server-functions
- tanstack-solid-start-example-supabase-basic
- tanstack-solid-start-tailwind-v4
- tanstack-router-solid-example-view-transitions
- tanstack-router-solid-example-with-framer-motion
- tanstack-router-solid-example-with-trpc
@tanstack/arktype-adapter
npm i https://pkg.pr.new/@tanstack/arktype-adapter@8849@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8849@tanstack/eslint-plugin-start
npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8849@tanstack/history
npm i https://pkg.pr.new/@tanstack/history@8849@tanstack/react-router
npm i https://pkg.pr.new/@tanstack/react-router@8849@tanstack/react-router-devtools
npm i https://pkg.pr.new/@tanstack/react-router-devtools@8849@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8849@tanstack/react-start
npm i https://pkg.pr.new/@tanstack/react-start@8849@tanstack/react-start-client
npm i https://pkg.pr.new/@tanstack/react-start-client@8849@tanstack/react-start-rsc
npm i https://pkg.pr.new/@tanstack/react-start-rsc@8849@tanstack/react-start-server
npm i https://pkg.pr.new/@tanstack/react-start-server@8849@tanstack/router-cli
npm i https://pkg.pr.new/@tanstack/router-cli@8849@tanstack/router-core
npm i https://pkg.pr.new/@tanstack/router-core@8849@tanstack/router-devtools
npm i https://pkg.pr.new/@tanstack/router-devtools@8849@tanstack/router-devtools-core
npm i https://pkg.pr.new/@tanstack/router-devtools-core@8849@tanstack/router-generator
npm i https://pkg.pr.new/@tanstack/router-generator@8849@tanstack/router-plugin
npm i https://pkg.pr.new/@tanstack/router-plugin@8849@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8849@tanstack/router-utils
npm i https://pkg.pr.new/@tanstack/router-utils@8849@tanstack/router-vite-plugin
npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8849@tanstack/solid-router
npm i https://pkg.pr.new/@tanstack/solid-router@8849@tanstack/solid-router-devtools
npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8849@tanstack/solid-router-ssr-query
npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8849@tanstack/solid-start
npm i https://pkg.pr.new/@tanstack/solid-start@8849@tanstack/solid-start-client
npm i https://pkg.pr.new/@tanstack/solid-start-client@8849@tanstack/solid-start-server
npm i https://pkg.pr.new/@tanstack/solid-start-server@8849@tanstack/start-client-core
npm i https://pkg.pr.new/@tanstack/start-client-core@8849@tanstack/start-fn-stubs
npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8849@tanstack/start-plugin-core
npm i https://pkg.pr.new/@tanstack/start-plugin-core@8849@tanstack/start-server-core
npm i https://pkg.pr.new/@tanstack/start-server-core@8849@tanstack/start-static-server-functions
npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8849@tanstack/start-storage-context
npm i https://pkg.pr.new/@tanstack/start-storage-context@8849@tanstack/valibot-adapter
npm i https://pkg.pr.new/@tanstack/valibot-adapter@8849@tanstack/virtual-file-routes
npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8849@tanstack/vue-router
npm i https://pkg.pr.new/@tanstack/vue-router@8849@tanstack/vue-router-devtools
npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8849@tanstack/vue-router-ssr-query
npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8849@tanstack/vue-start
npm i https://pkg.pr.new/@tanstack/vue-start@8849@tanstack/vue-start-client
npm i https://pkg.pr.new/@tanstack/vue-start-client@8849@tanstack/vue-start-server
npm i https://pkg.pr.new/@tanstack/vue-start-server@8849@tanstack/zod-adapter
npm i https://pkg.pr.new/@tanstack/zod-adapter@8849commit:
71e07abNo actionable comments were generated in the recent review.
Walkthrough
-
The
test:unitscript inpackages/router-utils/package.jsonnow runsvitestdirectly.Changes: Router utils unit tests
Layer / File(s) Summary Update unit test command
packages/router-utils/package.jsonThe test:unitscript now invokesvitestdirectly instead of exiting successfully before invoking Vitest with--typecheck.Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers:
schiller-manuel
Merge Risk:
Minimal · up to71e07-
This focused change re-enables the router-utils unit test command without introducing an actionable merge risk.
Pre-merge checks:
5-
Check name Status Explanation Title check The title "test(router-utils): re-enable unit tests" matches the main change. The PR changes the router-utils test:unit script from "exit 0; vitest --typecheck" to "vitest", so the unit tests run agai… Description check The description covers the change and its motivation. It explains that the test:unit script exited early with "exit 0", so tests never ran in CI. It reports that the tests already pass on main (2 file… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "test(router-utils): re-enable unit tests" matches the main change. The PR changes the router-utils test:unit script from "exit 0; vitest --typecheck" to "vitest", so the unit tests run again. The title is specific, short, and uses a conventional commit style.
Full details: Description check
-
Explanation
The description covers the change and its motivation. It explains that the test:unit script exited early with "exit 0", so tests never ran in CI. It reports that the tests already pass on main (2 files, 28 tests, no type errors). It states that type checking stays enabled through typecheck: { enabled: true } in vite.config.ts. It lists the validation command and links the related PR
#8817. The description does not follow the repository template. It has no Checklist section and no Release Impact section, and it does not disclose AI authorship in the template's required form, even though it includes a Claude Code attribution line. The description is mostly complete, so the check passes, but the author should add the missing template sections.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
-
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
-
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
CodeRabbit Verify#
- Run CodeRabbit Verify to test the changes in this pull request.
Recent review info-
Run configuration-
- Source mode: Auto
- Repository: TanStack/router
- Branch: test/router-utils-enable-unit-tests
- File: .coderabbit.yaml
- Commit: 71e07ab
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
455f7cb8-b6bc-4647-95ac-5591ab43ceaa
Commits-
Reviewing files that changed from the base of the PR and between f723f3b8be0699746e6e3192a16e3a8aaf3ce121 and 71e07abf1e48f8e6b6e0e9fa60719101c24bda20.
Files selected for processing: 1-
packages/router-utils/package.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-
-
Bundle Size Benchmarks#
This pull request does not affect bundle size in any measured scenario.
Merging this PR will improve performance by 6.81%#
2 warnings
:warning: 49 benchmarks are dominated by system calls
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
:warning: 1 benchmark with a significant change ran on different hardware
Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.
⚡ 1improved benchmark✅ 193untouched benchmarks⏩ 3skipped benchmarks1Performance Changes#
Mode Benchmark BASEHEADEfficiency ⚡ Memory mem server error-paths redirect (solid)12 KB 11.2 KB +6.81% Tip
Curious why performance improved? Comment
@codspeedbot explain why performance improvedon this PR, or directly use the CodSpeed MCP with your agent.
Comparingtest/router-utils-enable-unit-tests(71e07ab) withmain(f723f3b)Footnotes#
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
Sheraff(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
⚠️ No Changeset found#
Latest commit: 71e07abf1e48f8e6b6e0e9fa60719101c24bda20
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR