Skip to content
Source
Sign inSign up
TanStack/schemas

Keep a dead NVIDIA retrieval-index link from failing every models poll #685

Mergedtombeckenhammerged 1 commit intomain from100001-nvidia-retrieval-index-links-embed-qa-4-to-a-404-page-modelsmerged by tombeckenham View on GitHub

tombeckenhamcommented

Summary

NVIDIA's retrieval index still links listed model nvidia/embed-qa-4 to nvidia-embedding-2b-infer, and that page 404s. The models poll followed the link on every run and reported ingest_failed.

  • An index row the models list does not name is stale and is not fetched.
  • A listed row whose only published infer page 404s is reported once per docs TTL as nvidia: <id> has no published spec: <page> returned 404. That row's schema facts stay unavailable (any stored schema is kept). The poll does not throw, and it does not try another page.

Fixes #100001

Test plan

  • pnpm exec vitest run src/server/providers/adapters/nvidia.test.ts src/server/providers/nvidia-openapi.test.ts src/server/providers/nvidia-build-spec.test.ts src/server/providers/nvidia-native-reasoning-discovery.test.ts
  • After deploy, the next NVIDIA models poll reports the missing spec once, then stops emitting ingest_failed for that 404 until the six-hour docs TTL.
    1. tombeckenham linked this to fix #100001

    2. Warning

      Review limit reached

      You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

      Next included review available in 47 minutes.

      Check out review usage here.

      View limit details

      Limit details: You’ve used the included review currently available.

      Learn how review limits work.

      Review configuration:

      Run configuration

      • Source mode: Auto
      • Repository: Unavailable
      • Branch: Unavailable
      • File: No configuration file from this repository applied
      • Commit: Unavailable
      • Layers: defaults
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: bffb5899-491c-40b7-828b-77253813cd4d
      Commits

      Reviewing files that changed from the base of the PR and between 48ce00d4d5ceb0472b83fa1a485451d59df341c5 and 586907e2f5fc27db8deec58b876167e014ef0c6d.

      Files selected for processing: 3

      • src/server/providers/adapters/nvidia.test.ts
      • src/server/providers/adapters/nvidia.ts
      • src/server/providers/nvidia-openapi.ts
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share

    3. ⚠️ No Changeset found

      Latest commit: 586907e2f5fc27db8deec58b876167e014ef0c6d

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    4. tombeckenham merged this921aa0f

    5. tombeckenham merged this921aa0f

    6. tombeckenham closed this

Sign in to join this conversation.