Skip to content
Source
Sign inSign up
TanStack/schemas

Name a hosted model's maker as its host states it #731 (GitHub #732)

Mergedtombeckenhammerged 9 commits intomain fromfeat/710-model-makermerged by tombeckenham View on GitHub

tombeckenhamcommented

Base is now main (#720 merged). Review fixes are in 281c395.

Field shape

Model rows gain maker: string | null: the maker as the host names it, with factSources.maker as its source.

  • maker set: the host's source names the maker (factSources.maker.path is owned_by, Provider, Summary or Authors).
  • maker: null with factSources.maker.path: "unstated": the host's page lists the model and names no maker.
  • maker: null with no factSources.maker: the page does not list the model, or no maker source is read for that provider. Absence from a table is not a statement.
  • A docs outage marks maker unavailable, so the stored value and source are kept and the failure is on docsFailures.

Why a name and not a provider id: resolving "Z.ai" or "Alibaba Cloud" to a catalog provider would need a hand-written vocabulary (no namespace in provider_model_namespaces spells them), and linking to the maker's row is sameAs (#718, #719). So this PR stores only what the host states.

The name can be the host's own company (ByteDance on BytePlus Seed rows, Google DeepMind on Gemma). Telling a host's own models from hosted ones is decidable from this field on Mistral (own rows are null + unstated) and Gemini (Gemma is the only row with a maker, and it also gains openWeights) only. On BytePlus the list page names a provider for only some Seed rows, so maker === 'ByteDance' does not find them all.

First fill on a stored row (a maker, or the first unstated) is written with no model.updated, like the first releasedAt and providerMetadata. Later changes emit one.

Source per host

  • groq: owned_by on GET https://api.groq.com/openai/v1/models (live 2026-11-21: OpenAI, Alibaba Cloud, Meta, SDAIA, Canopy Labs). Fixture groq-models-owned-by.json. Every Groq row names a maker, including the 6 issue rows. Groq states no open weights.
  • mistral: the Summary column of https://docs.mistral.ai/models.md. A maker is read only from a Summary that opens "A third-party ... model from "; the name ends at the sentence (a full stop then whitespace or the end), a comma or semicolon, or the first word with no capital or digit, so Z.ai, 01.AI and xAI stay whole. Any other Summary that says "third-party" throws under tryDocs, so a new wording fails loudly instead of reading as Mistral's own. The listing's owned_by is mistralai on every row, so it is not used. The maker is copied across the listing's mutual alias group. unstated only for an id in the overview's API name column, or a mutual alias of one. Live listing: all 6 issue rows name a maker (five Z.ai, deepseek-v4-1-flash-1017 DeepSeek); every other live row is unstated. Fixture mistral-models-makers.md.txt. openWeights is not filled from Mistral pages in this PR.
  • byteplus: the merged Provider column of https://docs.byteplus.com/en/docs/ModelArk/1330310. The Ark listing has no maker field. unstated only for an id the page lists in a Model ID column with no Provider value (Seedance, Seedream). Named: deepseek-v4-1-flash-260910, -261017, deepseek-v4-1-flash-economy-261017, deepseek-v4-flash-260425, deepseek-v4-flash-ga-260731, deepseek-v4-pro-260425, deepseek-v4-pro-ga-260813 (DeepSeek), glm-5-2-260617, glm-5-3-flash-260828 (Z.ai), the Seed rows the page lists (ByteDance), and the two 3D rows. Fixture byteplus-model-list-providers.json (two Provider tables and one Model ID table cut from the live doc JSON).
  • gemini: the Gemma 4 model card, https://ai.google.dev/gemma/docs/core/model_card_4. Its header states Authors : Google DeepMind, "This release includes open-weights models", and links https://huggingface.co/collections/google/gemma-4. Both issue rows (gemma-4-26b-a4b-it, gemma-4-31b-it) get maker: "Google DeepMind", openWeights: true and that weightsUrl, bound only to the sizes the card's Supported Modalities table binds. Fixture gemma-4-card-header.html.txt.

No id prefix is read anywhere, and nothing comes from OpenRouter or another reseller.

Rows with no maker and no factSources.maker (acceptance not met for these)

  • byteplus (the model list does not name them, and gpt-oss's own page names no maker): gpt-oss-120b-250805, glm-4-7-251222, kimi-k2-250711, kimi-k2-250905, kimi-k2-thinking-251104, deepseek-r1-250120, deepseek-r1-250528, deepseek-r1-distill-qwen-32b-250120, deepseek-v3, deepseek-v3-241226, deepseek-v3-1-250821, deepseek-v3-2-251201, deepseek-v4-1-flash-economy-260910. Also BytePlus's own ids the page does not list (seed-2-0-lite-260228, seed-2-0-mini-260215, seed-1-8-251228, the seed-1-6-* rows, seedance-1-5-pro-251215, seed-audio-1.0, seed-asr).
  • gemini: every non-Gemma row (no maker source is read for them; they are Google's own).
  • mistral, groq: none on the live listings.

API shape change

  • Model.maker (required, string | null) and ModelFactSources.maker.
  • D1 migration 0020_model_maker (one ADD maker text, chained from main's 0019). Migrate first, then deploy.
  • MODEL_ROW_SHAPE 12, openapi.json and the generated client regenerated, changeset .changeset/model-maker.md, README and docs/api-changes.md notes.
  • DOCS_CACHE_VERSION v46 (v45 is reserved for #721).

Checks

pnpm run typecheck, lint, check, check:client and test (258 files, 2585 tests) pass. Tests cover: Groq owned_by; the Mistral Summary rule (xAI, 01.AI, "Z.ai. Great for coding.", and throws on "built by", "the Qwen team at", and a non-leading third-party claim); Mistral alias-group fill, listed-own unstated and unlisted-no-source through listModels; BytePlus Provider parse, listed-without-provider unstated, unlisted-no-source, and list-down unavailable; Gemma card facts and binding; and a poll-models worker test for the quiet first fill, unavailable and a changed maker.

    1. tombeckenham pushedc2accb9

    2. tombeckenham pushede50625f

    3. tombeckenham pushedad2d5c6

    4. 🦋 Changeset detected

      Latest commit: ad2d5c6e7577953a836960edb70d9ff4fbc1e93f

      The changes in this PR will be included in the next version bump.

      This PR includes changesets to release 5 packages
      NameType
      @modelschemas/clientMinor
      modelschemasMinor
      @modelschemas/codegenMinor
      @modelschemas/rate-cardMinor
      @modelschemas/viteMinor

      Not sure what this means? Click here to learn what changesets are.

      Click here if you're a maintainer who wants to add another changeset to this PR

    5. Warning

      Review limit reached

      You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

      Next included review available in 28 minutes.

      Check out review usage here.

      View limit details

      Limit details: You’ve used the included review currently available.

      Learn how review limits work.

      Review configuration:

      Run configuration

      • Source mode: Auto
      • Repository: Unavailable
      • Branch: Unavailable
      • File: No configuration file from this repository applied
      • Commit: Unavailable
      • Layers: defaults
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: d3e4c91c-1e2d-4400-904b-ab2444f76f61
      Commits

      Reviewing files that changed from the base of the PR and between eb69bca69c5448c507f26b6838389b71ff8db033 and ad2d5c6e7577953a836960edb70d9ff4fbc1e93f.

      Files ignored due to path filters: 1

      • packages/client/src/generated/types.gen.ts is excluded by !**/generated/**
      Files selected for processing: 34

      • .changeset/model-maker.md
      • CLAUDE.md
      • README.md
      • docs/api-changes.md
      • drizzle/0020_model_maker.sql
      • drizzle/meta/0020_snapshot.json
      • drizzle/meta/_journal.json
      • openapi.json
      • packages/client/src/listed-model.test.ts
      • src/db/schema.ts
      • src/routes/models/$provider.$modelId.tsx
      • src/server/catalog.ts
      • src/server/ingest/poll-models.ts
      • src/server/ingest/poll-models.worker.test.ts
      • src/server/openapi.ts
      • src/server/providers/adapters/groq.test.ts
      • src/server/providers/adapters/groq.ts
      • src/server/providers/adapters/mistral.test.ts
      • src/server/providers/adapters/mistral.ts
      • src/server/providers/byteplus-pricing.ts
      • src/server/providers/byteplus.test.ts
      • src/server/providers/byteplus.ts
      • src/server/providers/fixtures/byteplus-model-list-providers.json
      • src/server/providers/fixtures/gemma-4-card-header.html.txt
      • src/server/providers/fixtures/groq-models-owned-by.json
      • src/server/providers/fixtures/mistral-models-makers.md.txt
      • src/server/providers/gemini-bindings.test.ts
      • src/server/providers/gemini-bindings.ts
      • src/server/providers/gemini-list.test.ts
      • src/server/providers/mistral-pricing.ts
      • src/server/providers/model-facts.ts
      • src/server/providers/openai-compat.ts
      • src/server/providers/types.ts
      • src/server/row-shape.ts
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share

    6. tombeckenham merged this16ddb12

    7. tombeckenham closed this

Sign in to join this conversation.