fix(table-core): flatten sorted parent rows ahead of their sub-rows #6529
main fromrefs/pull/6529/head·merged by KevinVandy 🎯 Changes#
_createSortedRowModel recurses into a row's sub-rows before pushing the row itself, so getSortedRowModel().flatRows comes out in post-order — every descendant precedes its own parent.
With two parent rows that each have sub-rows, sorted ascending:
table.getCoreRowModel().flatRows.map((r) => r.id)
// ['a', 'a1', 'a2', 'b', 'b1']
table.getSortedRowModel().flatRows.map((r) => r.id)
// before: ['b1', 'b', 'a2', 'a1', 'a']
// after: ['b', 'b1', 'a', 'a2', 'a1']
That disagrees with the model's own rows, which are already in render order, and with how the rest of the pipeline flattens:
createCoreRowModelpushes a row, then recurses into its sub-rows.createPaginatedRowModel'shandleRowdoes the same.addSubRowsToFlatArrays(added for themaxLeafRowFilterDepthcase in #6395) is explicitly parent-first, to keep "the flat representation ... consistent with the visible tree".
The fix takes the row's slot before descending, and overwrites that slot when the branch is cloned, so flatRows still holds the same instance as rows — which the previous sortedFlatRows.push(cloned) guaranteed and a plain push before recursion would have lost.
Deliberately not included#
filterRowModelFromLeafs and filterRowModelFromRoot flatten the same way, so getFilteredRowModel().flatRows is post-order too. I left those alone: column_getAutoSortFn and column_getAutoFilterFn sample getFilteredRowModel().flatRows.slice(0, 10), so reordering that array changes which rows drive automatic fn detection (cf. #4908). That felt like a bigger behavioral call than this fix — happy to do it in a follow-up if you'd like it changed.
✅ Checklist#
- I have followed the steps in the Contributing guide.
- I have tested this code locally with
pnpm run test:pr.
pnpm run test:pr is green — test:eslint, test:sherif, test:knip, test:lib, test:types, test:build, build across 408 projects, with @tanstack/table-core:test:lib at 62/62 files and 1288/1288 tests.
Two tests added to createSortedRowModel.test.ts, both verified to fail on main and pass with the fix:
flattens each parent ahead of its own sub-rows— the ordering itself.flattens a branch clone rather than the row it replaced— pinsflatRows[0] === rows[0]so the clone, not the row it replaced, is what lands inflatRows.
🚀 Release Impact#
- This change affects published code, and I have generated a changeset.
- This change is docs/CI/dev-only (no release).
Summary by CodeRabbit#
Bug Fixes
- Corrected sorted table output so parent rows consistently appear before their sub-rows in flattened results.
- Ensured flattened results reference the correctly sorted row branches.
- Improved consistency for grouped and worker-backed sorted table models.
Tests
- Added coverage for parent and descendant ordering in sorted flattened rows.
- Expanded coverage for grouped models and depth handling.
- 1
View your CI Pipeline Execution ↗ for commit 726f21bed94cbdee569b2b448852249aec446f95
Command Status Duration Result nx affected --targets=test:eslint,test:sherif,t...✅ Succeeded 7m 42s View ↗ nx run-many --targets=build --exclude=examples/**✅ Succeeded 1m 1s View ↗
☁️ Nx Cloud last updated this comment at
2026-08-08 17:47:54UTCMore templates
- tanstack-alpine-table-example-aggregation
- tanstack-alpine-table-example-basic-app-table
- tanstack-alpine-table-example-basic-create-table
- tanstack-alpine-table-example-basic-dynamic-columns
- tanstack-alpine-table-example-basic-external-atoms
- tanstack-alpine-table-example-basic-external-state
- tanstack-alpine-table-example-cell-selection
- tanstack-alpine-table-example-cell-spanning
- tanstack-alpine-table-example-column-ordering
- tanstack-alpine-table-example-column-pinning
- tanstack-alpine-table-example-column-pinning-split
- tanstack-alpine-table-example-column-pinning-sticky
- tanstack-alpine-table-example-column-resizing
- tanstack-alpine-table-example-column-resizing-performant
- tanstack-alpine-table-example-column-sizing
- tanstack-alpine-table-example-column-visibility
- tanstack-alpine-table-example-custom-plugin
- tanstack-alpine-table-example-expanding
- tanstack-alpine-table-example-filters
- tanstack-alpine-table-example-filters-faceted
- tanstack-alpine-table-example-filters-faceted-bucketed
- tanstack-alpine-table-example-grouped-aggregation
- tanstack-alpine-table-example-grouping
- tanstack-alpine-table-example-header-groups
- tanstack-alpine-table-example-pagination
- tanstack-alpine-table-example-row-pinning
- tanstack-alpine-table-example-row-selection
- tanstack-alpine-table-example-sorting
- tanstack-alpine-table-example-sorting-dynamic-data
- tanstack-alpine-table-example-sub-components
- tanstack-angular-table-example-aggregation
- tanstack-angular-table-example-basic-app-table
- tanstack-angular-table-example-basic-dynamic-columns
- tanstack-angular-table-example-basic-external-atoms
- tanstack-angular-table-example-basic-external-state
- tanstack-angular-table-example-basic-inject-table
- tanstack-angular-table-example-cell-selection
- tanstack-angular-table-example-cell-spanning
- tanstack-angular-table-example-column-ordering
- tanstack-angular-table-example-column-pinning
- tanstack-angular-table-example-column-pinning-split
- tanstack-angular-table-example-column-pinning-sticky
- tanstack-angular-table-example-column-resizing
- tanstack-angular-table-example-column-resizing-performant
- tanstack-angular-table-example-column-sizing
- tanstack-angular-table-example-column-visibility
- tanstack-angular-table-example-composable-tables
- tanstack-angular-table-example-custom-plugin
- tanstack-angular-table-example-editable
- tanstack-angular-table-example-expanding
- tanstack-angular-table-example-filters
- tanstack-angular-table-example-filters-faceted
- tanstack-angular-table-example-filters-faceted-bucketed
- tanstack-angular-table-example-filters-fuzzy
- tanstack-angular-table-example-grouped-aggregation
- tanstack-angular-table-example-grouping
- tanstack-angular-table-example-header-groups
- tanstack-angular-table-example-kitchen-sink
- tanstack-angular-table-example-pagination
- tanstack-angular-table-example-remote-data
- tanstack-angular-table-example-row-dnd
- tanstack-angular-table-example-row-pinning
- tanstack-angular-table-example-row-selection
- tanstack-angular-table-example-row-selection-signal
- tanstack-angular-table-example-signal-input
- tanstack-angular-table-example-sorting
- tanstack-angular-table-example-sub-components
- tanstack-angular-table-example-virtualized-columns
- tanstack-angular-table-example-virtualized-infinite-scrolling
- tanstack-angular-table-example-virtualized-rows
- tanstack-angular-table-example-with-tanstack-form
- tanstack-angular-table-example-with-tanstack-query
- tanstack-lit-table-example-aggregation
- tanstack-lit-table-example-basic-app-table
- tanstack-lit-table-example-basic-dynamic-columns
- tanstack-lit-table-example-basic-external-atoms
- tanstack-lit-table-example-basic-external-state
- tanstack-lit-table-example-basic-subscribe
- tanstack-lit-table-example-basic-table-controller
- tanstack-lit-table-example-cell-selection
- tanstack-lit-table-example-cell-spanning
- tanstack-lit-table-example-column-ordering
- tanstack-lit-table-example-column-pinning
- tanstack-lit-table-example-column-pinning-split
- tanstack-lit-table-example-column-pinning-sticky
- tanstack-lit-table-example-column-resizing
- tanstack-lit-table-example-column-resizing-performant
- tanstack-lit-table-example-column-sizing
- tanstack-lit-table-example-column-visibility
- tanstack-lit-table-example-composable-tables
- tanstack-lit-table-example-expanding
- tanstack-lit-table-example-filters
- tanstack-lit-table-example-filters-faceted
- tanstack-lit-table-example-filters-faceted-bucketed
- tanstack-lit-table-example-filters-fuzzy
- tanstack-lit-table-example-grouped-aggregation
- tanstack-lit-table-example-grouping
- tanstack-lit-table-example-header-groups
- tanstack-lit-table-example-kitchen-sink
- tanstack-lit-table-example-pagination
- tanstack-lit-table-example-row-pinning
- tanstack-lit-table-example-row-selection
- tanstack-lit-table-example-sorting
- tanstack-lit-table-example-sorting-dynamic-data
- tanstack-lit-table-example-sub-components
- tanstack-lit-table-example-virtualized-columns
- tanstack-lit-table-example-virtualized-infinite-scrolling
- tanstack-lit-table-example-virtualized-rows
- tanstack-ember-table-example-aggregation
- tanstack-ember-table-example-basic-app-table
- tanstack-ember-table-example-basic-external-atoms
- tanstack-ember-table-example-basic-external-state
- tanstack-ember-table-example-basic-table
- tanstack-ember-table-example-cell-selection
- tanstack-ember-table-example-cell-spanning
- tanstack-ember-table-example-column-ordering
- tanstack-ember-table-example-column-pinning
- tanstack-ember-table-example-column-pinning-split
- tanstack-ember-table-example-column-pinning-sticky
- tanstack-ember-table-example-column-resizing
- tanstack-ember-table-example-column-resizing-performant
- tanstack-ember-table-example-column-sizing
- tanstack-ember-table-example-column-visibility
- tanstack-ember-table-example-custom-plugin
- tanstack-ember-table-example-editable
- tanstack-ember-table-example-expanding
- tanstack-ember-table-example-filters
- tanstack-ember-table-example-filters-faceted
- tanstack-ember-table-example-filters-faceted-bucketed
- tanstack-ember-table-example-filters-fuzzy
- tanstack-ember-table-example-grouped-aggregation
- tanstack-ember-table-example-grouping
- tanstack-ember-table-example-header-groups
- tanstack-ember-table-example-kitchen-sink
- tanstack-ember-table-example-pagination
- tanstack-ember-table-example-remote-data
- tanstack-ember-table-example-row-dnd
- tanstack-ember-table-example-row-pinning
- tanstack-ember-table-example-row-selection
- tanstack-ember-table-example-sorting
- tanstack-ember-table-example-sub-components
- @tanstack/octane-table-example-aggregation
- tanstack-octane-table-example-basic-dynamic-columns
- tanstack-octane-table-example-basic-external-atoms
- tanstack-octane-table-example-basic-external-state
- tanstack-octane-table-example-basic-subscribe
- tanstack-octane-table-example-basic-use-app-table
- tanstack-octane-table-example-basic-use-table
- @tanstack/octane-table-example-cell-spanning
- @tanstack/octane-table-example-column-ordering
- @tanstack/octane-table-example-column-pinning
- @tanstack/octane-table-example-column-pinning-split
- @tanstack/octane-table-example-column-pinning-sticky
- @tanstack/octane-table-example-column-resizing
- @tanstack/octane-table-example-column-resizing-performant
- @tanstack/octane-table-example-column-sizing
- @tanstack/octane-table-example-column-visibility
- @tanstack/octane-table-example-composable-tables
- @tanstack/octane-table-example-custom-plugin
- @tanstack/octane-table-example-expanding
- @tanstack/octane-table-example-filters
- @tanstack/octane-table-example-filters-faceted
- @tanstack/octane-table-example-filters-faceted-bucketed
- @tanstack/octane-table-example-filters-fuzzy
- @tanstack/octane-table-example-grouped-aggregation
- @tanstack/octane-table-example-grouping
- @tanstack/octane-table-example-header-groups
- @tanstack/octane-table-example-kitchen-sink
- @tanstack/octane-table-example-pagination
- @tanstack/octane-table-example-row-pinning
- @tanstack/octane-table-example-row-selection
- @tanstack/octane-table-example-sorting
- @tanstack/octane-table-example-sub-components
- tanstack-preact-table-example-aggregation
- tanstack-preact-table-example-basic-dynamic-columns
- tanstack-preact-table-example-basic-external-atoms
- tanstack-preact-table-example-basic-external-state
- tanstack-preact-table-example-basic-subscribe
- tanstack-preact-table-example-basic-use-app-table
- tanstack-preact-table-example-basic-use-table
- tanstack-preact-table-example-cell-selection
- tanstack-preact-table-example-cell-spanning
- tanstack-preact-table-example-column-ordering
- tanstack-preact-table-example-column-pinning
- tanstack-preact-table-example-column-pinning-split
- tanstack-preact-table-example-column-pinning-sticky
- tanstack-preact-table-example-column-resizing
- tanstack-preact-table-example-column-resizing-performant
- tanstack-preact-table-example-column-sizing
- tanstack-preact-table-example-column-visibility
- tanstack-preact-table-example-composable-tables
- tanstack-preact-table-example-custom-plugin
- tanstack-preact-table-example-expanding
- tanstack-preact-table-example-filters
- tanstack-preact-table-example-filters-faceted
- tanstack-preact-table-example-filters-faceted-bucketed
- tanstack-preact-table-example-filters-fuzzy
- tanstack-preact-table-example-grouped-aggregation
- tanstack-preact-table-example-grouping
- tanstack-preact-table-example-header-groups
- tanstack-preact-table-example-kitchen-sink
- tanstack-preact-table-example-pagination
- tanstack-preact-table-example-row-pinning
- tanstack-preact-table-example-row-selection
- tanstack-preact-table-example-sorting
- tanstack-preact-table-example-sub-components
- tanstack-preact-table-example-with-tanstack-form
- tanstack-preact-table-example-with-tanstack-query
- tanstack-solid-table-example-aggregation
- tanstack-solid-table-example-basic-app-table
- tanstack-solid-table-example-basic-dynamic-columns
- tanstack-solid-table-example-basic-external-atoms
- tanstack-solid-table-example-basic-external-state
- tanstack-solid-table-example-basic-use-table
- tanstack-solid-table-example-cell-selection
- tanstack-solid-table-example-cell-spanning
- tanstack-solid-table-example-column-ordering
- tanstack-solid-table-example-column-pinning
- tanstack-solid-table-example-column-pinning-split
- tanstack-solid-table-example-column-pinning-sticky
- tanstack-solid-table-example-column-resizing
- tanstack-solid-table-example-column-resizing-performant
- tanstack-solid-table-example-column-sizing
- tanstack-solid-table-example-column-visibility
- tanstack-solid-table-example-composable-tables
- tanstack-solid-table-example-expanding
- tanstack-solid-table-example-filters
- tanstack-solid-table-example-filters-faceted
- tanstack-solid-table-example-filters-faceted-bucketed
- tanstack-solid-table-example-filters-fuzzy
- tanstack-solid-table-example-grouped-aggregation
- tanstack-solid-table-example-grouping
- tanstack-solid-table-example-header-groups
- tanstack-solid-table-example-kitchen-sink
- tanstack-solid-table-example-pagination
- tanstack-solid-table-example-row-pinning
- tanstack-solid-table-example-row-selection
- tanstack-solid-table-example-sorting
- tanstack-solid-table-example-spreadsheet
- tanstack-solid-table-example-sub-components
- tanstack-solid-table-example-virtualized-columns
- tanstack-solid-table-example-virtualized-infinite-scrolling
- tanstack-solid-table-example-virtualized-rows
- tanstack-solid-table-example-with-tanstack-form
- tanstack-solid-table-example-with-tanstack-query
- tanstack-solid-table-example-with-tanstack-router
- tanstack-react-table-example-aggregation
- tanstack-react-table-example-basic-dynamic-columns
- tanstack-react-table-example-basic-external-atoms
- tanstack-react-table-example-basic-external-state
- tanstack-react-table-example-basic-subscribe
- tanstack-react-table-example-basic-use-app-table
- tanstack-react-table-example-basic-use-legacy-table
- tanstack-react-table-example-basic-use-table
- tanstack-react-table-example-cell-selection
- tanstack-react-table-example-cell-spanning
- tanstack-react-table-example-column-dnd
- tanstack-react-table-example-column-ordering
- tanstack-react-table-example-column-pinning
- tanstack-react-table-example-column-pinning-split
- tanstack-react-table-example-column-pinning-sticky
- tanstack-react-table-example-column-resizing
- tanstack-react-table-example-column-resizing-performant
- tanstack-react-table-example-column-sizing
- tanstack-react-table-example-column-visibility
- tanstack-react-table-example-composable-tables
- tanstack-react-table-example-custom-plugin
- tanstack-react-table-example-expanding
- tanstack-react-table-example-filters
- tanstack-react-table-example-filters-faceted
- tanstack-react-table-example-filters-faceted-bucketed
- tanstack-react-table-example-filters-fuzzy
- tanstack-react-table-example-grouped-aggregation
- tanstack-react-table-example-grouping
- tanstack-react-table-example-header-groups
- tanstack-react-table-example-kitchen-sink
- tanstack-react-table-example-kitchen-sink-chakra-ui
- tanstack-react-table-example-kitchen-sink-hero-ui
- tanstack-react-table-example-kitchen-sink-mantine
- tanstack-react-table-example-kitchen-sink-material-ui
- tanstack-react-table-example-kitchen-sink-react-aria
- tanstack-react-table-example-kitchen-sink-shadcn-base
- tanstack-react-table-example-kitchen-sink-shadcn-radix
- tanstack-react-table-example-lib-chakra-ui
- tanstack-react-table-example-lib-hero-ui
- tanstack-react-table-example-lib-mantine
- tanstack-react-table-example-lib-material-ui
- tanstack-react-table-example-lib-react-aria
- tanstack-react-table-example-lib-shadcn-base
- tanstack-react-table-example-lib-shadcn-radix
- tanstack-react-table-example-mantine-react-table
- tanstack-react-table-example-material-react-table
- tanstack-react-table-example-pagination
- tanstack-react-table-example-row-dnd
- tanstack-react-table-example-row-pinning
- tanstack-react-table-example-row-selection
- tanstack-react-table-example-sorting
- tanstack-react-table-example-spreadsheet
- tanstack-react-table-example-sub-components
- tanstack-react-table-example-virtualized-columns
- tanstack-react-table-example-virtualized-columns-experimental
- tanstack-react-table-example-virtualized-infinite-scrolling
- tanstack-react-table-example-virtualized-rows
- tanstack-react-table-example-virtualized-rows-experimental
- tanstack-react-table-example-web-worker-row-models
- tanstack-react-table-example-with-tanstack-form
- tanstack-react-table-example-with-tanstack-query
- tanstack-react-table-example-with-tanstack-router
- tanstack-vanilla-table-example-aggregation
- tanstack-vanilla-table-example-basic
- tanstack-vanilla-table-example-pagination
- tanstack-vanilla-table-example-sorting
- tanstack-svelte-table-example-aggregation
- tanstack-svelte-table-example-basic-app-table
- tanstack-svelte-table-example-basic-create-table
- tanstack-svelte-table-example-basic-dynamic-columns
- tanstack-svelte-table-example-basic-external-atoms
- tanstack-svelte-table-example-basic-external-state
- tanstack-svelte-table-example-basic-snippets
- tanstack-svelte-table-example-cell-selection
- tanstack-svelte-table-example-cell-spanning
- tanstack-svelte-table-example-column-ordering
- tanstack-svelte-table-example-column-pinning
- tanstack-svelte-table-example-column-pinning-split
- tanstack-svelte-table-example-column-pinning-sticky
- tanstack-svelte-table-example-column-resizing
- tanstack-svelte-table-example-column-resizing-performant
- tanstack-svelte-table-example-column-sizing
- tanstack-svelte-table-example-column-visibility
- tanstack-svelte-table-example-composable-tables
- tanstack-svelte-table-example-expanding
- tanstack-svelte-table-example-filtering
- tanstack-svelte-table-example-filters-faceted
- tanstack-svelte-table-example-filters-faceted-bucketed
- tanstack-svelte-table-example-filters-fuzzy
- tanstack-svelte-table-example-grouped-aggregation
- tanstack-svelte-table-example-grouping
- tanstack-svelte-table-example-header-groups
- tanstack-svelte-table-example-kitchen-sink
- tanstack-svelte-table-example-kitchen-sink-shadcn
- tanstack-svelte-table-example-lib-shadcn
- tanstack-svelte-table-example-pagination
- tanstack-svelte-table-example-row-pinning
- tanstack-svelte-table-example-row-selection
- tanstack-svelte-table-example-sorting
- tanstack-svelte-table-example-spreadsheet
- tanstack-svelte-table-example-sub-components
- tanstack-svelte-table-example-virtualized-columns
- tanstack-svelte-table-example-virtualized-infinite-scrolling
- tanstack-svelte-table-example-virtualized-rows
- tanstack-svelte-table-example-with-tanstack-form
- tanstack-svelte-table-example-with-tanstack-query
- tanstack-vue-table-example-aggregation
- tanstack-vue-table-example-basic-dynamic-columns
- tanstack-vue-table-example-basic-external-atoms
- tanstack-vue-table-example-basic-external-state
- tanstack-vue-table-example-basic-use-app-table
- tanstack-vue-table-example-basic-use-table
- tanstack-vue-table-example-cell-selection
- tanstack-vue-table-example-cell-spanning
- tanstack-vue-table-example-column-ordering
- tanstack-vue-table-example-column-pinning
- tanstack-vue-table-example-column-pinning-split
- tanstack-vue-table-example-column-pinning-sticky
- tanstack-vue-table-example-column-resizing
- tanstack-vue-table-example-column-resizing-performant
- tanstack-vue-table-example-column-sizing
- tanstack-vue-table-example-column-visibility
- tanstack-vue-table-example-composable-tables
- tanstack-vue-table-example-expanding
- tanstack-vue-table-example-filters
- tanstack-vue-table-example-filters-faceted
- tanstack-vue-table-example-filters-faceted-bucketed
- tanstack-vue-table-example-filters-fuzzy
- tanstack-vue-table-example-grouped-aggregation
- tanstack-vue-table-example-grouping
- tanstack-vue-table-example-header-groups
- tanstack-vue-table-example-kitchen-sink
- tanstack-vue-table-example-kitchen-sink-shadcn
- tanstack-vue-table-example-lib-shadcn
- tanstack-vue-table-example-pagination
- tanstack-vue-table-example-row-pinning
- tanstack-vue-table-example-row-selection
- tanstack-vue-table-example-sorting
- tanstack-vue-table-example-sub-components
- tanstack-vue-table-example-virtualized-columns
- tanstack-vue-table-example-virtualized-infinite-scrolling
- tanstack-vue-table-example-virtualized-rows
- tanstack-vue-table-example-with-tanstack-form
- tanstack-vue-table-example-with-tanstack-query
@tanstack/alpine-table
npm i https://pkg.pr.new/@tanstack/alpine-table@6529@tanstack/angular-table
npm i https://pkg.pr.new/@tanstack/angular-table@6529@tanstack/angular-table-devtools
npm i https://pkg.pr.new/@tanstack/angular-table-devtools@6529@tanstack/ember-table
npm i https://pkg.pr.new/@tanstack/ember-table@6529@tanstack/lit-table
npm i https://pkg.pr.new/@tanstack/lit-table@6529@tanstack/match-sorter-utils
npm i https://pkg.pr.new/@tanstack/match-sorter-utils@6529@tanstack/octane-table
npm i https://pkg.pr.new/@tanstack/octane-table@6529@tanstack/preact-table
npm i https://pkg.pr.new/@tanstack/preact-table@6529@tanstack/preact-table-devtools
npm i https://pkg.pr.new/@tanstack/preact-table-devtools@6529@tanstack/react-table
npm i https://pkg.pr.new/@tanstack/react-table@6529@tanstack/react-table-devtools
npm i https://pkg.pr.new/@tanstack/react-table-devtools@6529@tanstack/solid-table
npm i https://pkg.pr.new/@tanstack/solid-table@6529@tanstack/solid-table-devtools
npm i https://pkg.pr.new/@tanstack/solid-table-devtools@6529@tanstack/svelte-table
npm i https://pkg.pr.new/@tanstack/svelte-table@6529@tanstack/table-core
npm i https://pkg.pr.new/@tanstack/table-core@6529@tanstack/table-devtools
npm i https://pkg.pr.new/@tanstack/table-devtools@6529@tanstack/vue-table
npm i https://pkg.pr.new/@tanstack/vue-table@6529@tanstack/vue-table-devtools
npm i https://pkg.pr.new/@tanstack/vue-table-devtools@6529commit:
726f21bKevinVandy merged this269e0d8
KevinVandy closed this
Sign in to join this conversation.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID:
9c76e16a-2941-4c22-b7ec-bcc8b5910eb1📥 Commits
Reviewing files that changed from the base of the PR and between 794da817f531678ae8958e02b42da8ad661cd76e and 726f21bed94cbdee569b2b448852249aec446f95.
📒 Files selected for processing (6)
.changeset/great-pugs-sniff.mdpackages/table-core/src/worker/createWorkerRowModel.tspackages/table-core/src/worker/rebuildRowModel.tspackages/table-core/tests/implementation/features/row-sorting/createSortedRowModel.test.tspackages/table-core/tests/unit/worker/serializeRebuild.test.tsperf-done.md🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough
Walkthrough#
The sorted row model now keeps parent rows before descendants in
flatRows. Worker rebuilding uses explicit stages to preserve this ordering and depth behavior. Tests cover nested sorting, grouped worker round trips, and row identity.Changes#
Sorted flat-row ordering
packages/table-core/src/features/row-sorting/createSortedRowModel.tssortDatareserves each parent position before sorting descendants and replaces it with a cloned branch row when needed.packages/table-core/src/worker/createWorkerRowModel.ts,packages/table-core/src/worker/rebuildRowModel.tsTableWorkerStage. Sorted stages reserve synthetic group-row positions, while depth resets remain stage-specific.packages/table-core/tests/implementation/features/row-sorting/createSortedRowModel.test.ts,packages/table-core/tests/unit/worker/serializeRebuild.test.ts,.changeset/great-pugs-sniff.md,perf-done.mdEstimated code review effort: 3 (Moderate) | ~25 minutes
Suggested reviewers:
kevinvandy🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share