Skip to content
Source
Sign inSign up
TanStack/table

table-core 9.2.5+: private types leak from .d.ts files, declaration emit fails with TS2883 #6619

Send to my agent
Closedcoldsmirk(GitHub profile, opens in a new tab) opened this issue 0 comments

TanStack Table version

@tanstack/table-core 9.2.6 (since 9.2.5; 9.2.4 is fine)

Framework/Library version

TypeScript 6.0.3 (framework-agnostic)

Describe the bug and the steps to reproduce it

Declaration emit in a consumer fails since 9.2.5:

index.ts(3,14): error TS2883: The inferred type of 'min' cannot be named without a reference to 'RangeValue' from './node_modules/@tanstack/table-core/dist/features/row-aggregation/aggregationFns.js'. This is likely not portable. A type annotation is necessary.

npm i @tanstack/table-core@9.2.6 typescript@6.0.3, then tsc -p .:

{ "compilerOptions": { "module": "NodeNext", "moduleResolution": "NodeNext", "declaration": true, "emitDeclarationOnly": true, "outDir": "out" } }
import { aggregationFn_min } from '@tanstack/table-core'

export const min = aggregationFn_min

Cause: since 9.2.5 the .d.ts files no longer end with export { … } (rolldown-plugin-dts 0.28.2+ inlines the exports). A declaration file without any export statement makes TypeScript treat every top-level declaration as exported, so private aliases such as RangeValue become referable, but only through a deep path the package exports map blocks. In 9.2.6 that is 24 private declarations across 9 files.

Appending export {}; to aggregationFns.d.ts fixes the repro, and the emitted type inlines (number | Date) | undefined as with 9.2.4.

Suggested fix until the bundler fix lands (sxzz/rolldown-plugin-dts#312, PR sxzz/rolldown-plugin-dts#310): let scripts/rewrite-table-core-dts.mjs append export {}; to declaration files that have no export {…}, export * or export =. tests/declaration-emit imports from src, so a check against the built dist through the package exports would catch this.

Inline above. The TS Playground does not reproduce it: its fetched types ignore the exports map.

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
  1. KevinVandy closed this

Sign in to join this conversation.