fix(angular-virtual): RuntimeError: NG0600: Writing to signals is not allowed in a computed or an effect by default #1109
ClosedStallion8472(GitHub profile, opens in a new tab)wants to merge 2 commits into
main fromrefs/pull/1109/headopened - packages/angular-virtual/src/index.ts lines 56 to 57@@ -36,0 +37,21 @@37+ const isScrolling = signal(instance.isScrolling)38+ const range = signal(instance.range, { equal: () => false })39+ const scrollDirection = signal(instance.scrollDirection)40+ const scrollElement = signal(instance.scrollElement)41+ const scrollOffset = signal(instance.scrollOffset)42+ const scrollRect = signal(instance.scrollRect)43+44+ const handler = {45+ get(46+ target: Virtualizer<TScrollElement, TItemElement>,47+ prop: keyof Virtualizer<TScrollElement, TItemElement>,48+ ) {49+ switch (prop) {50+ case 'getVirtualItems':51+ return virtualItems52+ case 'getTotalSize':53+ return totalSize54+ case 'isScrolling':55+ return isScrolling56+ case 'options':57+ return optionspackages/angular-virtual/src/index.ts line 95@@ -43,12 +80,16 @@4380 () => {4481 const _options = options()45- lazyInit()46- virtualizerSignal.set(virtualizer)47- virtualizer.setOptions({82+ instance.setOptions({4883 ..._options,4984 onChange: (instance, sync) => {50- // update virtualizerSignal so that dependent computeds recompute.51- virtualizerSignal.set(instance)85+ virtualItems.set(instance.getVirtualItems())86+ totalSize.set(instance.getTotalSize())87+ isScrolling.set(instance.isScrolling)88+ range.set(instance.range)89+ scrollDirection.set(instance.scrollDirection)90+ scrollElement.set(instance.scrollElement)91+ scrollOffset.set(instance.scrollOffset)92+ scrollRect.set(instance.scrollRect)5293 _options.onChange?.(instance, sync)5394 },5495 })packages/angular-virtual/src/index.ts line 67@@ -36,0 +47,21 @@47+ prop: keyof Virtualizer<TScrollElement, TItemElement>,48+ ) {49+ switch (prop) {50+ case 'getVirtualItems':51+ return virtualItems52+ case 'getTotalSize':53+ return totalSize54+ case 'isScrolling':55+ return isScrolling56+ case 'options':57+ return options58+ case 'range':59+ return range60+ case 'scrollDirection':61+ return scrollDirection62+ case 'scrollElement':63+ return scrollElement64+ case 'scrollOffset':65+ return scrollOffset66+ case 'scrollRect':67+ return scrollRect
benjavicente(GitHub profile, opens in a new tab) requested changes
packages/angular-virtual/src/index.ts line 31@@ -30,7 +28,4 @@3028 >(3129 options: Signal<VirtualizerOptions<TScrollElement, TItemElement>>,3230 ): AngularVirtualizer<TScrollElement, TItemElement> {33- let virtualizer: Virtualizer<TScrollElement, TItemElement>34- function lazyInit() {35- virtualizer ??= new Virtualizer(options())36- return virtualizer31+ const instance = new Virtualizer<TScrollElement, TItemElement>(options())packages/angular-virtual/src/index.ts line 92@@ -40,12 +78,15 @@407841- // two-way sync options4279 effect(4380 () => {4481 const _options = options()45- lazyInit()46- virtualizerSignal.set(virtualizer)47- virtualizer.setOptions({82+ instance.setOptions({4883 ..._options,4984 onChange: (instance, sync) => {50- // update virtualizerSignal so that dependent computeds recompute.51- virtualizerSignal.set(instance)85+ virtualItems.set(instance.getVirtualItems())86+ totalSize.set(instance.getTotalSize())87+ isScrolling.set(instance.isScrolling)88+ range.set(instance.range)89+ scrollDirection.set(instance.scrollDirection)90+ scrollElement.set(instance.scrollElement)91+ scrollOffset.set(instance.scrollOffset)92+ scrollRect.set(instance.scrollRect)piecyk closed this
Sign in to join this conversation.
🦋 Changeset detected#
Latest commit: fae1553f2ef5217a0ddcde71977abc30448ba464
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR