fix(solid-virtual): preserve measurements on option updates #1203
MergedHona(GitHub profile, opens in a new tab)merged 2 commits into
main fromrefs/pull/1203/headmerged by piecyk - Resolvedby Hona(GitHub profile, opens in a new tab)@@ -81,4 +81,6 @@8181 },8282 }),8383 )84- virtualizer.measure()84+ virtualizer._willUpdate()85+ setVirtualItems(reconcile(instance.getVirtualItems(), { key: 'index' }))86+ setTotalSize(instance.getTotalSize())Resolvedby Hona(GitHub profile, opens in a new tab)@@ -26,3 +26,5 @@2626 "clean": "premove ./dist ./coverage",2727 "test:eslint": "eslint ./src",2828 "test:types": "tsc",29+ "test:lib": "vitest",30+ "test:lib:dev": "pnpm run test:lib --watch",Resolvedby Hona(GitHub profile, opens in a new tab)@@ -0,0 +7,21 @@7+ createRoot((dispose) => {8+ const [count, setCount] = createSignal(2)9+ const virtualizer = createVirtualizer<HTMLDivElement, HTMLDivElement>({10+ get count() {11+ return count()12+ },13+ getScrollElement: () => null,14+ estimateSize: () => 60,15+ initialRect: { width: 800, height: 600 },16+ })17+18+ expect(virtualizer.getTotalSize()).toBe(120)19+ virtualizer.resizeItem(0, 100)20+ expect(virtualizer.getTotalSize()).toBe(160)21+22+ setCount(3)23+24+ expect(virtualizer.itemSizeCache.get(0)).toBe(100)25+ expect(virtualizer.getTotalSize()).toBe(220)26+ dispose()27+ })Resolvedby Hona(GitHub profile, opens in a new tab)@@ -0,0 +4,21 @@4+import { createVirtualizer } from '../src/index'5+6+test('preserves measured sizes when reactive options change', () => {7+ createRoot((dispose) => {8+ const [count, setCount] = createSignal(2)9+ const virtualizer = createVirtualizer<HTMLDivElement, HTMLDivElement>({10+ get count() {11+ return count()12+ },13+ getScrollElement: () => null,14+ estimateSize: () => 60,15+ initialRect: { width: 800, height: 600 },16+ })17+18+ expect(virtualizer.getTotalSize()).toBe(120)19+ virtualizer.resizeItem(0, 100)20+ expect(virtualizer.getTotalSize()).toBe(160)21+22+ setCount(3)23+24+ expect(virtualizer.itemSizeCache.get(0)).toBe(100)
piecyk merged this95ef53b
piecyk closed this
Sign in to join this conversation.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
b93b3e32-99d2-4b7b-a685-06fe5b37a2e6📥 Commits
Reviewing files that changed from the base of the PR and between 2346cc5de185e81a4ec71388b7c31f9b65dd31c0 and 3d8b455aec4d0886ab6bbf770e553f579c997c02.
📒 Files selected for processing (1)
packages/solid-virtual/package.json✅ Files skipped from review due to trivial changes (1)
📝 Walkthrough
Walkthrough#
createVirtualizerBasenow refreshes Solid state with_willUpdate(),reconcile, andtotalSizeupdates instead of callingmeasure(). The PR also adds a regression test, test scripts, and a patch changeset.Changes#
Preserve measured sizes on reactive option update
packages/solid-virtual/src/index.tsx,packages/solid-virtual/package.json,packages/solid-virtual/tests/index.test.tsvirtualizer.measure()withinstance._willUpdate(),setVirtualItems(reconcile(instance.getVirtualItems(), { key: 'index' })), andsetTotalSize(instance.getTotalSize())in theonChangehandler. Addstest:libandtest:lib:devnpm scripts. A Vitest regression test verifies measured sizes persist after a reactivecountupdate..changeset/quiet-cats-preserve.md@tanstack/solid-virtualatpatchlevel, noting preserved measured item sizes on reactive option changes.Estimated code review effort: 2 (Simple) | ~10 minutes
Possibly related PRs
Suggested reviewers:
piecyk🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (2 warnings)#
✅ Passed checks (3 passed)
#1197by replacing measure() invalidation with lifecycle updates and explicit Solid state publication.✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share