Open History to see the last commit
1import "~/index.css";
2import { EnvironmentId, ProjectId } from "@t3tools/contracts";
3import { sourceControlClients } from "@t3tools/client-runtime/source-control-clients";
4import { Cause } from "effect";
5import { expect, it, vi } from "vite-plus/test";
6import { page } from "vite-plus/test/browser";
7
8const mocks = vi.hoisted(() => ({
9 update:
10 vi.fn<(input: unknown) => Promise<{ _tag: "Success" } | { _tag: "Failure"; cause: unknown }>>(),
11 notify: vi.fn(),
12}));
13vi.mock(
14 import("~/state/pullRequests"),
15 () => ({ pullRequestEnvironment: { update: {} } }) as never,
16);
17vi.mock(
18 import("~/state/use-atom-command"),
19 () => ({ useAtomCommand: () => mocks.update }) as never,
20);
21
22vi.mock(import("../ui/toast"), () => ({ toastManager: { add: mocks.notify } }) as never);
23vi.mock(import("~/state/server"), async () => {
24 const { Atom } = await import("effect/reactivity");
25 return { primaryServerKeybindingsAtom: Atom.make([]) } as never;
26});
27vi.mock(import("./PullRequestThreadLinks"), () => ({ PullRequestThreadLinks: () => null }));
28vi.mock(
29 import("./PullRequestDetailActions"),
30 () => ({ ActOnEnvironmentPicker: () => null }) as never,
31);
32
33import { render } from "../../../test/render";
34import { PullRequestActionsMenu } from "./PullRequestActionsMenu";
35
36const reference = { projectId: ProjectId.make("project"), repository: "owner/repo", number: 7 };
37const environmentId = EnvironmentId.make("environment");
38
39type Detail = Parameters<typeof PullRequestActionsMenu>[0]["detail"];
40
41const openDetail: Detail = {
42 url: "https://github.com/owner/repo/pull/7",
43 state: "open",
44 isDraft: false,
45 headBranch: "feature",
46 maintainerCanModify: true,
47 observedAt: 1,
48 capabilities: {
49 diff: true,
50 comment: true,
51 actions: [],
52 mergeMethods: [],
53 search: true,
54 review: { inlineComment: true, reply: true, resolve: true, verdicts: [] },
55 reviewers: { request: true, listCandidates: true },
56 edit: { changeRequest: true, comment: true, maintainerEdits: true },
57 },
58 viewerPermissions: {
59 actions: [],
60 comment: true,
61 resolve: true,
62 verdicts: [],
63 requestReviewers: true,
64 maintainerEdits: true,
65 },
66};
67
68function setup() {
69 mocks.update.mockReset().mockResolvedValue({ _tag: "Success" });
70 mocks.notify.mockReset();
71 return (detail: Detail = openDetail) => (
72 <PullRequestActionsMenu
73 environmentId={environmentId}
74 reference={reference}
75 pullRequestKey="owner/repo/7"
76 detail={detail}
77 terminology={sourceControlClients.get("github").changeRequest}
78 linkThreadRef={null}
79 onThreadPickerOpenChange={() => {}}
80 refreshing={false}
81 refreshFromHost={async () => {}}
82 handoff={null}
83 attachesToComposer={false}
84 askAboutPullRequest={() => {}}
85 explainPullRequest={() => {}}
86 canFixFindings={false}
87 startFixFindings={() => {}}
88 handoffLabels={{ fixFindings: "Fix review findings" }}
89 canWriteGuide={false}
90 guideRunning={false}
91 guideWritten={false}
92 writeGuide={() => {}}
93 pickableEnvironments={[]}
94 actingEnvironmentId={environmentId}
95 onActingEnvironmentChange={() => {}}
96 can={() => false}
97 autoMergeArmed={false}
98 showsDraftToggle={false}
99 showsMergeNow={false}
100 showsAutoMerge={false}
101 showsMergeMethods={false}
102 allowedMergeMethods={[]}
103 selectedMergeMethod="squash"
104 onSelectMergeMethod={() => {}}
105 showsDeleteBranch={false}
106 environmentConnected={true}
107 canWriteSourceControl={true}
108 onMaintainerEditsSaved={() => {}}
109 confirmDeleteBranch={async () => {}}
110 pendingAction={null}
111 perform={async () => true}
112 openOnHostText="Open on GitHub"
113 copyReference={() => {}}
114 />
115 );
116}
117
118it("saves maintainer edits, locks while saving, and restores the saved value when a save fails", async () => {
119 const control = setup();
120 await using screen = await render(control());
121 await screen.getByRole("button", { name: "More pull request actions" }).click();
122 const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" });
123 await expect.element(checkbox).toBeChecked();
124 await checkbox.click();
125 await expect.element(page.getByRole("status")).not.toBeInTheDocument();
126 expect(mocks.update).toHaveBeenCalledExactlyOnceWith({
127 environmentId,
128 input: { ...reference, maintainerCanModify: false },
129 });
130
131 let settle!: (value: { _tag: "Failure"; cause: unknown }) => void;
132 mocks.update.mockReturnValueOnce(
133 new Promise((resolve) => {
134 settle = resolve;
135 }),
136 );
137 await checkbox.click();
138 await expect.element(checkbox).toBeChecked();
139 await expect.element(checkbox).toBeDisabled();
140 await expect.element(page.getByRole("status")).toHaveTextContent("Saving…");
141 settle({
142 _tag: "Failure",
143 cause: Cause.fail(new Error("Resource not accessible by integration")),
144 });
145 await expect.element(checkbox).not.toBeChecked();
146 expect(mocks.notify).toHaveBeenCalledExactlyOnceWith(
147 expect.objectContaining({
148 type: "error",
149 title: "Could not save maintainer access",
150 description: "Resource not accessible by integration",
151 }),
152 );
153});
154
155it("keeps a saved choice through a stale refresh, then follows the host", async () => {
156 const control = setup();
157 await using screen = await render(control());
158 await screen.getByRole("button", { name: "More pull request actions" }).click();
159 const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" });
160 let settle!: (value: { _tag: "Success" }) => void;
161 mocks.update.mockReturnValueOnce(
162 new Promise((resolve) => {
163 settle = resolve;
164 }),
165 );
166 await checkbox.click();
167 await screen.rerender(control({ ...openDetail, observedAt: 2 }));
168 settle({ _tag: "Success" });
169 await expect.element(page.getByRole("status")).not.toBeInTheDocument();
170 await screen.rerender(control({ ...openDetail, observedAt: 2 }));
171 await expect.element(checkbox).not.toBeChecked();
172 await screen.rerender(control({ ...openDetail, maintainerCanModify: false, observedAt: 3 }));
173 await expect.element(checkbox).not.toBeChecked();
174 await screen.rerender(control({ ...openDetail, maintainerCanModify: true, observedAt: 4 }));
175 await expect.element(checkbox).toBeChecked();
176});
177
178it("follows the host's first reading after a save, even when it matches the old value", async () => {
179 const control = setup();
180 await using screen = await render(control());
181 await screen.getByRole("button", { name: "More pull request actions" }).click();
182 const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" });
183 await checkbox.click();
184 await expect.element(page.getByRole("status")).not.toBeInTheDocument();
185 await expect.element(checkbox).not.toBeChecked();
186 await screen.rerender(control({ ...openDetail, observedAt: 2 }));
187 await expect.element(checkbox).toBeChecked();
188});
189
190it.each<[string, Detail]>([
191 ["closed", { ...openDetail, state: "closed" }],
192 [
193 "not authored by the viewer",
194 {
195 ...openDetail,
196 viewerPermissions: { ...openDetail.viewerPermissions, maintainerEdits: false },
197 },
198 ],
199 [
200 "on a host without maintainer edits",
201 {
202 ...openDetail,
203 capabilities: { ...openDetail.capabilities, edit: { changeRequest: true, comment: true } },
204 },
205 ],
206])("hides maintainer edits on a pull request that is %s", async (_, detail) => {
207 const control = setup();
208 await using screen = await render(control(detail));
209 await screen.getByRole("button", { name: "More pull request actions" }).click();
210 await expect.element(page.getByRole("menuitem", { name: "Open on GitHub" })).toBeVisible();
211 expect(document.querySelector('[role="menuitemcheckbox"]')).toBeNull();
212});