Skip to content
Source
Sign inSign up
pingdotgg/t3code
Open History to see the last commit

PullRequestGuideTab.browser.test.tsx

188 lines6.1 KB

1import {
2 EnvironmentId,
3 ProjectId,
4 type PullRequestRef,
5 type PullRequestReviewGuide,
6} from "@t3tools/contracts";
7import { expect, it, vi } from "vite-plus/test";
8import { userEvent } from "vite-plus/test/browser";
9​
10vi.mock(import("./guide/useReviewGuideWriter"), () => ({ useReviewGuideWriter: vi.fn() }));
11vi.mock(import("./guide/useGuideDiffFiles"), () => ({
12 useGuideDiffFiles: () => ({ files: new Map(), loading: false, error: null, retry: () => {} }),
13}));
14​
15import { render } from "../../../test/render";
16import type { ChatComposerHandle } from "../chat/ChatComposer";
17import { useChatShortcuts } from "../chat/useChatShortcuts";
18import { useReviewGuideWriter } from "./guide/useReviewGuideWriter";
19import { PullRequestGuideTab } from "./PullRequestGuideTab";
20​
21const reference: PullRequestRef = {
22 projectId: ProjectId.make("project"),
23 repository: "owner/repo",
24 number: 1,
25};
26​
27const verboseFailure = [
28 "Codex CLI command failed: OpenAI Codex v0.164.0",
29 ...Array.from({ length: 200 }, (_, line) => `prompt line ${line}: read the change in order`),
30 "ERROR: provider auth command `sh` timed out after 5000 ms",
31].join("\n");
32​
33it("keeps Try again inside a short panel when a failed guide has long diagnostics", async () => {
34 const write = vi.fn(async () => {});
35 vi.mocked(useReviewGuideWriter).mockReturnValue({
36 query: { isPending: false, error: null } as never,
37 data: {
38 guide: null,
39 run: {
40 _tag: "Failed",
41 headSha: "head",
42 failedAt: "2026-10-27T16:37:47.661Z",
43 detail: verboseFailure,
44 },
45 currentHeadSha: "head",
46 },
47 running: false,
48 canWrite: true,
49 write,
50 });
51 const panel = document.createElement("div");
52 panel.style.cssText = "position: relative; width: 480px; height: 360px; overflow: hidden";
53 const tab = document.createElement("div");
54 tab.style.cssText = "position: absolute; inset: 0";
55 panel.append(tab);
56 document.body.append(panel);
57 using _panel = { [Symbol.dispose]: () => panel.remove() };
58​
59 await using screen = await render(
60 <PullRequestGuideTab
61 environmentId={EnvironmentId.make("environment")}
62 reference={reference}
63 title="Test pull request"
64 workspaceRoot="/workspace"
65 active
66 canComment={false}
67 rangeComments={false}
68 completionScope={null}
69 onAskAboutLines={null}
70 onAskAboutStop={null}
71 onFinishReview={null}
72 onOpenFile={() => {}}
73 />,
74 { container: tab },
75 );
76​
77 const retry = screen.getByRole("button", { name: "Try again" });
78 await expect.element(retry).toBeVisible();
79 const panelBox = panel.getBoundingClientRect();
80 const retryBox = retry.element().getBoundingClientRect();
81 expect(retryBox.top).toBeGreaterThanOrEqual(panelBox.top);
82 expect(retryBox.bottom).toBeLessThanOrEqual(panelBox.bottom);
83​
84 await userEvent.click(retry);
85 expect(write).toHaveBeenCalledOnce();
86});
87​
88const threeStopGuide: PullRequestReviewGuide = {
89 headSha: "head",
90 generatedAt: "2026-11-07T00:00:00.000Z",
91 modelSelection: { instanceId: "codex", model: "gpt-6.1-sol" } as never,
92 stops: ["First", "Second", "Third"].map((title) => ({
93 title,
94 summary: `Prose for the ${title.toLowerCase()} stop.`,
95 attention: null,
96 excerpts: [],
97 files: [],
98 notes: [],
99 questions: [],
100 })),
101};
102​
103function ChatBeside({
104 composerKeys,
105 maximizedAway,
106}: {
107 composerKeys: string[];
108 maximizedAway: boolean;
109}) {
110 useChatShortcuts({
111 enabled: true,
112 keybindings: [],
113 scriptKeybindings: [],
114 getShortcutContext: () => ({
115 terminalFocus: false,
116 terminalOpen: false,
117 previewFocus: false,
118 previewOpen: false,
119 isWeb: true,
120 isDesktop: false,
121 modelPickerOpen: false,
122 }),
123 threadFindActive: false,
124 composerRef: {
125 current: {
126 insertTextAtEnd: (key: string) => {
127 composerKeys.push(key);
128 return true;
129 },
130 } as Partial<ChatComposerHandle> as ChatComposerHandle,
131 },
132 branchToolbarRef: { current: null },
133 closeThreadFind: () => {},
134 commands: {},
135 fallback: () => undefined,
136 });
137 return <div data-chat-column-maximized-away={maximizedAway ? "true" : "false"} />;
139​
140it("steps with J and K beside a chat, also after a stop button or while the chat is maximized away", async () => {
141 vi.mocked(useReviewGuideWriter).mockReturnValue({
142 query: { isPending: false, error: null } as never,
143 data: { guide: threeStopGuide, run: null, currentHeadSha: "head" },
144 running: false,
145 canWrite: false,
146 write: async () => {},
147 });
148 const composerKeys: string[] = [];
149​
150 const tree = (maximizedAway: boolean) => (
151 <>
152 <ChatBeside composerKeys={composerKeys} maximizedAway={maximizedAway} />
153 <PullRequestGuideTab
154 environmentId={EnvironmentId.make("environment")}
155 reference={reference}
156 title="Test pull request"
157 workspaceRoot="/workspace"
158 active
159 canComment={false}
160 rangeComments={false}
161 completionScope={null}
162 onAskAboutLines={null}
163 onAskAboutStop={null}
164 onFinishReview={null}
165 onOpenFile={() => {}}
166 />
167 </>
168 );
169 await using screen = await render(tree(true));
170​
171 await userEvent.keyboard("j");
172 await expect.element(screen.getByText("Prose for the second stop.")).toBeVisible();
173 await screen.rerender(tree(false));
174 await userEvent.click(screen.getByText("Prose for the second stop."));
175 await userEvent.keyboard("k");
176 await expect.element(screen.getByText("Prose for the first stop.")).toBeVisible();
177 await userEvent.click(screen.getByRole("button", { name: "Next stop" }));
178 await userEvent.keyboard("j");
179 await expect.element(screen.getByText("Prose for the third stop.")).toBeVisible();
180 await userEvent.keyboard("k");
181 await expect.element(screen.getByText("Prose for the second stop.")).toBeVisible();
182 (document.activeElement ?? document.body).dispatchEvent(
183 new KeyboardEvent("keydown", { key: "J", bubbles: true, cancelable: true, composed: true }),
184 );
185 await expect.element(screen.getByText("Prose for the third stop.")).toBeVisible();
186 await userEvent.keyboard("a");
187 expect(composerKeys).toEqual(["a"]);
188});