Skip to content
Source
Sign inSign up
Open History to see the last commit

pullRequestDiffPages.test.ts

159 lines6.6 KB

1import { describe, expect, it, vi } from "vite-plus/test";
2import type { PullRequestDiffResult } from "@t3tools/contracts";
3import type { ReviewParsedDiff } from "../review/reviewModel";
4import { sourceControlClients } from "@t3tools/client-runtime/source-control-clients";
5import * as reviewModel from "../review/reviewModel";
6import {
7 combinePullRequestDiffPages,
8 getCachedPullRequestDiffPages,
9 retainPullRequestDiffPage,
10} from "./pullRequestDiffPages";
11​
12const GITHUB = sourceControlClients.get("github").changeRequest;
13​
14function diff(path: string): PullRequestDiffResult {
15 return {
16 patch: `diff --git a/${path} b/${path}\n--- a/${path}\n+++ b/${path}\n@@ -1 +1 @@\n-old\n+new\n`,
17 truncated: false,
18 nextCursor: null,
19 };
21​
22function withheldDiff(): PullRequestDiffResult {
23 return {
24 patch: "diff --git a/large.ts b/large.ts\n--- a/large.ts\n+++ b/large.ts\n",
25 truncated: true,
26 nextCursor: null,
27 omittedFileStats: [{ path: "large.ts", additions: 3000, deletions: 1800 }],
28 };
30​
31describe("paged mobile pull request diffs", () => {
32 it("isolates scopes, cursors, and provider terminology for the same result", () => {
33 const result = withheldDiff();
34 const pages = [{ cursor: null, result }];
35 const first = getCachedPullRequestDiffPages(pages, "first", GITHUB);
36 const otherScope = getCachedPullRequestDiffPages(pages, "second", GITHUB);
37 const otherCursor = getCachedPullRequestDiffPages(
38 [{ cursor: "next", result }],
39 "first",
40 GITHUB,
41 );
42 const otherProvider = getCachedPullRequestDiffPages(
43 pages,
44 "first",
45 sourceControlClients.get("gitlab").changeRequest,
46 );
47 expect(otherScope).not.toBe(first);
48 expect(otherCursor).not.toBe(first);
49 expect(otherProvider).not.toBe(first);
50 if (first.kind !== "files" || otherScope.kind !== "files" || otherProvider.kind !== "files")
51 throw new Error("Expected structured files");
52 expect(otherScope.files[0]?.id).not.toBe(first.files[0]?.id);
53 expect(first.notice).toContain("pull request");
54 expect(otherProvider.notice).toContain("merge request");
55 expect(getCachedPullRequestDiffPages(pages, "first", GITHUB)).toBe(first);
56 });
57​
58 it("reuses earlier pages on append and invalidates changed continuation results", () => {
59 using parse = vi.spyOn(reviewModel, "buildReviewParsedDiff");
60 const firstPage = { cursor: null, result: diff("first.ts") };
61 const first = getCachedPullRequestDiffPages([firstPage], "append", GITHUB);
62 const nextPage = { cursor: "next", result: withheldDiff() };
63 const combined = getCachedPullRequestDiffPages([firstPage, nextPage], "append", GITHUB);
64 expect(parse).toHaveBeenCalledTimes(2);
65 if (first.kind !== "files" || combined.kind !== "files") throw new Error("Expected files");
66 expect(combined.files[0]).toBe(first.files[0]);
67 expect(combined.files.map((file) => file.path)).toEqual(["first.ts", "large.ts"]);
68 expect(getCachedPullRequestDiffPages([firstPage, nextPage], "append", GITHUB)).toBe(combined);
69 const refreshed = getCachedPullRequestDiffPages(
70 [
71 firstPage,
72 {
73 ...nextPage,
74 result: {
75 ...nextPage.result,
76 omittedFileStats: [{ path: "large.ts", additions: 4000, deletions: 2000 }],
77 },
78 },
79 ],
80 "append",
81 GITHUB,
82 );
83 expect(parse).toHaveBeenCalledTimes(3);
84 expect(refreshed).not.toBe(combined);
85 if (refreshed.kind !== "files") throw new Error("Expected refreshed files");
86 expect(refreshed.files[0]).toBe(first.files[0]);
87 expect(refreshed.files[1]).toMatchObject({ additions: 4000, deletions: 2000 });
88 expect(combined.files[1]?.additions).toBe(3000);
89 });
90​
91 it("withheld PR hunks must retain provider line counts", () => {
92 const result = withheldDiff();
93 const cache = new WeakMap<PullRequestDiffResult, ReviewParsedDiff>();
94 const pages = [{ cursor: null, result }];
95 const parsed = combinePullRequestDiffPages(pages, cache, "pr", GITHUB);
96 if (parsed.kind !== "files") throw new Error("Expected structured diff");
97 expect(parsed.files[0]).toMatchObject({
98 path: "large.ts",
99 additions: 3000,
100 deletions: 1800,
101 rows: [],
102 });
103 expect(parsed.additions).toBe(3000);
104 expect(parsed.deletions).toBe(1800);
105 expect(parsed.notice).toBe(
106 "Some file contents are unavailable. Open the pull request on its provider to see the full changes.",
107 );
108 const cached = combinePullRequestDiffPages(pages, cache, "pr", GITHUB);
109 if (cached.kind !== "files") throw new Error("Expected structured diff");
110 expect(cached.files[0]).toBe(parsed.files[0]);
111 });
112​
113 it("combines normal and withheld pages and refreshes counts with unchanged patch text", () => {
114 const first = { ...diff("first.ts"), nextCursor: "second" };
115 const withheld = withheldDiff();
116 const cache = new WeakMap<PullRequestDiffResult, ReviewParsedDiff>();
117 const pages = retainPullRequestDiffPage(
118 retainPullRequestDiffPage([], null, first),
119 "second",
120 withheld,
121 );
122 const before = combinePullRequestDiffPages(pages, cache, "pr", GITHUB);
123 if (before.kind !== "files") throw new Error("Expected structured diff");
124 expect(before.files.map((file) => [file.path, file.additions, file.deletions])).toEqual([
125 ["first.ts", 1, 1],
126 ["large.ts", 3000, 1800],
127 ]);
128 expect(before.additions).toBe(3001);
129 expect(before.deletions).toBe(1801);
130​
131 const refreshed = retainPullRequestDiffPage(pages, "second", {
132 ...withheld,
133 omittedFileStats: [{ path: "large.ts", additions: 4000, deletions: 2000 }],
134 });
135 const after = combinePullRequestDiffPages(refreshed, cache, "pr", GITHUB);
136 if (after.kind !== "files") throw new Error("Expected structured diff");
137 expect(after.files[0]).toBe(before.files[0]);
138 expect(after.files[1]?.id).toBe(before.files[1]?.id);
139 expect(after.files[1]).toMatchObject({ additions: 4000, deletions: 2000, rows: [] });
140 expect(after.additions).toBe(4001);
141 expect(after.deletions).toBe(2001);
142 expect(after.notice).toBe(before.notice);
143 expect(before.additions).toBe(3001);
144 });
145​
146 it("discards later pages when a refreshed page changes", () => {
147 const first = diff("first.ts");
148 const pages = retainPullRequestDiffPage(
149 retainPullRequestDiffPage([], null, first),
150 "second",
151 diff("second.ts"),
152 );
153 expect(retainPullRequestDiffPage(pages, null, first)).toBe(pages);
154 expect(retainPullRequestDiffPage(pages, null, { ...first })).toBe(pages);
155 const refreshed = retainPullRequestDiffPage(pages, null, diff("changed.ts"));
156 expect(refreshed).toHaveLength(1);
157 expect(refreshed[0]?.result.patch).toContain("changed.ts");
158 });
159});