ci: let forge CI jobs fetch from storage.googleapis.com and pkg.pr.new #2167
Merged
AlemTuzlakmerged 3 commits into
main fromci/allow-pkg-pr-new·merged by AlemTuzlak View on GitHubMerge this PR first: each forge CI job on main fails at "Install dependencies", and every new PR inherits that. This PR adds 2 hosts to the forge egress lists:
storage.googleapis.com: Playwright 1.65 (#2166) downloads Chrome fromcdn.playwright.dev, and that URL redirects to this host. Without it, each forge job stops withegress to storage.googleapis.com is not allowed for this job.pkg.pr.new: the oracle setup PR (#100004) installs@tanstack/oraclesas a pinnedpkg.pr.newtarball. Without it, its install fails withERR_PNPM_FETCH_403.
A pull request run uses the egress list of its base branch, so this change must merge to main before other PRs can pass.
🎯 Changes#
storage.googleapis.com: added next tocdn.playwright.devin the 4 jobs that already allow that host:pr.ts(testandpreview),e2e.tsandbun-test.ts.pkg.pr.new: added to every forge job that runspnpm install --frozen-lockfile:pr.ts(testandpreview),e2e.ts,bun-test.tsandsync-models.ts. After #100004 merges, the lockfile onmainhas the tarball URL, so every install needs the host.
No changeset: no published package changes. No docs: CI only.
✅ Checklist#
- I have followed the steps in the Contributing guide.
- I have tested code changes locally with
pnpm run test:pr, or these tests do not apply to this pull request. - I fully understand the code in this pull request, including any code generated with AI assistance.
- Docs: I updated
docs/for this change, or this change is not user-facing. - Changeset: I added a changeset (
pnpm changeset), or this PR does not change a published package.
🚀 Release Impact#
- This change affects published code, and I have generated a changeset.
- This change is docs/CI/dev-only (no release).
Testing#
Commands run#
oxfmt --check .source/workflows/*.ts: passes.curl https://pkg.pr.new/TanStack/oracles/@tanstack/oracles@78fa1b7: HTTP 200 with no redirect, so the one host is enough.- The new
egresstakes effect only after this PR merges, so the forge CI of this PR still fails at "Install dependencies".
Evidence from CI#
The forge install log of #2163, #2164 and #2169 after they merged main:
egress to storage.googleapis.com is not allowed for this job
URL: https://cdn.playwright.dev/builds/cft/159.0.8154.6/linux64/chrome-linux64.zip
Manual test#
- Merge this PR.
- Rerun the failed forge jobs of #2163 with
src ci rerun <run> --failed. - Look at the "Install dependencies" step: it passes, with no egress error.
How this PR makes testing easy#
The failed installs on #2163, #2164, #2169 and #100004 are the test. They pass after this merge.
Risk / rollback#
- Forge CI jobs can download from all of
storage.googleapis.comandpkg.pr.new, not only the 2 files. The lockfile pins thepkg.pr.newtarball by its integrity hash. - Each forge run downloads Chrome (about 150 MB) until the forge
browserimage has Playwright 1.65. Then removestorage.googleapis.com. - When
@tanstack/oraclesis on npm, change the dependency to the npm version and removepkg.pr.new. - To roll back, revert this PR.
Summary by CodeRabbit#
- Chores
- Updated automated testing, end-to-end, preview, and model synchronization workflows to allow access to additional package and browser-download hosts. Existing host permissions remain unchanged. These updates affect workflow configuration only; app functionality and user-facing behavior are unchanged.
Useful: forge
egressneedsstorage.googleapis.comafter the Playwright 1.65 upgrade in #2166, andpkg.pr.newso #100004 (stacked on #2163) can install. No open PR already adds those hosts, and this PR does not link an issue.TanStack Source bot, value agent