Skip to content
Source
Sign inSign up
TanStack/ai

ci: let forge CI jobs fetch from storage.googleapis.com and pkg.pr.new #2167

MergedAlemTuzlakmerged 3 commits intomain fromci/allow-pkg-pr-newmerged by AlemTuzlak View on GitHub

AlemTuzlakcommented

Merge this PR first: each forge CI job on main fails at "Install dependencies", and every new PR inherits that. This PR adds 2 hosts to the forge egress lists:

  • storage.googleapis.com: Playwright 1.65 (#2166) downloads Chrome from cdn.playwright.dev, and that URL redirects to this host. Without it, each forge job stops with egress to storage.googleapis.com is not allowed for this job.
  • pkg.pr.new: the oracle setup PR (#100004) installs @tanstack/oracles as a pinned pkg.pr.new tarball. Without it, its install fails with ERR_PNPM_FETCH_403.

A pull request run uses the egress list of its base branch, so this change must merge to main before other PRs can pass.

🎯 Changes

  • storage.googleapis.com: added next to cdn.playwright.dev in the 4 jobs that already allow that host: pr.ts (test and preview), e2e.ts and bun-test.ts.
  • pkg.pr.new: added to every forge job that runs pnpm install --frozen-lockfile: pr.ts (test and preview), e2e.ts, bun-test.ts and sync-models.ts. After #100004 merges, the lockfile on main has the tarball URL, so every install needs the host.

No changeset: no published package changes. No docs: CI only.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.
  • Docs: I updated docs/ for this change, or this change is not user-facing.
  • Changeset: I added a changeset (pnpm changeset), or this PR does not change a published package.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Testing

Commands run

  • oxfmt --check .source/workflows/*.ts: passes.
  • curl https://pkg.pr.new/TanStack/oracles/@tanstack/oracles@78fa1b7: HTTP 200 with no redirect, so the one host is enough.
  • The new egress takes effect only after this PR merges, so the forge CI of this PR still fails at "Install dependencies".

Evidence from CI

The forge install log of #2163, #2164 and #2169 after they merged main:

egress to storage.googleapis.com is not allowed for this job
URL: https://cdn.playwright.dev/builds/cft/159.0.8154.6/linux64/chrome-linux64.zip

Manual test

  1. Merge this PR.
  2. Rerun the failed forge jobs of #2163 with src ci rerun <run> --failed.
  3. Look at the "Install dependencies" step: it passes, with no egress error.

How this PR makes testing easy

The failed installs on #2163, #2164, #2169 and #100004 are the test. They pass after this merge.

Risk / rollback

  • Forge CI jobs can download from all of storage.googleapis.com and pkg.pr.new, not only the 2 files. The lockfile pins the pkg.pr.new tarball by its integrity hash.
  • Each forge run downloads Chrome (about 150 MB) until the forge browser image has Playwright 1.65. Then remove storage.googleapis.com.
  • When @tanstack/oracles is on npm, change the dependency to the npm version and remove pkg.pr.new.
  • To roll back, revert this PR.

Summary by CodeRabbit

  • Chores
    • Updated automated testing, end-to-end, preview, and model synchronization workflows to allow access to additional package and browser-download hosts. Existing host permissions remain unchanged. These updates affect workflow configuration only; app functionality and user-facing behavior are unchanged.
    1. AlemTuzlak pushedc62635a

    2. AlemTuzlak changed the title

    3. AlemTuzlak changed the title

    4. tanstack-sourceBotcommented Only here. This is not on GitHub.

      Useful: forge egress needs storage.googleapis.com after the Playwright 1.65 upgrade in #2166, and pkg.pr.new so #100004 (stacked on #2163) can install. No open PR already adds those hosts, and this PR does not link an issue.

      TanStack Source bot, value agent

    5. AlemTuzlak merged this22a55c9

    6. AlemTuzlak merged this22a55c9

    7. AlemTuzlak closed this

Sign in to join this conversation.