Skip to content
Source
Sign inSign up
TanStack/ai

fix(solid): cap solid-js peer range at ^1 #1936

Mergedryansolid(GitHub profile, opens in a new tab)merged 2 commits intomain fromrefs/pull/1936/headmerged by AlemTuzlak View on GitHub

🎯 Changes

The Solid packages here declare an open-ended solid-js peer (>=1.x). Solid 2.0.0 is due shortly. Once it's tagged latest, that range will accept it, so npm install will pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removes solid-js/store, createComputed, mergeProps/splitProps, onMount, batch and more.

This PR changes each range from >=X to ^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way @tanstack/solid-router 2.x and @tanstack/solid-query 6.x did it.

Prereleases (2.0.0-rc.*) never matched >=1.x, which is why nobody has run into this yet.

✅ Checklist

  • Only peerDependencies ranges and a changeset change; no code changes.

Summary by CodeRabbit

  • Compatibility
    • The Solid integrations now support SolidJS 1.x only. Projects using other major versions may need to adjust their SolidJS version to use these packages.
  • Releases
    • Patch releases are planned for the Solid integration and its developer tools.
    1. 🦋 Changeset detected

      Latest commit: 363b7f8c3f5c2e8663d693b5587f0e78437d5701

      The changes in this PR will be included in the next version bump.

      This PR includes changesets to release 2 packages
      NameType
      @tanstack/ai-solidPatch
      @tanstack/solid-ai-devtoolsPatch

      Not sure what this means? Click here to learn what changesets are.

      Click here if you're a maintainer who wants to add another changeset to this PR

    2. Review in Change Stack →

      Important

      Review skipped

      Review was skipped as selected files did not have any reviewable changes.

      Run configuration
      • Source mode: Auto
      • Repository: TanStack/ai
      • Branch: main
      • File: .coderabbit.yaml
      • Commit: f33f72a
      • Layers: Repository YAML
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: cb64f586-817a-43bd-91d8-b2f8027d0461
      Commits

      Reviewing files that changed from the base of the PR and between a805a060af503d3b49edd34925b2634686695997 and 363b7f8c3f5c2e8663d693b5587f0e78437d5701.

      You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

      Use the checkbox below for a quick retry:

      • Trigger review

      No actionable comments were generated in the recent review.

      Recent review info
      Run configuration
      • Source mode: Auto
      • Repository: TanStack/ai
      • Branch: main
      • File: .coderabbit.yaml
      • Commit: 669fd31
      • Layers: Repository YAML
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: 2a3246b9-93f6-4cdb-a4c4-21df9f80dbbf
      Commits

      Reviewing files that changed from the base of the PR and between 669fd31d995a7134e9f39f386181edc5085039b2 and a805a060af503d3b49edd34925b2634686695997.

      Files selected for processing: 3
      • .changeset/solid-js-peer-cap.md
      • packages/ai-solid/package.json
      • packages/solid-ai-devtools/package.json

      Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

      Walkthrough

      The solid-js peer dependency ranges for both Solid packages are now limited to version 1. A changeset records patch releases for both packages.

      Changes: Solid.js peer range cap

      Layer / File(s)Summary
      Peer ranges and release entries
      packages/ai-solid/package.json, packages/solid-ai-devtools/package.json, .changeset/solid-js-peer-cap.md
      The solid-js peer ranges change to ^1.9.10 and ^1.9.7. The changeset records patch releases for both packages.

      Estimated code review effort: 1 (Trivial) | ~5 minutes

      Change: Bug fix

      Suggested reviewers: alemtuzlak

      Merge Risk: Minimal · previous review a805a

      The scoped dependency updates match the stated compatibility goal and are ready to merge.

      Pre-merge checks: Passed 4 · Failed 1
      Failed Failed checks: 1 warning
      Check nameStatusExplanationResolution
      Description checkWarningThe description explains the change and reason, but it omits the required Release Impact section and most checklist items from the repository template.Add the ## 🚀 Release Impact section and complete the required checklist items, including contributing-guide compliance, test status, AI-assisted code review confirmation, documentation status, and changeset or release-impact confirmation.
      Passed Passed checks: 4 passed
      Check nameStatusExplanation
      Title checkPassedThe title clearly and concisely describes the main change: capping the Solid package peer dependency range at ^1.
      Docstring CoveragePassedNo eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
      Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
      Full details: Docstring Coverage

      Explanation

      No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

      Finishing Touches
      🧪 Generate unit tests (beta)
      • Create a new PR
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share
    3. Thanks for the PR, @ryansolid! 🙌 @tombeckenham will take a look.

      Automated pre-review checks

      • ✅ CI passing
      • ✅ No merge conflicts
      • ✅ Changeset present
      • ✅ E2E test changes included
      Automated triage — a human review follows.
    4. github-actions[bot](GitHub profile, opens in a new tab) added labelswaiting-on: maintainer

    5. AlemTuzlak approved these changes

      Reviewed with the bugfix-pr gates: security scan clean, bug reproduced on main with an independent test, and fixed on this branch. Thanks!

    6. View your CI Pipeline Execution ↗ for commit 363b7f8c3f5c2e8663d693b5587f0e78437d5701

      CommandStatusDurationResult
      nx run-many --targets=build --exclude=examples/...✅ Succeeded5sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-11-02 13:06:42 UTC

    7. AlemTuzlak merged this6ed7c64

    8. AlemTuzlak closed this

Sign in to join this conversation.