security: stricter pnpm config blockExoticSubdeps & trustPolicy #453
OpenSheraff(GitHub profile, opens in a new tab)wants to merge 1 commit into
main fromrefs/pull/453/headopened Sign in to join this conversation.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
2e54749f-369e-456f-a08d-b538504a0810📥 Commits
Reviewing files that changed from the base of the PR and between efb411e4b002c1995a368e34066511afd7dba4e8 and a8dc95d8b12024be0fa14001d1a991db5fc691a1.
📒 Files selected for processing (2)
.github/workflows/pr.ymlpnpm-workspace.yaml💤 Files with no reviewable changes (1)
📝 Walkthrough
Walkthrough#
This PR removes the provenance-checking step from the CI workflow and adds two dependency policy configurations to the pnpm workspace. The workflow change streamlines validation by eliminating the provenance check, while the workspace configuration enforces stricter dependency resolution rules.
Changes#
Configuration and Workflow Updates
.github/workflows/pr.ymldanielroe/provenance-actionstep is deleted from the workflow, allowing thetest-e2ejob to run directly aftertest-unitcompletes without the intermediate provenance check.pnpm-workspace.yamlblockExoticSubdeps: truerestricts unusual dependency patterns, andtrustPolicy: 'no-downgrade'enforces that dependency versions are never downgraded.Estimated code review effort#
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem#
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment `@coderabbitai help` to get the list of available commands and usage tips.