Skip to content
Source
Sign inSign up
TanStack/cli

fix: Preallow esbuild build when installing Storybook #521

MergedSidnioulz(GitHub profile, opens in a new tab)merged 2 commits intomain fromrefs/pull/521/headmerged by tannerlinsley

Showing 11 changed files with 36 additions and 9 deletions (loading 8).

x
0 of 11 viewed, 11 left
5 additions and 0 deletions.changeset/storybook-pnpm-allow-build.mdAdded
View file
@@ -0,0 +1,5 @@
+---
+'@tanstack/create': patch
+---
+​
+Add command-specific build approvals for Storybook's esbuild installation on pnpm 10.2 and newer. Older and unknown target versions retain the compatible plain dlx command. Add-on and starter command definitions can declare requested build approvals, with version-aware planning shared by create and add-to-existing-app flows.
10 additions and 5 deletionspackages/create/src/add-to-app.tsModified
View file
@@ -144,9 +144,9 @@
​
-async function runCreateApp(options: Required<Options>) {
+async function runCreateApp(options: Required<Options>, packageManagerVersion?: string) {
const { environment, output } = createMemoryEnvironment(options.targetDir)
- await createApp(environment, options, { existingProject: true })
+ await createApp(environment, options, { existingProject: true, packageManagerVersion })
return output
​
@@ -315,10 +315,11 @@
args: Array<string>