Skip to content
Source
Sign inSign up
TanStack/cli

fix(create): typecheck generated Drizzle apps #566

Mergedtannerlinsleymerged 1 commit intomain fromrefs/pull/566/headmerged by tannerlinsley

tannerlinsleycommented

Fix two TypeScript failures in generated React Drizzle apps. Omit database credentials from Drizzle Kit config when the URL is absent, and use the current Start server function validator method. Configured apps still use their database URL. Migration generation only needs the schema.

Local unit, build, and blocking browser gates passed. Fresh pnpm apps built, typechecked, and generated a SQL migration without database credentials for PostgreSQL, MySQL, and SQLite. No database was contacted. This addresses a separate failure found while reproducing #392.

    1. Warning

      Review limit reached

      You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

      Next included review available in 14 minutes.

      Check out review usage here.

      View limit details

      Limit details: You’ve used all 4 included reviews currently available.

      Learn how review limits work.

      Review configuration:

      Run configuration
      • Source mode: Auto
      • Repository: Unavailable
      • Branch: Unavailable
      • File: No configuration file from this repository applied
      • Commit: Unavailable
      • Layers: defaults
      • Review profile: CHILL
      • Plan: Advanced
      • Run ID: 21334a53-f41f-4a40-a485-262373d6bb60
      Commits

      Reviewing files that changed from the base of the PR and between 7bd42308bcca1c27329b9d996143aa23b752e7ad and 9f455788f80e5b8c0a93f1f23e20e7c9d99d1202.

      Files selected for processing: 3
      • .changeset/drizzle-scaffold-typecheck.md
      • packages/create/src/frameworks/react/add-ons/drizzle/assets/drizzle.config.ts.ejs
      • packages/create/src/frameworks/react/add-ons/drizzle/assets/src/routes/demo/drizzle.tsx.ejs
      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share
    2. 🦋 Changeset detected

      Latest commit: 9f455788f80e5b8c0a93f1f23e20e7c9d99d1202

      The changes in this PR will be included in the next version bump.

      This PR includes changesets to release 7 packages
      NameType
      @tanstack/createPatch
      create-start-appPatch
      create-tanstack-appPatch
      create-tanstackPatch
      create-tsrouter-appPatch
      @tanstack/create-startPatch
      @tanstack/cliPatch

      Not sure what this means? Click here to learn what changesets are.

      Click here if you're a maintainer who wants to add another changeset to this PR

    3. tannerlinsley merged thisf40a234

    4. tannerlinsley closed this

Sign in to join this conversation.