Skip to content
Source
Sign inSign up
TanStack/db

fix(db): prevent JOIN lazy loading from accumulating duplicate loadedSubsets #1205

Closedmelvinhagberg(GitHub profile, opens in a new tab)wants to merge 1 commit intomain fromrefs/pull/1205/headopened

When using JOIN queries with on-demand sync mode, the lazy loading optimization for JOINs was accumulating LoadSubsetOptions in subscription.loadedSubsets without deduplication. Over multiple graph runs, this caused query keys and SQL queries to grow unboundedly, eventually causing "too many SQL variables" errors.

Changes:

  • Add loadedJoinKeys Set in joins.ts to track already-loaded join keys
  • Filter out loaded keys before calling requestSnapshot
  • Add isPredicateSubset check in subscription.ts before pushing to loadedSubsets
  • Add tests for JOIN lazy loading deduplication

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
    1. ⚠️ No Changeset found

      Latest commit: 18a158fa27c84b718e35b39a39a878adbd70a51f

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. Thanks for tracking down the repeated lazy-join demand. #1740 replaced the old includes routing, and #1756 removed the old loadedSubsets accumulation path. Repeated same-key parent updates on current main do not add child acquisitions. Closing this superseded PR for that reported accumulation case.

Sign in to join this conversation.