Skip to content
Source
Sign inSign up
TanStack/db

fix(db): prevent JOIN lazy loading from accumulating duplicate loadedSubsets #1205

Closedmelvinhagberg(GitHub profile, opens in a new tab)wants to merge 1 commit intomain fromrefs/pull/1205/headopened

Showing 3 changed files with 32 additions and 4 deletions (loading 1).

x
0 of 3 viewed, 3 left
9 additions and 1 deletionpackages/db/src/collection/subscription.tsModified
View file
@@ -4,6 +4,7 @@
import { EventEmitter } from '../event-emitter.js'
import { compileExpression } from '../query/compiler/evaluators.js'
import { buildCursor } from '../utils/cursor.js'
+import { isPredicateSubset } from '../query/predicate-utils.js'
import {
createFilterFunctionFromExpression,
createFilteredCallback,
@@ -375,7 +376,14 @@
opts?.onLoadSubsetResult?.(syncResult)
​
// Track this loadSubset call so we can unload it later
- this.loadedSubsets.push(loadOptions)
+ // Skip if an equivalent or superset predicate already exists to prevent
+ // unbounded accumulation of loadedSubsets
+ const isAlreadyCovered = this.loadedSubsets.some((existingOptions) =>
+ isPredicateSubset(loadOptions, existingOptions),
+ )
+ if (!isAlreadyCovered) {
+ this.loadedSubsets.push(loadOptions)
+ }
​
const trackLoadSubsetPromise = opts?.trackLoadSubsetPromise ?? true
if (trackLoadSubsetPromise) {