Skip to content
Source
Sign inSign up
TanStack/db

[repro] Progressive mode avoids requestSnapshot in joins (issue #811) #1232

Closedclaude[bot](GitHub profile, opens in a new tab)wants to merge 2 commits intomain fromai/issue-811-reproopened

Summary

This PR adds regression tests verifying that progressive mode collections properly avoid calling requestSnapshot() after initial sync completes. This addresses the scenario described in issue #811 where joins between progressive collections would throw "Snapshot requests are not supported in full mode".

What the tests verify

The tests confirm that the current code handles these scenarios correctly:

  1. Joins between two progressive collections after initial sync - When both collections have finished their initial sync, the join should work without calling requestSnapshot() on either collection.

  2. Joins when joined collection is still in buffering phase - When the lazy (joined) collection is still in the buffering phase, it should use fetchSnapshot() instead of requestSnapshot().

  3. Ordered queries on progressive collections - Simple ordered queries (like the useLiveSuspenseQuery example in issue comment) work correctly without calling requestSnapshot().

  4. Ordered queries with limit - Same behavior with limit clause.

Analysis

Based on investigation, the issue appears to have been already fixed by PR #852 (released in v0.2.4). That PR:

  • Changed progressive mode to use fetchSnapshot() during the buffering phase instead of requestSnapshot()
  • Added a guard at line 428-430 that returns early after initial sync completes, preventing any requestSnapshot() calls

All tests pass, confirming the current code handles these scenarios correctly.

How to run

pnpm --filter "@tanstack/electric-db-collection" exec vitest run tests/electric-progressive-join.test.ts --typecheck=false
  • Issue: #811
  • Fix PR that likely resolved this: #852

🤖 Generated with Claude Code

    1. ⚠️ No Changeset found

      Latest commit: 23ec45e96192a11d2bd0628f36053b5cd659f26d

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. More templates

      @tanstack/angular-db

      npm i https://pkg.pr.new/@tanstack/angular-db@1232

      @tanstack/db

      npm i https://pkg.pr.new/@tanstack/db@1232

      @tanstack/db-ivm

      npm i https://pkg.pr.new/@tanstack/db-ivm@1232

      @tanstack/electric-db-collection

      npm i https://pkg.pr.new/@tanstack/electric-db-collection@1232

      @tanstack/offline-transactions

      npm i https://pkg.pr.new/@tanstack/offline-transactions@1232

      @tanstack/powersync-db-collection

      npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1232

      @tanstack/query-db-collection

      npm i https://pkg.pr.new/@tanstack/query-db-collection@1232

      @tanstack/react-db

      npm i https://pkg.pr.new/@tanstack/react-db@1232

      @tanstack/rxdb-db-collection

      npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1232

      @tanstack/solid-db

      npm i https://pkg.pr.new/@tanstack/solid-db@1232

      @tanstack/svelte-db

      npm i https://pkg.pr.new/@tanstack/svelte-db@1232

      @tanstack/trailbase-db-collection

      npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1232

      @tanstack/vue-db

      npm i https://pkg.pr.new/@tanstack/vue-db@1232

      commit: 23ec45e

    3. Size Change: 0 B

      Total Size: 92 kB

      ℹ️ View Unchanged
      FilenameSize
      ./packages/db/dist/esm/collection/change-events.js1.39 kB
      ./packages/db/dist/esm/collection/changes.js1.22 kB
      ./packages/db/dist/esm/collection/events.js388 B
      ./packages/db/dist/esm/collection/index.js3.32 kB
      ./packages/db/dist/esm/collection/indexes.js1.1 kB
      ./packages/db/dist/esm/collection/lifecycle.js1.75 kB
      ./packages/db/dist/esm/collection/mutations.js2.34 kB
      ./packages/db/dist/esm/collection/state.js3.49 kB
      ./packages/db/dist/esm/collection/subscription.js3.71 kB
      ./packages/db/dist/esm/collection/sync.js2.41 kB
      ./packages/db/dist/esm/deferred.js207 B
      ./packages/db/dist/esm/errors.js4.7 kB
      ./packages/db/dist/esm/event-emitter.js748 B
      ./packages/db/dist/esm/index.js2.69 kB
      ./packages/db/dist/esm/indexes/auto-index.js742 B
      ./packages/db/dist/esm/indexes/base-index.js766 B
      ./packages/db/dist/esm/indexes/btree-index.js2.17 kB
      ./packages/db/dist/esm/indexes/lazy-index.js1.1 kB
      ./packages/db/dist/esm/indexes/reverse-index.js538 B
      ./packages/db/dist/esm/local-only.js837 B
      ./packages/db/dist/esm/local-storage.js2.1 kB
      ./packages/db/dist/esm/optimistic-action.js359 B
      ./packages/db/dist/esm/paced-mutations.js496 B
      ./packages/db/dist/esm/proxy.js3.75 kB
      ./packages/db/dist/esm/query/builder/functions.js733 B
      ./packages/db/dist/esm/query/builder/index.js4.09 kB
      ./packages/db/dist/esm/query/builder/ref-proxy.js1.05 kB
      ./packages/db/dist/esm/query/compiler/evaluators.js1.42 kB
      ./packages/db/dist/esm/query/compiler/expressions.js430 B
      ./packages/db/dist/esm/query/compiler/group-by.js1.81 kB
      ./packages/db/dist/esm/query/compiler/index.js2.02 kB
      ./packages/db/dist/esm/query/compiler/joins.js2.07 kB
      ./packages/db/dist/esm/query/compiler/order-by.js1.45 kB
      ./packages/db/dist/esm/query/compiler/select.js1.06 kB
      ./packages/db/dist/esm/query/expression-helpers.js1.43 kB
      ./packages/db/dist/esm/query/ir.js673 B
      ./packages/db/dist/esm/query/live-query-collection.js360 B
      ./packages/db/dist/esm/query/live/collection-config-builder.js5.43 kB
      ./packages/db/dist/esm/query/live/collection-registry.js264 B
      ./packages/db/dist/esm/query/live/collection-subscriber.js2.42 kB
      ./packages/db/dist/esm/query/live/internal.js145 B
      ./packages/db/dist/esm/query/optimizer.js2.56 kB
      ./packages/db/dist/esm/query/predicate-utils.js2.97 kB
      ./packages/db/dist/esm/query/subset-dedupe.js921 B
      ./packages/db/dist/esm/scheduler.js1.3 kB
      ./packages/db/dist/esm/SortedMap.js1.3 kB
      ./packages/db/dist/esm/strategies/debounceStrategy.js247 B
      ./packages/db/dist/esm/strategies/queueStrategy.js428 B
      ./packages/db/dist/esm/strategies/throttleStrategy.js246 B
      ./packages/db/dist/esm/transactions.js2.9 kB
      ./packages/db/dist/esm/utils.js924 B
      ./packages/db/dist/esm/utils/browser-polyfills.js304 B
      ./packages/db/dist/esm/utils/btree.js5.61 kB
      ./packages/db/dist/esm/utils/comparison.js952 B
      ./packages/db/dist/esm/utils/cursor.js457 B
      ./packages/db/dist/esm/utils/index-optimization.js1.51 kB
      ./packages/db/dist/esm/utils/type-guards.js157 B
      compressed-size-action::db-package-size
    4. Size Change: 0 B

      Total Size: 3.7 kB

      ℹ️ View Unchanged
      FilenameSize
      ./packages/react-db/dist/esm/index.js225 B
      ./packages/react-db/dist/esm/useLiveInfiniteQuery.js1.17 kB
      ./packages/react-db/dist/esm/useLiveQuery.js1.34 kB
      ./packages/react-db/dist/esm/useLiveSuspenseQuery.js559 B
      ./packages/react-db/dist/esm/usePacedMutations.js401 B
      compressed-size-action::react-db-package-size
    5. Closing this as it was meant as a test to check if a certain issue was solved or not.

Sign in to join this conversation.