Skip to content
Source
Sign inSign up
TanStack/db

chore: Rewrite the tests for the loadSubset to cover more clauses and operators #1426

Closedivasilov(GitHub profile, opens in a new tab)wants to merge 2 commits intomain fromrefs/pull/1426/headopened

🎯 Changes

Rewrote and added more tests foron-demand sync mode.

I was motivated by a regression in the INNER JOIN clause where it used to take 2 queries (one for each collection) but now it takes 3 queries on v0.6.

✅ Checklist

  • I have tested this code locally with pnpm test.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
    1. Closing as superseded by #1750. The merged loadSubset and pagination oracles cover the settled predicate/operator, subquery, join-dedupe, ordered-window, async, and adapter contracts with independent models. Unsettled pagination and ownership behavior remains explicit in #1657 instead of being implied by TODO tests.

Sign in to join this conversation.