Skip to content
Source
Sign inSign up
TanStack/db

fix(db): drop stale direct optimistic rows after txid sync #1547

MergedKyleAMathews(GitHub profile, opens in a new tab)merged 6 commits intomain fromrefs/pull/1547/headmerged by samwillis(GitHub profile, opens in a new tab)

Showing 8 changed files with 38 additions and 1 deletion (loading 5).

x
0 of 8 viewed, 8 left
5 additions and 0 deletions.changeset/fix-stale-optimistic-server-key.mdAdded
View file
@@ -0,0 +1,5 @@
+---
+'@tanstack/db': patch
+---
+​
+Fix stale optimistic rows persisting when sync confirms a different server-generated key. Previously, direct transactions (from `collection.insert()` etc.) had their optimistic rows exempted from stale-row cleanup, which prevented temp-key rows from being removed when the server returned a different primary key.
1 addition and 1 deletion.github/workflows/e2e-tests.ymlModified
View file
@@ -28,7 +28,7 @@
- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
- node-version: '20'
+ node-version: '22.13'
cache: 'pnpm'
​
- name: Install dependencies
32 additions and 0 deletionsAGENTS.mdModified
View file
@@ -14,6 +14,7 @@
8. [Function Design](#function-design)