fix(db-sqlite-persistence-core): rows marked with metadata prior to insert get reset causing stale data #1619
Closedtombryden(GitHub profile, opens in a new tab)wants to merge 2 commits into
main fromrefs/pull/1619/headopened kevin-dp(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
88dc55fc-1760-4629-a8e4-93807b3ab080📥 Commits
Reviewing files that changed from the base of the PR and between 267b36bb3d84dc3c280ed97e81e86d2fa3648dc3 and ff1cf8a2c21430a139669f6790ac6b32e2977974.
📒 Files selected for processing (3)
.changeset/small-tables-listen.mdpackages/db-sqlite-persistence-core/src/persisted.tspackages/db-sqlite-persistence-core/tests/persisted.test.ts📝 Walkthrough
Walkthrough#
Adjusts SQLite persistence insert handling so a metadata-less insert only clears row metadata when no row-metadata write is already queued for that key. Adds regression tests for preserved metadata and stale metadata clearing, plus a patch changeset.
Changes#
SQLite row-metadata insert fix
packages/db-sqlite-persistence-core/src/persisted.tssync.writeinsert path only queues a row-metadata delete when the transaction has not already queued a row-metadata write for that key.packages/db-sqlite-persistence-core/tests/persisted.test.ts,.changeset/small-tables-listen.mdEstimated code review effort#
🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested reviewers#
Poem#
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
#1618by preserving row metadata on insert and clearing stale metadata when needed.✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share