Skip to content
Source
Sign inSign up
TanStack/db

fix(db): retain accepted edits across older delete settlement #1907

MergedKyleAMathews(GitHub profile, opens in a new tab)merged 5 commits intomain fromrefs/pull/1907/headmerged by KyleAMathews(GitHub profile, opens in a new tab)

Showing 6 changed files with 88 additions and 1 deletion (loading 3).

x
0 of 6 viewed, 6 left
5 additions and 0 deletions.changeset/fix-accepted-dependent-edit.mdAdded
View file
@@ -0,0 +1,5 @@
+---
+'@tanstack/db': patch
+---
+​
+Keep an accepted edit of a pending reinsert visible when an older delete settles, and preserve the accepted delete if the reinsert fails. Both settlement orders remain correct across truncate replay.
8 additions and 1 deletiondocs/contributing/oracle-coverage.mdModified
View file
@@ -159,7 +159,14 @@
They vary truncate before/during/after an optimistic delete, rejection versus
rollback, post-capture direct insertion, and later ordinary sync/key reuse. A
hidden accepted insert returns after rollback; an uncaptured insert retires,
- and neither snapshot is rebased onto synced fields.
+ and neither snapshot is rebased onto synced fields. The state-retention owner
+ also crosses both accepted-delete/dependent-edit settlement orders with
+ reinsert success or failure, with and without truncate. Its public row and
+ change-message checks run after every step. These eight histories do not
+ establish every ordering of the insert outcome relative to sibling settlement
+ or an arbitrary later source acknowledgement.
+ The [PR #1907 review record](oracle-reviews/pr-1907-accepted-delete-ownership.md)
+ preserves the exact RED/GREEN evidence and reviewed commits.
​
| Issue obligation | Implemented evidence | Limit |
| --- | --- | --- |