Fixed query collection bug where optimistic state leaked into syncedData when using writeInsert inside onInsert handlers #879
main fromrefs/pull/879/head·merged by samwillis(GitHub profile, opens in a new tab) Fixes bug where optimistic state Leakes into syncedData when using writeInsert inside onInsert handlers.
Previously, when syncing server-generated fields (like IDs or timestamps) using writeInsert within an onInsert handler, the QueryClient cache was updated with combined visible state (including optimistic changes), which triggered the query observer to write optimistic values back to syncedData.
Now the cache is correctly updated with only server-confirmed state, ensuring syncedData maintains separation from optimistic state.
Fork of the reproduction using preview package from this PR showing it fixed: https://codesandbox.io/p/sandbox/tanstack-db-bug-forked-nqtkvp?file=%2Fsrc%2FApp.tsx
- 1
More templates
@tanstack/angular-db
npm i https://pkg.pr.new/@tanstack/angular-db@879@tanstack/db
npm i https://pkg.pr.new/@tanstack/db@879@tanstack/db-ivm
npm i https://pkg.pr.new/@tanstack/db-ivm@879@tanstack/electric-db-collection
npm i https://pkg.pr.new/@tanstack/electric-db-collection@879@tanstack/offline-transactions
npm i https://pkg.pr.new/@tanstack/offline-transactions@879@tanstack/powersync-db-collection
npm i https://pkg.pr.new/@tanstack/powersync-db-collection@879@tanstack/query-db-collection
npm i https://pkg.pr.new/@tanstack/query-db-collection@879@tanstack/react-db
npm i https://pkg.pr.new/@tanstack/react-db@879@tanstack/rxdb-db-collection
npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@879@tanstack/solid-db
npm i https://pkg.pr.new/@tanstack/solid-db@879@tanstack/svelte-db
npm i https://pkg.pr.new/@tanstack/svelte-db@879@tanstack/trailbase-db-collection
npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@879@tanstack/vue-db
npm i https://pkg.pr.new/@tanstack/vue-db@879commit:
76f9113Size Change: 0 B
Total Size: 85.8 kB
compressed-size-action::db-package-sizeℹ️ View Unchanged
Filename Size ./packages/db/dist/esm/collection/change-events.js1.38 kB ./packages/db/dist/esm/collection/changes.js977 B ./packages/db/dist/esm/collection/events.js388 B ./packages/db/dist/esm/collection/index.js3.24 kB ./packages/db/dist/esm/collection/indexes.js1.1 kB ./packages/db/dist/esm/collection/lifecycle.js1.67 kB ./packages/db/dist/esm/collection/mutations.js2.26 kB ./packages/db/dist/esm/collection/state.js3.43 kB ./packages/db/dist/esm/collection/subscription.js2.42 kB ./packages/db/dist/esm/collection/sync.js2.12 kB ./packages/db/dist/esm/deferred.js207 B ./packages/db/dist/esm/errors.js4.11 kB ./packages/db/dist/esm/event-emitter.js748 B ./packages/db/dist/esm/index.js2.63 kB ./packages/db/dist/esm/indexes/auto-index.js742 B ./packages/db/dist/esm/indexes/base-index.js766 B ./packages/db/dist/esm/indexes/btree-index.js1.87 kB ./packages/db/dist/esm/indexes/lazy-index.js1.1 kB ./packages/db/dist/esm/indexes/reverse-index.js513 B ./packages/db/dist/esm/local-only.js837 B ./packages/db/dist/esm/local-storage.js2.1 kB ./packages/db/dist/esm/optimistic-action.js359 B ./packages/db/dist/esm/paced-mutations.js496 B ./packages/db/dist/esm/proxy.js3.22 kB ./packages/db/dist/esm/query/builder/functions.js733 B ./packages/db/dist/esm/query/builder/index.js3.84 kB ./packages/db/dist/esm/query/builder/ref-proxy.js917 B ./packages/db/dist/esm/query/compiler/evaluators.js1.35 kB ./packages/db/dist/esm/query/compiler/expressions.js430 B ./packages/db/dist/esm/query/compiler/group-by.js1.8 kB ./packages/db/dist/esm/query/compiler/index.js1.96 kB ./packages/db/dist/esm/query/compiler/joins.js2 kB ./packages/db/dist/esm/query/compiler/order-by.js1.25 kB ./packages/db/dist/esm/query/compiler/select.js1.07 kB ./packages/db/dist/esm/query/expression-helpers.js1.43 kB ./packages/db/dist/esm/query/ir.js673 B ./packages/db/dist/esm/query/live-query-collection.js360 B ./packages/db/dist/esm/query/live/collection-config-builder.js5.26 kB ./packages/db/dist/esm/query/live/collection-registry.js264 B ./packages/db/dist/esm/query/live/collection-subscriber.js1.74 kB ./packages/db/dist/esm/query/live/internal.js130 B ./packages/db/dist/esm/query/optimizer.js2.56 kB ./packages/db/dist/esm/query/predicate-utils.js2.88 kB ./packages/db/dist/esm/query/subset-dedupe.js921 B ./packages/db/dist/esm/scheduler.js1.21 kB ./packages/db/dist/esm/SortedMap.js1.18 kB ./packages/db/dist/esm/strategies/debounceStrategy.js237 B ./packages/db/dist/esm/strategies/queueStrategy.js422 B ./packages/db/dist/esm/strategies/throttleStrategy.js236 B ./packages/db/dist/esm/transactions.js2.9 kB ./packages/db/dist/esm/utils.js881 B ./packages/db/dist/esm/utils/browser-polyfills.js304 B ./packages/db/dist/esm/utils/btree.js5.61 kB ./packages/db/dist/esm/utils/comparison.js852 B ./packages/db/dist/esm/utils/index-optimization.js1.51 kB ./packages/db/dist/esm/utils/type-guards.js157 B Size Change: 0 B
Total Size: 3.34 kB
compressed-size-action::react-db-package-sizeℹ️ View Unchanged
Filename Size ./packages/react-db/dist/esm/index.js225 B ./packages/react-db/dist/esm/useLiveInfiniteQuery.js1.17 kB ./packages/react-db/dist/esm/useLiveQuery.js1.11 kB ./packages/react-db/dist/esm/useLiveSuspenseQuery.js431 B ./packages/react-db/dist/esm/usePacedMutations.js401 B KyleAMathews(GitHub profile, opens in a new tab) approved these changes
So many caches to mess up! 😆
:shipit:
samwillis(GitHub profile, opens in a new tab) closed this
Sign in to join this conversation.
🦋 Changeset detected#
Latest commit: 76f9113688545964dcaa954e2526019232219caa
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR