Skip to content
Source
Sign inSign up
TanStack/form

Nextjs useForm gives a type error #470

Send to my agent
Closedsamyarkd(GitHub profile, opens in a new tab) opened this issue 10 comments

Describe the bug

When i use useForm i get an error saying use_isomorphic_layout_effect_cjs is not a function. and it's due to Nextjs server side rendering.

Right now I'm getting over it using Nextjs dynamic import and disabling ssr but it's not a good approach.

when i want to use useForm hook i get the bellow error:

TypeError: use_isomorphic_layout_effect_cjs is not a function
    at useForm (/home/challen-quiz/dist/apps/challenquiz/.next/server/chunks/9063.js:828:3)
    at QuestionForm (/home/challen-quiz/dist/apps/challenquiz/.next/server/app/admin/add-question/page.js:442:44)
    at nP (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:40134)
    at nP (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:53256)
    at n$ (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:56848)
    at nj (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:60443)
    at nR (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:59154)
    at n$ (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:57094)
    at nj (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:60443)
    at nP (/home/challen-quiz/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:45:50666)

Your minimal, reproducible example

https://stackblitz.com/edit/stackblitz-starters-bbkdbd?file=components%2Fform.tsx

Steps to reproduce

  1. create a new nextjs app project
  2. create a client component
  3. import useForm
  4. use the client compoent
  5. check the logs

Expected behavior

i expected that the useForm would work in a client component

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

  • OS Linux fedora
  • Browzer: Edge
  • Node version: 20
  • Nextjs: 13.5.3
  • @tanstack/react-form": "^0.3.6

Tanstack Form adapter

react-form

TanStack Form version

0.3.6

TypeScript version

5.2.2

Additional context

I just googled something and i found this: https://stackoverflow.com/questions/76609948/error-typeerror-0-useisomorphiclayouteffect-useisomorphiclayouteffect-is-n

  1. This is a known issue caused by our bundler having issues.

    Note to self: figure out why TSUp isn't bundling deps properly.

  2. While certainly the error message is not ideal, does this actually cause any breaking issues? The hook seems to work as intended otherwise. 🤔

  3. While certainly the error message is not ideal, does this actually cause any breaking issues? The hook seems to work as intended otherwise. 🤔

    Can't run build command

  4. FWIW, It seems I can still build my project without error.

    But i still get this error when running dev:

     ⨯ node_modules/.pnpm/@tanstack+react-form@0.3.6_@types+react@18.2.25_react-dom@18.2.0_react@18.2.0/node_modules/@tanstack/react-form/build/modern/useForm.js (29:2) @ useForm
     ⨯ TypeError: use_isomorphic_layout_effect__WEBPACK_IMPORTED_MODULE_1__ is not a function
        at SettingsForm (settings/_components/SettingsForm.tsx:64:80)
  5. crutchcorn(GitHub profile, opens in a new tab) added labelstype: bug

  6. While certainly the error message is not ideal, does this actually cause any breaking issues? The hook seems to work as intended otherwise. 🤔

    Cant build the project for both dev and prod environment. (Nextjs Pages Router)

    • react-form 0.3.6
    • Nextjs 13.4.8
    • Node 18
    • Typescript 4.9.5

    Here are some logs for ya:

    Prod

    Error occurred prerendering page "/en/us/login". Read more: https://nextjs.org/docs/messages/prerender-error
    TypeError: useIsomorphicLayoutEffect is not a function
        at useForm (file:///<REDACTED>/node_modules/.pnpm/@tanstack+react-form@0.3.6_@types+react@18.2.22_react-dom@18.2.0_react@18.2.0/node_modules/@tanstack/react-form/build/modern/useForm.js:29:3)
        at Login (/<REDACTED>/.next/server/pages/[channel]/login.js:139:79)
        at Wc (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:68:44)
        at Zc (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:253)
        at Z (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)
        at $c (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:78:98)
        at Zc (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:71:145)
        at Z (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)
        at Zc (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:481)
        at Z (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89)

    Dev:

    - error Error [TypeError]: useIsomorphicLayoutEffect is not a function
        at useForm (file:///<REDACTED>/node_modules/.pnpm/@tanstack+react-form@0.3.6_@types+react@18.2.22_react-dom@18.2.0_react@18.2.0/node_modules/@tanstack/react-form/build/modern/useForm.js:29:3)
        at Login (webpack-internal:///./components/login.tsx:21:79)
        at renderWithHooks (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5658:16)
        at renderIndeterminateComponent (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5731:15)
        at renderElement (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5946:7)
    ...
    omitted a million more lines
    ...
        at renderNodeDestructiveImpl (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6104:11)
        at renderNodeDestructive (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6076:14)
        at renderIndeterminateComponent (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5785:7)
        at renderElement (/<REDACTED>/node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5946:7) {
      digest: undefined
    }
    
  7. I've reproduced this locally and it might be an issue inside the use-isomorphic-layout-effect package:

    1. If I add console.log(useIsomorphicLayoutEffect) inside useForm and run it in a nextjs app I get:

      • { default: [Function (anonymous)] } in the back end
      • and useLayoutEffect(create, deps) { ... } in the front end

      So there is an extra default property in the back end.

    2. Looking inside the Next.js build folder, I see that use_isomorphic_layout_effect is imported from node_modules/use-isomorphic-layout-effect/dist/use-isomorphic-layout-effect.cjs.js on the server and from node_modules/use-isomorphic-layout-effect/dist/use-isomorphic-layout-effect.browser.esm.js on the client. So Next.js imports the CJS version for SSR and the ESM version in the front end.

    So for some reason, NextJS gets the CJS version on the server instead of the ESM one, and it can't resolve the default export properly. I don't know if it's an issue with NextJS or the package itself but I've noticed that if I add the exports sections to use-isomorphic-layout-effect's package.json, like below:

    "exports": {
        "require": {
          "default": "./dist/use-isomorphic-layout-effect.cjs.js"
        },
        "import": {
          "default": "./dist/use-isomorphic-layout-effect.esm.js"
        }
      }

    the issue disappears.

    That said, we probably don't need to use this package. Looking at the code here, all it does is:

    export default typeof document !== 'undefined' ? useLayoutEffect : useEffect;

    I've tried replacing the package with that code inside the react-form package and it solved the issue. I'll open a PR.

  8. @juliendelort this is good investigation. I will know however that I use this package simply because of React Native support.

    But admittedly that's changed since RN now supports import maps

  9. Ah yeah true, I forgot about react-native. I wonder if typeof document !== 'undefined' would work on RN and default back to useEffect.

  10. I've reproduced this locally and it might be an issue inside the use-isomorphic-layout-effect package:

    1. If I add console.log(useIsomorphicLayoutEffect) inside useForm and run it in a nextjs app I get:

      • { default: [Function (anonymous)] } in the back end
      • and useLayoutEffect(create, deps) { ... } in the front end

      So there is an extra default property in the back end.

    2. Looking inside the Next.js build folder, I see that use_isomorphic_layout_effect is imported from node_modules/use-isomorphic-layout-effect/dist/use-isomorphic-layout-effect.cjs.js on the server and from node_modules/use-isomorphic-layout-effect/dist/use-isomorphic-layout-effect.browser.esm.js on the client. So Next.js imports the CJS version for SSR and the ESM version in the front end.

    So for some reason, NextJS gets the CJS version on the server instead of the ESM one, and it can't resolve the default export properly. I don't know if it's an issue with NextJS or the package itself but I've noticed that if I add the exports sections to use-isomorphic-layout-effect's package.json, like below:

    "exports": {
        "require": {
          "default": "./dist/use-isomorphic-layout-effect.cjs.js"
        },
        "import": {
          "default": "./dist/use-isomorphic-layout-effect.esm.js"
        }
      }

    the issue disappears.

    That said, we probably don't need to use this package. Looking at the code here, all it does is:

    export default typeof document !== 'undefined' ? useLayoutEffect : useEffect;

    I've tried replacing the package with that code inside the react-form package and it solved the issue. I'll open a PR.

    i have the exact same thoughts about it, as you mentioned it, all does is only a one line of code

  11. This fix made it into our 0.6.1 release with the help of @juliendelort. Please let me know if you run into any further issues with Next.js support

    Sorry for the headache y'all - I really don't know how I got it in my head that React Native wouldn't support this, seeing as I already knew it did from my time building HouseForm.

Sign in to join this conversation.