fix: leave skills that review.ignore matches out of default discovery #330
Mergedviclafouch(GitHub profile, opens in a new tab)merged 3 commits into
main fromrefs/pull/330/headmerged by LadyBluenotes(GitHub profile, opens in a new tab) - @@ -129,3 +129,4 @@129129130130 Entries use the same Git glob syntax as source mappings. An entry that is not a non-empty string fails review with the path of the tree file.131131132+A `skills/**/SKILL.md` that matches `review.ignore` is not a library skill: review and `maintainer setup` skip it unless the skill tree declares its path. Use this for agent skills kept beside the library, such as the skills of a Claude Code plugin.
LadyBluenotes(GitHub profile, opens in a new tab) requested changes
@@ -559,10 +561,20 @@561+ ...defaultReviewIgnore.map((pattern) =>562+ globPattern(pattern, pattern, 'review.ignore'),563+ ),564+ ...treeIgnorePatterns,565+ ]559566 // Query Git for ignored paths only when an uncovered change needs classifying.560567 let ignored: Set<string> | undefined561568 const isIgnored = (path: string) => {562569 ignored ??= new Set([...list(ignorePatterns), ...diff(ignorePatterns)])563570 return ignored.has(path)564571 }572+ const treeIgnored = new Set(573+ treeIgnorePatterns.length > 0 ? list(treeIgnorePatterns) : [],574+ )565575 const skillFiles = files.filter(566576 (path) =>567577 basename(path) === 'SKILL.md' &&568- ((/(^|\/)skills\//.test(path) && isDefaultSkillPath(path)) ||578+ ((/(^|\/)skills\//.test(path) &&579+ isDefaultSkillPath(path) &&580+ !treeIgnored.has(path)) ||@@ -43,4 +43,4 @@43434444 Generated skeletons remain unfinished. Author their contents and remove the `intent:needs-authoring` marker after completing that work. A successful setup command does not mean the skills are ready to publish.454546-Setup automatically registers valid, Git-visible `skills/**/SKILL.md` files in the root package and workspace packages, preserving their content. It skips dependencies, hidden agent directories, invalid skills, and conflicting names, reporting each skipped candidate. Domains come from `metadata.domain`, the existing domain map, a parent directory under `skills/`, or `uncategorized`; review that placeholder and complete task coverage. For custom locations outside `skills/`, use `maintainer add --path`. Repeating setup preserves existing registrations and workflow files. Reviewers can use [interactive review](./intent-review#interactive-review) in a human terminal; CI uses the noninteractive checks.46+Setup automatically registers valid, Git-visible `skills/**/SKILL.md` files in the root package and workspace packages, preserving their content. It skips dependencies, hidden agent directories, paths that [`review.ignore`](./intent-review#ignored-paths) matches, invalid skills, and conflicting names, reporting each skipped candidate. Domains come from `metadata.domain`, the existing domain map, a parent directory under `skills/`, or `uncategorized`; review that placeholder and complete task coverage. For custom locations outside `skills/`, use `maintainer add --path`. Repeating setup preserves existing registrations and workflow files. Reviewers can use [interactive review](./intent-review#interactive-review) in a human terminal; CI uses the noninteractive checks.LadyBluenotes(GitHub profile, opens in a new tab) approved these changes
Sign in to join this conversation.
🦋 Changeset detected#
Latest commit: a724d516902806f58e32a49177750b8094a228f9
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR