Skip to content
Source
Sign inSign up
TanStack/pacer

fix(pacer): Report retry outcomes and preserve failure details #274

OpenKevinVandywants to merge 6 commits intofeat-186-257-269-execution-lifecycle fromfeat-247-retry-outcomesopened

KevinVandycommented

🎯 Changes

  • Distinguish successful retry results from final failure, disabled execution, and cancellation in all five async utilities. Preserve lastResult on non-success and keep successful undefined results valid.
  • Report swallowed final failures through the parent's onError and throwOnError. Preserve standalone retryer timeout and rejection behavior. Normalize non-Error failures with readable messages and their original value as cause.
  • Add 77 regressions covering outcomes, callbacks, cancellation, retry recovery, concurrent work, rate-window cleanup, and error normalization. The combined lifecycle/outcome branch passes pnpm test and pnpm run test:pr, all 330 tasks; core size is 7.63 kB against a 10 kB limit.

Closes #247

Stacked on #271 to include its execution ownership fixes. Adapts the non-Error normalization fix from #223 by @theBGuy.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
    1. Important

      Draft PR not reviewed

      Draft PRs are not automatically reviewed by default.

      • Trigger a manual review

      To automatically review draft PRs, update your CodeRabbit configuration:

      reviews:
        auto_review:
          drafts: true
      • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Autopilot is currently an internal CodeRabbit preview.


      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      ❤️ Share
      Comment `@coderabbitai help` to get the list of available commands.
    2. View your CI Pipeline Execution ↗ for commit 0045992d1cb110d7d16af692c5b7bba67ad1ef6c

      CommandStatusDurationResult
      nx run-many --targets=build --exclude=examples/**✅ Succeeded12sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-09-30 20:42:59 UTC

    3. 🚀 Changeset Version Preview

      1 package(s) bumped directly, 4 bumped as dependents.

      🟩 Patch bumps

      PackageVersionReason
      @tanstack/pacer0.23.0 → 0.23.1Changeset
      @tanstack/angular-pacer0.25.0 → 0.25.1Dependent
      @tanstack/preact-pacer0.24.0 → 0.24.1Dependent
      @tanstack/react-pacer0.24.0 → 0.24.1Dependent
      @tanstack/solid-pacer0.23.0 → 0.23.1Dependent
    4. More templates

      @tanstack/angular-pacer

      npm i https://pkg.pr.new/@tanstack/angular-pacer@274

      @tanstack/pacer

      npm i https://pkg.pr.new/@tanstack/pacer@274

      @tanstack/pacer-devtools

      npm i https://pkg.pr.new/@tanstack/pacer-devtools@274

      @tanstack/pacer-lite

      npm i https://pkg.pr.new/@tanstack/pacer-lite@274

      @tanstack/preact-pacer

      npm i https://pkg.pr.new/@tanstack/preact-pacer@274

      @tanstack/preact-pacer-devtools

      npm i https://pkg.pr.new/@tanstack/preact-pacer-devtools@274

      @tanstack/react-pacer

      npm i https://pkg.pr.new/@tanstack/react-pacer@274

      @tanstack/react-pacer-devtools

      npm i https://pkg.pr.new/@tanstack/react-pacer-devtools@274

      @tanstack/solid-pacer

      npm i https://pkg.pr.new/@tanstack/solid-pacer@274

      @tanstack/solid-pacer-devtools

      npm i https://pkg.pr.new/@tanstack/solid-pacer-devtools@274

      commit: 0045992

    5. KevinVandy linked this to fix #247

Sign in to join this conversation.