fix(solid): cap solid-js peer range at ^1 #306
main fromrefs/pull/306/head·opened 🎯 Changes#
The Solid packages here declare an open-ended solid-js peer (>=1.x). Solid 2.0.0 is due shortly. Once it's tagged latest, that range will accept it, so npm install will pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removes solid-js/store, createComputed, mergeProps/splitProps, onMount, batch and more.
This PR changes each range from >=X to ^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way @tanstack/solid-router 2.x and @tanstack/solid-query 6.x did it.
Prereleases (2.0.0-rc.*) never matched >=1.x, which is why nobody has run into this yet.
✅ Checklist#
- Only
peerDependenciesranges and a changeset change; no code changes.
Summary by CodeRabbit#
- Compatibility
- Updated the supported
solid-jspeer dependency ranges for the Solid Pacer packages to accept Solid 1 versions only. Solid 2 versions are no longer included in the declared compatibility range, helping package managers identify version mismatches during dependency resolution.
- Updated the supported
- 1
Important
Review skipped#
Review was skipped due to path filters
:no_entry: Files ignored due to path filters: 1
-
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
**/dist/**will override the default block on thedistdirectory, by removing the pattern from both the lists. Run configuration-
- Source mode: Auto
- Repository: TanStack/pacer
- Branch: main
- File: .coderabbit.yaml
- Commit: 34d6213
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
42f99018-3709-4152-8651-ff44b8ca80b6
You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.Use the checkbox below for a quick retry:
- 🔍 Trigger review
No actionable comments were generated in the recent review.
Recent review info-
Run configuration-
- Source mode: Auto
- Repository: TanStack/pacer
- Branch: main
- File: .coderabbit.yaml
- Commit: 34d6213
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
a49dca15-eabe-4952-b279-1673363d5ff5
Commits-
Reviewing files that changed from the base of the PR and between 34d621315f74f86a4dcc826414ccf8b64233e8a8 and e2176e06e477cebd7810d396762647d3bef352b7.
Files selected for processing: 3-
.changeset/solid-js-peer-cap.mdpackages/solid-pacer-devtools/package.jsonpackages/solid-pacer/package.json
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
Walkthrough
-
Both Solid Pacer packages now cap their
solid-jspeer dependency ranges at version 1. A patch changeset records the updates.Changes: Solid peer dependency ranges
Priority:Layer / File(s) Summary Cap Solid peer dependency ranges
packages/solid-pacer-devtools/package.json,packages/solid-pacer/package.json,.changeset/solid-js-peer-cap.mdBoth packages replace open-ended >=peer ranges with caret ranges for version 1. The changeset records the updates. NormalEstimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested reviewers:
kevinvandy
Merge Risk:
Minimal · previous reviewe2176-
The scoped dependency updates are ready to merge.
Pre-merge checks:
4 · 1-
Failed checks: 1 warningCheck name Status Explanation Resolution Description check The description explains the motivation and implementation, but it omits the required Release Impact section and most checklist items from the repository template. It also does not explicitly mark the… Add the complete template sections. Include the Contributing guide, test applicability, and AI-assistance checklist items. Add the Release Impact section and mark that the change affects published code and includes a changeset. Passed checks: 4 passed-
Check name Status Explanation Title check The title clearly and concisely identifies the main change: capping the Solid.js peer dependency range at version 1. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Full details: Description check
-
Explanation
The description explains the motivation and implementation, but it omits the required Release Impact section and most checklist items from the repository template. It also does not explicitly mark the changeset checklist item.
Resolution
Add the complete template sections. Include the Contributing guide, test applicability, and AI-assistance checklist items. Add the Release Impact section and mark that the change affects published code and includes a changeset.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment `@coderabbitai help` to get the list of available commands.-
Sign in to join this conversation.
🦋 Changeset detected#
Latest commit: f8196cbfb1bd9bcea1a8aaaac4c165ad227b45b7
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR