Skip to content
Source
Sign inSign up
TanStack/query

docs(framework/react/devtools): replace '@ts-expect-error' with 'Object.assign' in production lazy load example #12531

Mergedsukvvon(GitHub profile, opens in a new tab)merged 1 commit intomain fromrefs/pull/12531/headmerged by sukvvon(GitHub profile, opens in a new tab)

🎯 Changes

The "Devtools in production" example in the React devtools docs now uses Object.assign(window, { toggleDevtools }) instead of assigning window.toggleDevtools under @ts-expect-error. The example now type-checks without suppressing an error.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
    1. ⚠️ No Changeset found

      Latest commit: 01f3d38b056accd36047b71f766df08cf7d6e3fb

      Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

      This PR includes no changesets

      When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

      Click here to learn what changesets are, and how to add one.

      Click here if you're a maintainer who wants to add a changeset to this PR

    2. View your CI Pipeline Execution ↗ for commit 01f3d38b056accd36047b71f766df08cf7d6e3fb

      CommandStatusDurationResult
      nx run-many --target=build --exclude=examples/*...✅ Succeeded<1sView ↗
      nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded1m 3sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-11-06 01:38:44 UTC

    3. 🚀 Changeset Version Preview

      No changeset entries found. Merging this PR will not cause a version bump for any packages.

    4. Explain Change →

      Caution

      Review failed

      The pull request is closed.

      • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

      Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

      Share

    5. size-limit report 📦

      PathSize
      react full11.84 KB (0%)
      react minimal8.66 KB (0%)

Sign in to join this conversation.