Context is undefined in weird case. #1751
Send to my agentDescribe the bug#
For some unknown reason context is undefined in loader, but it was present in beforeLoad
Your Example Website or App#
https://github.com/Arilas/tanter-bug
Steps to Reproduce the Bug or Issue#
- Clone
yarnyarn dev- Open Host
- Obserse error in
src/routes/_secured.tsx - Refresh the page
- Now it's working
Expected behavior#
It should not clear the context
Screenshots or Videos#
Platform#
- OS: macOS, iOS, Android
- Browser: Arc, Safari
- Version: latest
Additional context#
I've over-simplified our case to the reproducible state. In our case we have a ServiceLocator with multiple factories, dependencies, events.
index.lazy.tsx can be replaced with an route with beforeLoad which will have redirects, but it was an workaround to fix problem previously.
I've just run into the same issue. In my case it is also where I'm throwing a redirect in my
beforeLoadto redirect away from a bare route that has no search params to one which has a valid default param populated.beforeLoadseems to get called again immediately after the redirect with the newly updateddepsfromloaderDeps, but with anundefinedcontextvalue.If I instead use the deprecated
navigatearg inbeforeLoad(rather thanthrow redirect({...})) everything works as expected, in case others are looking for a workaround.Actually, I just upgraded my app from v1.35.6 to v1.39.4 and I can no longer reproduce this issue. Seems like it may have been fixed @Arilas, maybe try your repo on the latest version and see if it's still broken?
I take it back, I'm still encountering this issue. Not sure how I thought it was fixed last time.
For me, it happens in two case:
- When I load an initial route at
/that renders a<Navigate />redirect. The 2nd redirected route then has an undefinedcontext. I updated my code tothrow redirectinstead of using<Navigate />on my initial route, and that takes care of the issue. - When my first file route
/jobs/throws a redirect inbeforeLoadto the same route, but with updated ansearchvalue, theloadergets called an initial time with nocontext. This one gets worked around using the following and avoiding destructuring context as part of the loader function:loader: async ({ context, deps: { limit, state } }) => { if (!context) { // workaround for this issue: // https://github.com/TanStack/router/issues/1751 return; } // ...
Although I didn't put together a simple reproduction, my workaround changes are visible in https://github.com/riverqueue/riverui/pull/80
- When I load an initial route at
this will be fixed by #1907
SeanCassiere added labelsbug
Sign in to join this conversation.
Yeah. I have the same issue