Skip to content
Source
Sign inSign up
TanStack/router

Throwing `notFound()` in loader causes infinite "pending" state #1795

Send to my agent
Closedmelv-n(GitHub profile, opens in a new tab) opened this issue 8 comments

Describe the bug

If you throw notFound() in a loader after a short delay (e.g. when awaiting a request), the parent routes stay forever stuck in "pending" state.

This behaviour does not happen if the loader promise resolves very quick, e.g. within 100ms.

Simplest reproduction:

export const Route = createFileRoute('/posts/$postId')({
  loader: async ({ params }) => {
    try {
      // Simulate a slow request. Resolving this within 100ms works fine, but if it takes longer
      // the route state will be forever stuck in pending.
      await new Promise((resolve, reject) => {
        setTimeout(() => {
          reject();
        }, 1000);
      });
    } catch (err) {
      // Never shows
      throw notFound();
    }
  },

  notFoundComponent: () => <div>Post not found</div>,
});

Your Example Website or App

https://stackblitz.com/edit/tanstack-router-jc3pyp?file=src%2Froutes%2Findex.tsx

Steps to Reproduce the Bug or Issue

  1. Go to /posts/whatever in Stackblitz (posts.$postId.tsx)

Expected behavior

A "Not found message"

Actual behavior

The matched root route is stuck in a pending state according to the dev tools, the final route correctly has "not found" state.

This causes the page to never load.

Platform

  • OS: macOS
  • Browser: Arc (Chrome)
  • Version: 1.47

Additional context

No response

  1. melv-n(GitHub profile, opens in a new tab) changed the title

  2. melv-n(GitHub profile, opens in a new tab) changed the title

  3. @tannerlinsley This is currently very broken, where the router gets forever stuck in a pending state when throw notFound() in any async loader or beforeLoad. Latest TSR version (v1.40.0)

    Simplest repro (updated Stackblitz):

    export const Route = createFileRoute('/posts/$postId')({
      loader: async ({ params }) => {
        try {
          // Simulate a slow request. Resolving this within 100ms works fine, but if it takes longer
          // the route state will be forever stuck in pending.
          await new Promise((resolve, reject) => {
            setTimeout(() => {
              reject();
            }, 1000);
          });
        } catch (err) {
          // Never shows
          throw notFound();
        }
      },
    
      // Expectation: See this component after 1000ms
      notFoundComponent: () => <div>Post not found</div>,
    });
  4. melv-n(GitHub profile, opens in a new tab) changed the title

  5. @schiller-manuel Would be amazing if you could confirm this use-case is also solved by #1907 😍

  6. This will be fixed in 752a136140de515c5cf48d3da5cb88cc44d3c97c

  7. SeanCassiere added labelsbug

  8. I still have the same issue now

  9. @myeljoud please create a new GitHub issue including a complete minimal example

  10. I am getting something similar but I can't seem to reproduce. I am very sad and tired. Just in my project. 😞

Sign in to join this conversation.