fix(start-plugin-core): Remove framework specific packages from being required #5409
main fromrefs/pull/5409/head·merged by schiller-manuel(GitHub profile, opens in a new tab) Hopefully fixes #5398 part 2
@schiller-manuel thanks for merging #5408. I've now tested the new version, and now I have encountered the next issue:
packages/start-plugin-core/src/start-compiler-plugin/plugin.ts also contains this snippet of code:
...resolveRuntimeFiles({
package: `@tanstack/${framework}-start-client`,
files: ['index.js'],
}),
I believe this is supposed to be either react-start-client or solid-start-client. Without declaring the dependency, we run into the error:
Error: Cannot find module '@tanstack/react-start-client/package.json'
Whichever one is needed must also be declared in dependencies, and it seems like incorrect design to me to add both to dependencies. I think the best way to handle this is using peerDependencies with peerDependenciesMeta to declare them as optional. This way since react-start and solid-start already declare both start-plugin-core and their respect -start-client packages as dependencies, theoretically this should cleanly resolve the issue.
Do you have an opinion on this? c.c. @tannerlinsley
Summary by CodeRabbit#
New Features
- None
Bug Fixes
- None
Refactor
- Streamlined build transformation by removing framework-specific client runtime resolution.
- Fewer runtime files are excluded from inlining, improving build predictability and reducing unnecessary processing.
- No changes to public APIs or user-facing behavior.
- 1
github-actions[bot](GitHub profile, opens in a new tab) added labelspackage: start-plugin-core
View your CI Pipeline Execution ↗ for commit 0ff49afba9be7027a4ae6cc028737c355dc865f5
Command Status Duration Result nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded 4m 28s View ↗ nx run-many --target=build --exclude=examples/*...✅ Succeeded 16s View ↗
☁️ Nx Cloud last updated this comment at
2025-10-09 23:58:43UTCMore templates
- tanstack-router-solid-example-basic
- tanstack-router-solid-example-basic-devtools-panel
- tanstack-router-solid-example-basic-file-based
- tanstack-router-solid-example-basic-non-nested-devtools
- tanstack-router-solid-example-basic-solid-query
- tanstack-router-solid-example-basic-solid-query-file-based
- tanstack-router-solid-example-basic-ssr-streaming-file-based
- tanstack-router-solid-example-kitchen-sink-file-based
- tanstack-router-solid-example-quickstart-file-based
- tanstack-solid-start-example-bare
- tanstack-solid-start-example-basic
- tanstack-solid-start-example-basic-static
- tanstack-router-react-example-authenticated-routes
- tanstack-router-react-example-authenticated-routes-firebase
- tanstack-router-react-example-basic
- tanstack-router-react-example-basic-default-search-params
- tanstack-router-react-example-basic-devtools-panel
- tanstack-router-react-example-basic-file-based
- tanstack-router-react-example-basic-non-nested-devtools
- tanstack-router-react-example-react-query
- tanstack-router-react-example-basic-react-query-file-based
- tanstack-router-react-example-basic-ssr-file-based
- tanstack-router-react-example-basic-ssr-streaming-file-based
- tanstack-router-react-example-basic-virtual-file-based
- tanstack-router-react-example-basic-virtual-inside-file-based
- tanstack-router-react-example-deferred-data
- tanstack-router-i18n-paraglide
- tanstack-router-react-example-kitchen-sink
- tanstack-router-react-example-kitchen-sink-file-based
- tanstack-router-react-example-kitchen-sink-react-query
- tanstack-router-react-example-kitchen-sink-react-query-file-based
- tanstack-router-react-example-large-file-based
- tanstack-router-react-example-location-masking
- tanstack-router-react-example-navigation-blocking
- tanstack-router-react-example-quickstart
- tanstack-router-react-example-quickstart-esbuild-file-based
- tanstack-router-react-example-quickstart-file-based
- tanstack-router-react-example-quickstart-rspack-file-based
- tanstack-router-react-example-quickstart-webpack-file-based
- router-monorepo-react-query
- router-mono-simple
- router-mono-simple-lazy
- tanstack-router-react-example-scroll-restoration
- tanstack-search-validator-adapters
- tanstack-start-example-bare
- tanstack-start-example-basic
- tanstack-start-example-basic-auth
- tanstack-start-example-basic-cloudflare
- tanstack-start-example-basic-react-query
- tanstack-start-example-basic-static
- tanstack-start-bun-hosting
- tanstack-start-example-convex-trellaux
- tanstack-start-example-counter
- tanstack-start-i18n-paraglide
- tanstack-start-example-large
- tanstack-start-example-material-ui
- tanstack-start-streaming-data-from-server-functions
- tanstack-start-example-supabase-basic
- tanstack-start-tailwind-v4
- tanstack-start-example-trellaux
- tanstack-start-example-workos
- tanstack-router-react-example-view-transitions
- tanstack-router-react-example-with-framer-motion
- tanstack-router-react-example-with-trpc
- tanstack-router-react-example-with-trpc-react-query
@tanstack/arktype-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5409@tanstack/directive-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5409@tanstack/eslint-plugin-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5409@tanstack/history
npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5409@tanstack/nitro-v2-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5409@tanstack/react-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5409@tanstack/react-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5409@tanstack/react-router-ssr-query
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5409@tanstack/react-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5409@tanstack/react-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5409@tanstack/react-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5409@tanstack/router-cli
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5409@tanstack/router-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5409@tanstack/router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5409@tanstack/router-devtools-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5409@tanstack/router-generator
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5409@tanstack/router-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5409@tanstack/router-ssr-query-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5409@tanstack/router-utils
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5409@tanstack/router-vite-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5409@tanstack/server-functions-plugin
npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5409@tanstack/solid-router
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5409@tanstack/solid-router-devtools
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5409@tanstack/solid-start
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5409@tanstack/solid-start-client
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5409@tanstack/solid-start-server
npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5409@tanstack/start-client-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5409@tanstack/start-plugin-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5409@tanstack/start-server-core
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5409@tanstack/start-static-server-functions
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5409@tanstack/start-storage-context
npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5409@tanstack/valibot-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5409@tanstack/virtual-file-routes
npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5409@tanstack/zod-adapter
npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5409commit:
0ff49afonlywei(GitHub profile, opens in a new tab) changed the title
i think we should just remove this
...resolveRuntimeFiles({ package: `@tanstack/${framework}-start-client`, files: ['index.js'], }),i think we should just remove this
...resolveRuntimeFiles({ package: `@tanstack/${framework}-start-client`, files: ['index.js'], }),Is it not needed?
it was an optimization to compile less (unnecessarily), but since we restructured exports etc. this is not doing anything anymore
onlywei(GitHub profile, opens in a new tab) changed the title
it was an optimization to compile less (unnecessarily), but since we restructured exports etc. this is not doing anything anymore
Alright. PR is now updated.
@schiller-manuel Sweet. I've tested the new release (v1.132.52) and it's working now in my monorepo!
Sign in to join this conversation.
Walkthrough#
Adds two workspace-scoped peerDependencies to packages/start-plugin-core/package.json and marks them optional via peerDependenciesMeta. No runtime code or control flow changed.
Changes#
packages/start-plugin-core/package.jsonpeerDependenciesentries:@tanstack/react-start-client:workspace:*,@tanstack/solid-start-client:workspace:*. AddedpeerDependenciesMetaentries marking both packages as"optional": true.Estimated code review effort#
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem#
Pre-merge checks and finishing touches#
✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share