Skip to content
Source
Sign inSign up
TanStack/router

stabilize test #7304

Closedschiller-manuel(GitHub profile, opens in a new tab)wants to merge 2 commits intomain fromstabilize-test-3004opened

Summary by CodeRabbit

  • Tests
    • Optimized HMR (Hot Module Reloading) test helper logic for improved reliability and reduced test execution time.

Note: This release contains internal test infrastructure improvements with no user-facing changes.

    1. No actionable comments were generated in the recent review. 🎉

      ℹ️ Recent review info
      ⚙️ Run configuration

      Configuration used: defaults

      Review profile: CHILL

      Plan: Pro

      Run ID: 91f04314-a7ef-4076-8a22-79379d2552d9

      📥 Commits

      Reviewing files that changed from the base of the PR and between dad0ec8f41fbc11a8c964604cdbbfa51ab1a40ae and 4af0509f5f6b2ff16a93c712362b5cc57f4e3a15.

      📒 Files selected for processing (1)
      • e2e/react-start/hmr/tests/app.spec.ts

      📝 Walkthrough

      Walkthrough

      The test helper restoreRouteFiles is simplified to restore only when file content differs from the original. The beforeEach logic transitions from array-based to set-based pending-key tracking. Two HMR test scenarios remove explicit waits (one removes a hydration-safe reload step, another removes a 300ms timeout), and a root loader test adds an assertion after the first increment click.

      Changes

      Cohort / File(s)Summary
      HMR Test Modifications
      e2e/react-start/hmr/tests/app.spec.ts
      Simplified restoreRouteFiles helper to remove forced key acceptance; refactored beforeEach from array to set-based pending tracking; removed explicit hydration-safe reload and 300ms timeout steps from two HMR scenarios; added count assertion after first increment in root loader test.

      Estimated code review effort

      🎯 2 (Simple) | ⏱️ ~8 minutes

      Poem

      🐰 A helper grows lean and mean today, Sets replace arrays in every way, Timeouts vanish, reloads fade, Test assertions perfectly made! ✨

      🚥 Pre-merge checks | ✅ 3 | ❌ 2

      ❌ Failed checks (1 warning, 1 inconclusive)

      Check nameStatusExplanationResolution
      Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
      Title check❓ InconclusiveThe title 'stabilize test' is vague and generic, failing to clearly convey what specific test is being stabilized or what changes were made to achieve this.Use a more descriptive title that identifies the specific test file or testing scenario being stabilized, such as 'Stabilize HMR test by simplifying route file restoration logic' or similar.
      ✅ Passed checks (3 passed)
      Check nameStatusExplanation
      Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
      Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
      Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
      ✏️ Tip: You can configure your own custom pre-merge checks in the settings.
      ✨ Finishing Touches
      📝 Generate docstrings
      • Create stacked PR
      • Commit on current branch
      🧪 Generate unit tests (beta)
      • Create PR with unit tests
      • Commit unit tests in branch `stabilize-test-3004`

      Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment `@coderabbitai help` to get the list of available commands and usage tips.
    2. View your CI Pipeline Execution ↗ for commit 4af0509f5f6b2ff16a93c712362b5cc57f4e3a15

      CommandStatusDurationResult
      nx affected --targets=test:eslint,test:unit,tes...❌ Failed5m 18sView ↗
      nx run-many --target=build --exclude=examples/*...✅ Succeeded14sView ↗

      ☁️ Nx Cloud last updated this comment at 2026-04-30 20:00:54 UTC

    3. 🚀 Changeset Version Preview

      1 package(s) bumped directly, 4 bumped as dependents.

      🟩 Patch bumps

      PackageVersionReason
      @tanstack/start-plugin-core1.169.8 → 1.169.9Changeset
      @tanstack/react-start1.167.53 → 1.167.54Dependent
      @tanstack/react-start-rsc0.0.32 → 0.0.33Dependent
      @tanstack/solid-start1.167.50 → 1.167.51Dependent
      @tanstack/vue-start1.167.46 → 1.167.47Dependent
    4. More templates

      @tanstack/arktype-adapter

      npm i https://pkg.pr.new/@tanstack/arktype-adapter@7304

      @tanstack/eslint-plugin-router

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7304

      @tanstack/eslint-plugin-start

      npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7304

      @tanstack/history

      npm i https://pkg.pr.new/@tanstack/history@7304

      @tanstack/nitro-v2-vite-plugin

      npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7304

      @tanstack/react-router

      npm i https://pkg.pr.new/@tanstack/react-router@7304

      @tanstack/react-router-devtools

      npm i https://pkg.pr.new/@tanstack/react-router-devtools@7304

      @tanstack/react-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7304

      @tanstack/react-start

      npm i https://pkg.pr.new/@tanstack/react-start@7304

      @tanstack/react-start-client

      npm i https://pkg.pr.new/@tanstack/react-start-client@7304

      @tanstack/react-start-rsc

      npm i https://pkg.pr.new/@tanstack/react-start-rsc@7304

      @tanstack/react-start-server

      npm i https://pkg.pr.new/@tanstack/react-start-server@7304

      @tanstack/router-cli

      npm i https://pkg.pr.new/@tanstack/router-cli@7304

      @tanstack/router-core

      npm i https://pkg.pr.new/@tanstack/router-core@7304

      @tanstack/router-devtools

      npm i https://pkg.pr.new/@tanstack/router-devtools@7304

      @tanstack/router-devtools-core

      npm i https://pkg.pr.new/@tanstack/router-devtools-core@7304

      @tanstack/router-generator

      npm i https://pkg.pr.new/@tanstack/router-generator@7304

      @tanstack/router-plugin

      npm i https://pkg.pr.new/@tanstack/router-plugin@7304

      @tanstack/router-ssr-query-core

      npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7304

      @tanstack/router-utils

      npm i https://pkg.pr.new/@tanstack/router-utils@7304

      @tanstack/router-vite-plugin

      npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7304

      @tanstack/solid-router

      npm i https://pkg.pr.new/@tanstack/solid-router@7304

      @tanstack/solid-router-devtools

      npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7304

      @tanstack/solid-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7304

      @tanstack/solid-start

      npm i https://pkg.pr.new/@tanstack/solid-start@7304

      @tanstack/solid-start-client

      npm i https://pkg.pr.new/@tanstack/solid-start-client@7304

      @tanstack/solid-start-server

      npm i https://pkg.pr.new/@tanstack/solid-start-server@7304

      @tanstack/start-client-core

      npm i https://pkg.pr.new/@tanstack/start-client-core@7304

      @tanstack/start-fn-stubs

      npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7304

      @tanstack/start-plugin-core

      npm i https://pkg.pr.new/@tanstack/start-plugin-core@7304

      @tanstack/start-server-core

      npm i https://pkg.pr.new/@tanstack/start-server-core@7304

      @tanstack/start-static-server-functions

      npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7304

      @tanstack/start-storage-context

      npm i https://pkg.pr.new/@tanstack/start-storage-context@7304

      @tanstack/valibot-adapter

      npm i https://pkg.pr.new/@tanstack/valibot-adapter@7304

      @tanstack/virtual-file-routes

      npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7304

      @tanstack/vue-router

      npm i https://pkg.pr.new/@tanstack/vue-router@7304

      @tanstack/vue-router-devtools

      npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7304

      @tanstack/vue-router-ssr-query

      npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7304

      @tanstack/vue-start

      npm i https://pkg.pr.new/@tanstack/vue-start@7304

      @tanstack/vue-start-client

      npm i https://pkg.pr.new/@tanstack/vue-start-client@7304

      @tanstack/vue-start-server

      npm i https://pkg.pr.new/@tanstack/vue-start-server@7304

      @tanstack/zod-adapter

      npm i https://pkg.pr.new/@tanstack/zod-adapter@7304

      commit: 55af04e

    5. Nx Cloud has identified a flaky task in your failed CI:

      🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

      Nx Cloud View detailed reasoning in Nx Cloud ↗


      🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)
    6. Nx Cloud has identified a flaky task in your failed CI:

      🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

      Nx Cloud View detailed reasoning in Nx Cloud ↗


      🎓 Learn more about Self-Healing CI on [nx.dev](https://nx.dev/docs/features/ci-features/self-healing-ci?utm_source=pull-request&utm_medium=comment)
    7. Superseded by #8277, which builds on this contribution and consolidates the related HMR and missing-chunk recovery fixes. Contributor credit is preserved in the replacement.

Sign in to join this conversation.